* [dts] [PATCH V1]framework/ssh_connection: fix output might be int
@ 2020-08-26 1:53 Xiao Qimai
2020-08-26 11:04 ` Xiao, QimaiX
2020-08-27 2:57 ` Tu, Lijuan
0 siblings, 2 replies; 3+ messages in thread
From: Xiao Qimai @ 2020-08-26 1:53 UTC (permalink / raw)
To: dts; +Cc: Xiao Qimai
*. when verify is True in send_expect, the output might be type int.
Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
---
framework/ssh_connection.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/framework/ssh_connection.py b/framework/ssh_connection.py
index e096a9e..c9886b2 100644
--- a/framework/ssh_connection.py
+++ b/framework/ssh_connection.py
@@ -62,7 +62,8 @@ class SSHConnection(object):
def send_expect(self, cmds, expected, timeout=15, verify=False):
self.logger.info(cmds)
out = self.session.send_expect(cmds, expected, timeout, verify)
- self.logger.debug(out.replace(cmds, ''))
+ if isinstance(out, str):
+ self.logger.debug(out.replace(cmds, ''))
if type(self.history) is list:
self.history.append({"command": cmds, "name": self.name, "output": out})
return out
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dts] [PATCH V1]framework/ssh_connection: fix output might be int
2020-08-26 1:53 [dts] [PATCH V1]framework/ssh_connection: fix output might be int Xiao Qimai
@ 2020-08-26 11:04 ` Xiao, QimaiX
2020-08-27 2:57 ` Tu, Lijuan
1 sibling, 0 replies; 3+ messages in thread
From: Xiao, QimaiX @ 2020-08-26 11:04 UTC (permalink / raw)
To: dts
Tested-by: Xiao Qimai <qimaix.xiao@intel.com>
Regards,
Xiao Qimai
> -----Original Message-----
> From: Xiao, QimaiX <qimaix.xiao@intel.com>
> Sent: Wednesday, August 26, 2020 9:53 AM
> To: dts@dpdk.org
> Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
> Subject: [dts][PATCH V1]framework/ssh_connection: fix output might be int
>
> *. when verify is True in send_expect, the output might be type int.
>
> Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
> ---
> framework/ssh_connection.py | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/framework/ssh_connection.py b/framework/ssh_connection.py
> index e096a9e..c9886b2 100644
> --- a/framework/ssh_connection.py
> +++ b/framework/ssh_connection.py
> @@ -62,7 +62,8 @@ class SSHConnection(object):
> def send_expect(self, cmds, expected, timeout=15, verify=False):
> self.logger.info(cmds)
> out = self.session.send_expect(cmds, expected, timeout, verify)
> - self.logger.debug(out.replace(cmds, ''))
> + if isinstance(out, str):
> + self.logger.debug(out.replace(cmds, ''))
> if type(self.history) is list:
> self.history.append({"command": cmds, "name": self.name, "output":
> out})
> return out
> --
> 2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dts] [PATCH V1]framework/ssh_connection: fix output might be int
2020-08-26 1:53 [dts] [PATCH V1]framework/ssh_connection: fix output might be int Xiao Qimai
2020-08-26 11:04 ` Xiao, QimaiX
@ 2020-08-27 2:57 ` Tu, Lijuan
1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2020-08-27 2:57 UTC (permalink / raw)
To: Xiao, QimaiX, dts; +Cc: Xiao, QimaiX
> Subject: [dts] [PATCH V1]framework/ssh_connection: fix output might be int
>
> *. when verify is True in send_expect, the output might be type int.
>
> Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
Applied
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-27 2:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-26 1:53 [dts] [PATCH V1]framework/ssh_connection: fix output might be int Xiao Qimai
2020-08-26 11:04 ` Xiao, QimaiX
2020-08-27 2:57 ` Tu, Lijuan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).