From: Owen Hilyard <ohilyard@iol.unh.edu>
To: dts@dpdk.org, lihongx.ma@intel.com
Cc: ohilyard@iol.unh.edu, lylavoie@iol.unh.edu
Subject: [dts] [PATCH V1] tests/checksum_offload: Bugfix for bug 529
Date: Wed, 9 Sep 2020 17:08:06 -0400 [thread overview]
Message-ID: <20200909210807.55311-1-ohilyard@iol.unh.edu> (raw)
In-Reply-To: <BN8PR11MB3715526029F2FC27401578269E260@BN8PR11MB3715.namprd11.prod.outlook.com>
added missing quote in template for scapy packets.
rearraged closing down scapy and testpmd to avoid issues with other test
cases.
Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>
---
tests/TestSuite_checksum_offload.py | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/tests/TestSuite_checksum_offload.py b/tests/TestSuite_checksum_offload.py
index c4a877d..f2e9878 100644
--- a/tests/TestSuite_checksum_offload.py
+++ b/tests/TestSuite_checksum_offload.py
@@ -374,7 +374,7 @@ class TestChecksumOffload(TestCase):
def replay_pcap_file_on_tester(self, iface, packet_file_path):
self.tester.send_expect("scapy", ">>>")
self.scapy_exec(f"packets = rdpcap('{packet_file_path}')")
- self.scapy_exec(f"sendp(packets, iface={iface})")
+ self.scapy_exec(f"sendp(packets, iface='{iface}')")
self.tester.send_expect("quit()", "# ")
def validate_packet_list_checksums(self, packets):
@@ -703,7 +703,7 @@ class TestChecksumOffload(TestCase):
for l4 in l4_protos:
for chksum in "", "chksum=0xf":
vf = self.send_pkt_expect_good_bad_from_flag_catch_failure(
- f"eth/IP({chksum})/{l4}()/(X'*50)",
+ f"eth/IP({chksum})/{l4}()/('X'*50)",
"PKT_RX_IP_CKSUM_", f"{l4}",
should_pass=(chksum == ""))
if vf is not None:
@@ -846,14 +846,13 @@ class TestChecksumOffload(TestCase):
# if vf is not None:
# verification_errors.append(vf)
- # tunneled inner
+ self.tester.send_expect("quit", "#")
+ self.dut.send_expect("stop", "testpmd>")
for err in verification_errors:
self.logger.error(str(err))
self.verify(len(verification_errors) == 0, "See previous output")
- self.tester.send_expect("quit", "#")
- self.dut.send_expect("stop", "testpmd>")
def test_hardware_checksum_check_l4_tx(self):
self.checksum_enablehw(self.dut_ports[0])
@@ -887,7 +886,9 @@ class TestChecksumOffload(TestCase):
error_messages = self.validate_packet_list_checksums(captured_packets)
+ self.tester.send_expect("quit", "#")
self.dut.send_expect("stop", "testpmd>")
+
if len(error_messages) != 0:
for error_msg in error_messages:
self.logger.error(error_msg)
--
2.25.1
next prev parent reply other threads:[~2020-09-09 21:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 15:53 [dts] [PATCH] l4 hardware checksum: " Owen Hilyard
2020-08-27 7:35 ` Chen, BoX C
2020-09-01 2:55 ` Ma, LihongX
2020-09-04 7:13 ` [dts] [PATCH V1] tests/checksum_offload: " Owen Hilyard
2020-09-09 5:32 ` Ma, LihongX
2020-09-09 21:08 ` Owen Hilyard [this message]
2020-09-09 21:14 ` Owen Hilyard
2020-09-09 21:16 ` Owen Hilyard
2020-09-15 8:27 ` Tu, Lijuan
2020-09-10 1:45 ` Ma, LihongX
2020-09-10 1:50 ` Ma, LihongX
2020-09-11 18:33 ` Owen Hilyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200909210807.55311-1-ohilyard@iol.unh.edu \
--to=ohilyard@iol.unh.edu \
--cc=dts@dpdk.org \
--cc=lihongx.ma@intel.com \
--cc=lylavoie@iol.unh.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).