test suite reviews and discussions
 help / color / mirror / Atom feed
From: JiangYuX <yux.jiang@intel.com>
To: dts@dpdk.org
Cc: JiangYu <yux.jiang@intel.com>
Subject: [dts] [PATCH V1 1/2] tests/TestSuite_vm2vm_virtio_pmd: Adapt RTE_LIBRTE_PMD_PCAP updates
Date: Fri, 23 Oct 2020 15:48:27 +0000	[thread overview]
Message-ID: <20201023154828.1274699-2-yux.jiang@intel.com> (raw)
In-Reply-To: <20201023154828.1274699-1-yux.jiang@intel.com>

From: JiangYu <yux.jiang@intel.com>

For DPDK commit: b0b672aea, PMD_PCAP has been defined by default, should not redefine.

Signed-off-by: JiangYu <yux.jiang@intel.com>
---
 tests/TestSuite_vm2vm_virtio_pmd.py | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/tests/TestSuite_vm2vm_virtio_pmd.py b/tests/TestSuite_vm2vm_virtio_pmd.py
index a5c4032..e421285 100644
--- a/tests/TestSuite_vm2vm_virtio_pmd.py
+++ b/tests/TestSuite_vm2vm_virtio_pmd.py
@@ -90,17 +90,17 @@ class TestVM2VMVirtioPMD(TestCase):
         """
         enable pcap lib in dpdk code and recompile
         """
-        client_dut.send_expect("sed -i 's/CONFIG_RTE_LIBRTE_PMD_PCAP=n$/CONFIG_RTE_LIBRTE_PMD_PCAP=y/' config/common_base", "#")
-        client_dut.set_build_options({'RTE_LIBRTE_PMD_PCAP': 'y'})
-        client_dut.build_install_dpdk(self.target)
+        if self.dut.build_type == 'makefile':
+            client_dut.send_expect("sed -i 's/CONFIG_RTE_LIBRTE_PMD_PCAP=n$/CONFIG_RTE_LIBRTE_PMD_PCAP=y/' config/common_base", "#")
+            client_dut.build_install_dpdk(self.target)
 
     def disable_pcap_lib_in_dpdk(self, client_dut):
         """
         reset pcap lib in dpdk and recompile
         """
-        client_dut.send_expect("sed -i 's/CONFIG_RTE_LIBRTE_PMD_PCAP=y$/CONFIG_RTE_LIBRTE_PMD_PCAP=n/' config/common_base", "#")
-        client_dut.set_build_options({'RTE_LIBRTE_PMD_PCAP': 'n'})
-        client_dut.build_install_dpdk(self.target)
+        if self.dut.build_type == 'makefile':
+            client_dut.send_expect("sed -i 's/CONFIG_RTE_LIBRTE_PMD_PCAP=y$/CONFIG_RTE_LIBRTE_PMD_PCAP=n/' config/common_base", "#")
+            client_dut.build_install_dpdk(self.target)
 
     def start_vhost_testpmd(self):
         """
-- 
2.7.4


  parent reply	other threads:[~2020-10-23  7:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-23 15:48 [dts] [PATCH V1 0/2] " JiangYuX
2020-10-23  7:53 ` Jiang, YuX
2020-10-23 15:48 ` JiangYuX [this message]
2020-10-23 15:48 ` [dts] [PATCH V1 2/2] tests/TestSuite_vm2vm_virtio_user: " JiangYuX
2020-10-29  8:10   ` Ma, LihongX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201023154828.1274699-2-yux.jiang@intel.com \
    --to=yux.jiang@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).