test suite reviews and discussions
 help / color / mirror / Atom feed
From: Thinh Tran <thinhtr@linux.vnet.ibm.com>
To: dts@dpdk.org
Cc: thinhtr@linux.vnet.ibm.com
Subject: [dts] [PATCH V2] framework/tester closing scapy session raise exception
Date: Mon, 26 Oct 2020 11:35:13 -0400	[thread overview]
Message-ID: <20201026153513.137685-1-thinhtr@linux.vnet.ibm.com> (raw)

  v1:
  Sending control "^c" during  closing the scapy sessions raised the time-
  out exception for expecting scapy prompt ">>> " return causing the failure
  during setup.
  Simply sending "quit" to exit scapy gratefully instead.

  v2: 
  Sending "quit()" function insteadt of "quit"

Signed-off-by: Thinh Tran <thinhtr@linux.vnet.ibm.com>
---
 framework/tester.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/framework/tester.py b/framework/tester.py
index ca179b2..c515123 100644
--- a/framework/tester.py
+++ b/framework/tester.py
@@ -868,8 +868,7 @@ class Tester(Crb):
         if self.scapy_sessions_li:
             for i in self.scapy_sessions_li:
                 if i.session.isalive():
-                    i.session.send_expect("^c", ">>> ", timeout=2)
-                    i.session.send_expect("^d", "#", timeout=2)
+                    i.session.send_expect("quit()", "#", timeout=2)
                     i.session.close()
             self.scapy_sessions_li.clear()
 
-- 
2.17.0


             reply	other threads:[~2020-10-26 15:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-26 15:35 Thinh Tran [this message]
2020-10-27  9:07 ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201026153513.137685-1-thinhtr@linux.vnet.ibm.com \
    --to=thinhtr@linux.vnet.ibm.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).