test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V2] framework/tester closing scapy session raise exception
@ 2020-10-26 15:35 Thinh Tran
  2020-10-27  9:07 ` Tu, Lijuan
  0 siblings, 1 reply; 2+ messages in thread
From: Thinh Tran @ 2020-10-26 15:35 UTC (permalink / raw)
  To: dts; +Cc: thinhtr

  v1:
  Sending control "^c" during  closing the scapy sessions raised the time-
  out exception for expecting scapy prompt ">>> " return causing the failure
  during setup.
  Simply sending "quit" to exit scapy gratefully instead.

  v2: 
  Sending "quit()" function insteadt of "quit"

Signed-off-by: Thinh Tran <thinhtr@linux.vnet.ibm.com>
---
 framework/tester.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/framework/tester.py b/framework/tester.py
index ca179b2..c515123 100644
--- a/framework/tester.py
+++ b/framework/tester.py
@@ -868,8 +868,7 @@ class Tester(Crb):
         if self.scapy_sessions_li:
             for i in self.scapy_sessions_li:
                 if i.session.isalive():
-                    i.session.send_expect("^c", ">>> ", timeout=2)
-                    i.session.send_expect("^d", "#", timeout=2)
+                    i.session.send_expect("quit()", "#", timeout=2)
                     i.session.close()
             self.scapy_sessions_li.clear()
 
-- 
2.17.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH V2] framework/tester closing scapy session raise exception
  2020-10-26 15:35 [dts] [PATCH V2] framework/tester closing scapy session raise exception Thinh Tran
@ 2020-10-27  9:07 ` Tu, Lijuan
  0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2020-10-27  9:07 UTC (permalink / raw)
  To: Thinh Tran, dts

>   v1:
>   Sending control "^c" during  closing the scapy sessions raised the time-
>   out exception for expecting scapy prompt ">>> " return causing the failure
>   during setup.
>   Simply sending "quit" to exit scapy gratefully instead.
> 
>   v2:
>   Sending "quit()" function insteadt of "quit"
> 
> Signed-off-by: Thinh Tran <thinhtr@linux.vnet.ibm.com>

Applied with comments changed.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-10-27  9:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-26 15:35 [dts] [PATCH V2] framework/tester closing scapy session raise exception Thinh Tran
2020-10-27  9:07 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).