test suite reviews and discussions
 help / color / mirror / Atom feed
From: Chen Linglix <linglix.chen@intel.com>
To: dts@dpdk.org
Cc: Chen Linglix <linglix.chen@intel.com>
Subject: [dts] [dts 2/2] tests/TestSuite_shutdown_api:change_thresholds:Ixgbe not support rx, only support tx
Date: Tue,  3 Nov 2020 15:23:44 +0000	[thread overview]
Message-ID: <20201103152344.1677878-3-linglix.chen@intel.com> (raw)
In-Reply-To: <20201103152344.1677878-1-linglix.chen@intel.com>

DPDK-24129:1.Ixgbe not support rx, only support tx.
           2.foxville, powerville and springville not support txfree and txrs
           3.foxville--eth_igc_tx_queue_setup(): To improve 2.5G driver performance, consider setting the TX WTHRESH value to 4, 8, or 16.

Signed-off-by: Chen Linglix <linglix.chen@intel.com>
---
 tests/TestSuite_shutdown_api.py | 30 ++++++++++++++++++------------
 1 file changed, 18 insertions(+), 12 deletions(-)

diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py
index edd1dcfa..1e98c640 100644
--- a/tests/TestSuite_shutdown_api.py
+++ b/tests/TestSuite_shutdown_api.py
@@ -706,34 +706,40 @@ class TestShutdownApi(TestCase):
     def test_change_thresholds(self):
         """
         Change RX/TX thresholds
+        DPDK-24129:1.CVL and FVL not support tx and rx
+                   2.Ixgbe not support rx, only support tx.
+                   3.foxville, powerville and springville not support txfree and txrs
         """
         self.pmdout.start_testpmd("Default", "--portmask=%s --port-topology=loop" % utils.create_mask(self.ports), socket=self.ports_socket)
         self.dut.send_expect("set promisc all off", "testpmd>")
 
         self.dut.send_expect("port stop all", "testpmd> ", 100)
-        self.dut.send_expect("port config all txfreet 32", "testpmd> ")
-        self.dut.send_expect("port config all txrst 32", "testpmd> ")
+        if self.nic in ["sagepond","sageville","twinpond","niantic"]:
+            self.dut.send_expect("port config all txfreet 32", "testpmd> ")
+            self.dut.send_expect("port config all txrst 32", "testpmd> ")
         self.dut.send_expect("port config all rxfreet 32", "testpmd> ")
         self.dut.send_expect("port config all txpt 64", "testpmd> ")
         self.dut.send_expect("port config all txht 64", "testpmd> ")
-        self.dut.send_expect("port config all txwt 0", "testpmd> ")
-        self.dut.send_expect("port config all rxpt 64", "testpmd> ")
-        self.dut.send_expect("port config all rxht 64", "testpmd> ")
-        self.dut.send_expect("port config all rxwt 64", "testpmd> ")
+        if self.nic in ["foxville"]:
+            self.dut.send_expect("port config all txwt 16", "testpmd> ")
+        else:
+            self.dut.send_expect("port config all txwt 0", "testpmd> ")
+
         self.dut.send_expect("port start all", "testpmd> ", 100)
         out = self.dut.send_expect("show config rxtx", "testpmd> ")
         self.verify("RX free threshold=32" in out,
                     "RX descriptor not reconfigured properly")
-        self.verify("TX free threshold=32" in out,
+        if self.nic in ["sagepond","sageville","twinpond","niantic"]:
+            self.verify("TX free threshold=32" in out,
                     "TX descriptor not reconfigured properly")
-        self.verify("TX RS bit threshold=32" in out,
+            self.verify("TX RS bit threshold=32" in out,
                     "TX descriptor not reconfigured properly")
         self.verify("pthresh=64" in out, "TX descriptor not reconfigured properly")
         self.verify("hthresh=64" in out, "TX descriptor not reconfigured properly")
-        self.verify("wthresh=64" in out, "TX descriptor not reconfigured properly")
-        self.verify("pthresh=64" in out, "TX descriptor not reconfigured properly")
-        self.verify("hthresh=64" in out, "TX descriptor not reconfigured properly")
-        self.verify("wthresh=64" in out, "TX descriptor not reconfigured properly")
+        if self.nic in ["foxville"]:
+            self.verify("wthresh=16" in out, "TX descriptor not reconfigured properly")
+        else:
+            self.verify("wthresh=0" in out, "TX descriptor not reconfigured properly")
         self.dut.send_expect("set fwd mac", "testpmd>")
         self.dut.send_expect("start", "testpmd> ")
         self.check_forwarding()
-- 
2.25.1


  parent reply	other threads:[~2020-11-03  7:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-03 15:23 [dts] [PATCH V1 0/2]tests/TestSuite_shutdown_api:change_thresholds:not support rx Chen Linglix
2020-11-03  7:27 ` Chen, LingliX
2020-11-03 15:23 ` [dts] [dts 1/2] conf/test_case_checklist:change_thresholds:CVL and FVL not support this case(DPDK-24129) Chen Linglix
2020-11-03 15:23 ` Chen Linglix [this message]
2020-11-26  7:41 ` [dts] [PATCH V1 0/2]tests/TestSuite_shutdown_api:change_thresholds:not support rx Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201103152344.1677878-3-linglix.chen@intel.com \
    --to=linglix.chen@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).