test suite reviews and discussions
 help / color / mirror / Atom feed
From: Zhou Jun <junx.w.zhou@intel.com>
To: dts@dpdk.org
Cc: Zhou Jun <junx.w.zhou@intel.com>
Subject: [dts] [dts 27/28] tests/TestSuite_tso:Modify the hard coded app parameter to call the platform interface
Date: Tue,  8 Dec 2020 18:06:26 +0800	[thread overview]
Message-ID: <20201208100627.9792-28-junx.w.zhou@intel.com> (raw)
In-Reply-To: <20201208100627.9792-1-junx.w.zhou@intel.com>

Signed-off-by: Zhou Jun <junx.w.zhou@intel.com>
---
 tests/TestSuite_tso.py | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/tests/TestSuite_tso.py b/tests/TestSuite_tso.py
index d0c67d47..e119b3fd 100644
--- a/tests/TestSuite_tso.py
+++ b/tests/TestSuite_tso.py
@@ -77,9 +77,7 @@ class TestTSO(TestCase):
             self.table_header.append("%s Mpps" % test_cycle['cores'])
             self.table_header.append("% linerate")
 
-        self.eal_param = ""
-        for i in self.dut_ports:
-            self.eal_param += " -w %s" % self.dut.ports_info[i]['pci']
+        self.eal_param = self.dut.create_eal_parameters(cores='1S/1C/2T')
 
         self.headers_size = HEADER_SIZE['eth'] + HEADER_SIZE[
             'ip'] + HEADER_SIZE['tcp']
@@ -201,9 +199,9 @@ class TestTSO(TestCase):
         self.tester.send_expect("ip l set %s up" % tx_interface, "# ")
 
         if (self.nic in ["cavium_a063","cavium_a064"]):
-            cmd = "%s -c %s -n %d %s -- -i --rxd=512 --txd=512 --burst=32 --rxfreet=64 --mbcache=128 --portmask=%s --max-pkt-len=%s --txpt=36 --txht=0 --txwt=0 --txfreet=32 --txrst=32 --tx-offloads=0x8000" % (self.path, self.coreMask, self.dut.get_memory_channels(), self.eal_param, self.portMask, TSO_MTU)
+            cmd = "%s %s -- -i --rxd=512 --txd=512 --burst=32 --rxfreet=64 --mbcache=128 --portmask=%s --max-pkt-len=%s --txpt=36 --txht=0 --txwt=0 --txfreet=32 --txrst=32 --tx-offloads=0x8000" % (self.path, self.eal_param, self.portMask, TSO_MTU)
         else:
-            cmd = "%s -c %s -n %d %s -- -i --rxd=512 --txd=512 --burst=32 --rxfreet=64 --mbcache=128 --portmask=%s --max-pkt-len=%s --txpt=36 --txht=0 --txwt=0 --txfreet=32 --txrst=32 " % (self.path, self.coreMask, self.dut.get_memory_channels(), self.eal_param, self.portMask, TSO_MTU)
+            cmd = "%s %s -- -i --rxd=512 --txd=512 --burst=32 --rxfreet=64 --mbcache=128 --portmask=%s --max-pkt-len=%s --txpt=36 --txht=0 --txwt=0 --txfreet=32 --txrst=32 " % (self.path, self.eal_param, self.portMask, TSO_MTU)
 
         self.dut.send_expect(cmd, "testpmd> ", 120)
         self.dut.send_expect("set verbose 1", "testpmd> ", 120)
@@ -298,7 +296,7 @@ class TestTSO(TestCase):
         self.tester.send_expect("ethtool -K %s rx off tx off tso off gso off gro off lro off" % tx_interface, "# ")
         self.tester.send_expect("ip l set %s up" % tx_interface, "# ")
 
-        cmd = "%s -c %s -n %d %s -- -i --rxd=512 --txd=512 --burst=32 --rxfreet=64 --mbcache=128 --portmask=%s --max-pkt-len=%s --txpt=36 --txht=0 --txwt=0 --txfreet=32 --txrst=32 " % (self.path, self.coreMask, self.dut.get_memory_channels(), self.eal_param, self.portMask, TSO_MTU)
+        cmd = "%s %s -- -i --rxd=512 --txd=512 --burst=32 --rxfreet=64 --mbcache=128 --portmask=%s --max-pkt-len=%s --txpt=36 --txht=0 --txwt=0 --txfreet=32 --txrst=32 " % (self.path, self.eal_param, self.portMask, TSO_MTU)
         self.dut.send_expect(cmd, "testpmd> ", 120)
         self.dut.send_expect("set verbose 1", "testpmd> ", 120)
         self.dut.send_expect("port stop all", "testpmd> ", 120)
@@ -398,7 +396,7 @@ class TestTSO(TestCase):
             else:
                 queues = 1
 
-            command_line = "%s -c %s -n %d %s -- -i --rxd=512 --txd=512 --burst=32 --rxfreet=64 --mbcache=128 --portmask=%s --max-pkt-len=%s --txpt=36 --txht=0 --txwt=0 --txfreet=32 --txrst=32 " % (self.path, self.coreMask, self.dut.get_memory_channels(), self.eal_param, self.portMask, TSO_MTU)
+            command_line = "%s %s -- -i --rxd=512 --txd=512 --burst=32 --rxfreet=64 --mbcache=128 --portmask=%s --max-pkt-len=%s --txpt=36 --txht=0 --txwt=0 --txfreet=32 --txrst=32 " % (self.path, self.eal_param, self.portMask, TSO_MTU)
             info = "Executing PMD using %s\n" % test_cycle['cores']
             self.logger.info(info)
             self.rst_report(info, annex=True)
-- 
2.17.1


  parent reply	other threads:[~2020-12-08 10:04 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-08 10:05 [dts] [PATCH V1 00/28] Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 01/28] tests/TestSuite_hello_world:Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 02/28] tests/TestSuite_hotplug:Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 03/28] tests/TestSuite_inline_ipsec:Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 04/28] tests/TestSuite_interrupt_pmd:Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 05/28] tests/TestSuite_ip_pipeline:Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 06/28] tests/TestSuite_ipfrag:Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 07/28] tests/TestSuite_ipv4_reassembly:Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 08/28] tests/TestSuite_keep_alive:Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 09/28] tests/TestSuite_kni:Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 10/28] tests/TestSuite_l2fwd_jobstats:Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 11/28] tests/TestSuite_l3fwdacl:Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 12/28] tests/TestSuite_link_status_interrupt:Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 13/28] tests/TestSuite_metering_and_policing:Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 14/28] tests/TestSuite_multicast:Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 15/28] tests/TestSuite_multiprocess:Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 16/28] tests/TestSuite_packet_ordering:Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 17/28] tests/TestSuite_pmdpcap:Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 18/28] tests/TestSuite_pmdrss_hash:Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 19/28] tests/TestSuite_pmdrssreta:Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 20/28] tests/TestSuite_ptpclient:Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 21/28] tests/TestSuite_queue_start_stop:Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 22/28] tests/TestSuite_rxtx_callbacks:Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 23/28] tests/TestSuite_short_live:Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 24/28] tests/TestSuite_skeleton:Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 25/28] tests/TestSuite_softnic:Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 26/28] tests/TestSuite_timer:Modify " Zhou Jun
2020-12-08 10:06 ` Zhou Jun [this message]
2020-12-08 10:06 ` [dts] [dts 28/28] tests/TestSuite_userspace_ethtool:Modify " Zhou Jun
2020-12-09  1:53 ` [dts] [PATCH V1 00/28] Modify " Zhao, HaiyangX
2020-12-10  8:43 ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201208100627.9792-28-junx.w.zhou@intel.com \
    --to=junx.w.zhou@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).