From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6F7C6A09FF; Fri, 25 Dec 2020 02:46:33 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2EE112BA2; Fri, 25 Dec 2020 02:46:32 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 9E97B26A8 for ; Fri, 25 Dec 2020 02:46:28 +0100 (CET) IronPort-SDR: w1zo9LmnTePNI/wH5A7Kxa0lQYPBFKS0k+rji8LtSFltZZx8yc8sWypFdrH5xGzIG4uULYiYXq bQNoupFY1DPQ== X-IronPort-AV: E=McAfee;i="6000,8403,9845"; a="175414670" X-IronPort-AV: E=Sophos;i="5.78,446,1599548400"; d="scan'208";a="175414670" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Dec 2020 17:46:26 -0800 IronPort-SDR: ZElbulcXMCW/Li95rEQlb6JKGk/DF1Fbo8TdwxyQonFIY/8vIyocHPBFnWgX0kxDSNks/7E3pp slOCwdID7k2A== X-IronPort-AV: E=Sophos;i="5.78,446,1599548400"; d="scan'208";a="357589052" Received: from unknown (HELO localhost.localdomain) ([10.240.183.80]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Dec 2020 17:46:25 -0800 From: Xie wei To: dts@dpdk.org Cc: Xie wei Date: Fri, 25 Dec 2020 09:48:47 +0800 Message-Id: <20201225014847.20173-1-weix.xie@intel.com> X-Mailer: git-send-email 2.17.1 Subject: [dts] [PATCH V1] tests/TestSuite_dcf_lifecycle:change the way to get cores X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" 1.change the way to get cores, some env cores are less than 14, it makes testpmd launch failed. And when several testpmd are started at the same time, different cores should be used. 2.the ACL rule id need to match, not hard code. Signed-off-by: Xie wei --- tests/TestSuite_dcf_lifecycle.py | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/tests/TestSuite_dcf_lifecycle.py b/tests/TestSuite_dcf_lifecycle.py index f3189316..b5e60183 100644 --- a/tests/TestSuite_dcf_lifecycle.py +++ b/tests/TestSuite_dcf_lifecycle.py @@ -307,8 +307,7 @@ class TestDcfLifeCycle(TestCase): def start_vf_dcf_testpmd(self, pmd_opiton): whitelist_name, prefix = pmd_opiton - cores = self.corelist[:5] - core_mask = utils.create_mask(cores) + core_mask = utils.create_mask(self.core_pf) whitelist = self.vf_whitelist().get(whitelist_name) cmd = ( "{bin} " @@ -367,8 +366,7 @@ class TestDcfLifeCycle(TestCase): def start_vf_testpmd2(self, pmd_opiton): whitelist_name, prefix = pmd_opiton - cores = self.corelist[5:] - core_mask = utils.create_mask(cores) + core_mask = utils.create_mask(self.core_vf) whitelist = self.vf_whitelist().get(whitelist_name) cmd = ( "{bin} " @@ -997,8 +995,9 @@ class TestDcfLifeCycle(TestCase): def preset_pmd_res(self): self.dcf_dev_id = '8086:1889' self.socket = self.dut.get_numa_id(self.dut_ports[0]) - self.corelist = self.dut.get_core_list( - "1S/14C/1T", socket=self.socket)[4:] + self.dut.init_reserved_core() + self.core_pf = self.dut.get_reserved_core('2C', 0) + self.core_vf = self.dut.get_reserved_core('2C', 0) def clear_flags(self): self.is_vf_dcf_pmd_on = self.is_vf_pmd2_on = False @@ -1268,12 +1267,14 @@ class TestDcfLifeCycle(TestCase): self.verify('rmgr: Cannot insert RX class rule: No such file or directory' in out, 'success to add ACL filter') else: - self.verify('Added rule with ID 15871' in out, 'add rule failed') + pattern = re.compile('.*Added\s+rule\s+with\s+ID\s+(\d+)') + res = re.search(pattern, out) + self.verify(res, 'NO ACL rule id matched') + self.rule_id = res.group(1) def launch_dcf_testpmd(self): # launch testpmd on VF0 requesting for DCF funtionality - cores = self.corelist[:5] - core_mask = utils.create_mask(cores) + core_mask = utils.create_mask(self.core_pf) whitelist = self.vf_whitelist().get('pf1_vf0_dcf') cmd_dcf = ( "{bin} " @@ -1296,7 +1297,7 @@ class TestDcfLifeCycle(TestCase): def delete_acl_rule_by_kernel_cmd(self, port_id=0): # delete the kernel ACL rule intf = self.dut.ports_info[port_id]['port'].intf_name - self.d_a_con('ethtool -N %s delete 15871' % intf) + self.d_a_con('ethtool -N %s delete %s' % (intf, self.rule_id)) def test_handle_acl_filter_01(self): ''' @@ -1356,8 +1357,7 @@ class TestDcfLifeCycle(TestCase): self.send_pkt_to_vf1_again() # re-launch AVF on VF0 - cores = self.corelist[:5] - core_mask = utils.create_mask(cores) + core_mask = utils.create_mask(self.core_pf) whitelist = self.vf_whitelist().get('pf1_vf0') cmd = ( "{bin} " -- 2.17.1