test suite reviews and discussions
 help / color / mirror / Atom feed
From: Xie wei <weix.xie@intel.com>
To: dts@dpdk.org
Cc: Xie wei <weix.xie@intel.com>
Subject: [dts] [PATCH V1 1/2] tests/vf_jumboframe: change jumbo frames to adpat dpdk
Date: Thu,  4 Feb 2021 17:07:44 +0800
Message-ID: <20210204090745.21686-2-weix.xie@intel.com> (raw)
In-Reply-To: <20210204090745.21686-1-weix.xie@intel.com>

a).According to dpdk commit e8326d3, fix Rx bytes statistics.
After testing, found that:
when send a packet which length is 1513 bytes.
for i40e nic; the statistic from "show port stats 0" is: RX-bytes: 1513,
but before that it show "RX-bytes: 1517".
b).DPDK can receive max packet length is mtu + 14(IP_hearder_len) + 4(CRC) + 4(VLAN header len) + 4(VLAN header len).

Signed-off-by: Xie wei <weix.xie@intel.com>
---
 tests/TestSuite_vf_jumboframe.py | 19 +++----------------
 1 file changed, 3 insertions(+), 16 deletions(-)

diff --git a/tests/TestSuite_vf_jumboframe.py b/tests/TestSuite_vf_jumboframe.py
index cb77cf31..3eb441f2 100644
--- a/tests/TestSuite_vf_jumboframe.py
+++ b/tests/TestSuite_vf_jumboframe.py
@@ -192,11 +192,6 @@ class TestVfJumboFrame(TestCase):
         else:
             return None
 
-    def check_vf_driver(self):
-        output = self.vm_testpmd.execute_cmd("show port info 0")
-        vf0_driver = re.findall("Driver\s*name:\s*(\w+)", output)
-        return vf0_driver[0]
-
     def jumboframes_send_packet(self, pktsize, received=True):
         """
         Send 1 packet to portid
@@ -221,19 +216,11 @@ class TestVfJumboFrame(TestCase):
         rx_bytes -= rx_bytes_ori
         rx_err -= rx_err_ori
 
-        vf_driver = self.check_vf_driver()
-
         if received:
             self.verify((rx_pkts == 1) and (tx_pkts == 1), "Packet forward assert error")
 
-            if self.kdriver == "ixgbe" or self.kdriver == 'ice':
+            if self.kdriver in ["ixgbe", "ice", "i40e"]:
                 self.verify((rx_bytes + 4) == pktsize, "Rx packet size should be packet size - 4")
-            else:
-                if self.kdriver == "i40e":
-                    if vf_driver == "net_iavf":
-                        self.verify((rx_bytes + 4) == pktsize, "Rx packet size should be packet size - 4")
-                    else:
-                        self.verify(rx_bytes == pktsize, "Rx packet size should be equal to packet size")
 
             if self.kdriver == "igb":
                 self.verify(tx_bytes == pktsize, "Tx packet size should be packet size")
@@ -293,7 +280,7 @@ class TestVfJumboFrame(TestCase):
         self.vm_testpmd.execute_cmd("start")
 
         # On igb, for example i350, refer to :DPDK-1117
-        # For PF, the max-pkt-len = mtu + 18 + 4(VLAN header len).
+        # For PF, the max-pkt-len = mtu + 14(IP_hearder_len) + 4(CRC) + 4(VLAN header len) + 4(VLAN header len).
         # For VF, the real max-pkt-len = the given max-pkt-len + 4(VLAN header len).
         # This behavior is leveraged from kernel driver.
         # And it means max-pkt-len is always 4 bytes longer than assumed.
@@ -301,7 +288,7 @@ class TestVfJumboFrame(TestCase):
         if self.kdriver == "igb":
             self.jumboframes_send_packet(ETHER_STANDARD_MTU + 1 + 4, False)
         else:
-            self.jumboframes_send_packet(ETHER_STANDARD_MTU + 1, False)
+            self.jumboframes_send_packet(ETHER_STANDARD_MTU + 1 + 4 + 4, False)
 
     def test_vf_jumbo_withjumbo(self):
         """
-- 
2.17.1


  reply	other threads:[~2021-02-04  9:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-04  9:07 [dts] [PATCH V1 0/2] " Xie wei
2021-02-04  9:07 ` Xie wei [this message]
2021-02-04  9:07 ` [dts] [PATCH V1 2/2] tests/kernelpf_iavf: " Xie wei
2021-02-04  9:13 ` [dts] [PATCH V1 0/2] " Xie, WeiX
2021-02-05  1:55   ` Zhao, HaiyangX
2021-02-19  7:23     ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210204090745.21686-2-weix.xie@intel.com \
    --to=weix.xie@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ https://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git