From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1A22CA09E4; Thu, 4 Feb 2021 10:04:06 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0F9FE2405F2; Thu, 4 Feb 2021 10:04:06 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 621B32405DD for ; Thu, 4 Feb 2021 10:04:04 +0100 (CET) IronPort-SDR: YIzDSD+xq5p8qiE49Aa3qdvP5R//SIGwQ6RzK4hmD3EbrB+1T+m4nfyxiY1It3c9H8fDZMXiia NvL2x3SxSMQw== X-IronPort-AV: E=McAfee;i="6000,8403,9884"; a="245274232" X-IronPort-AV: E=Sophos;i="5.79,400,1602572400"; d="scan'208";a="245274232" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Feb 2021 01:04:03 -0800 IronPort-SDR: DXkPix9bn4WmqfV1wrUoDEC1jufId6rpmwyQ3/5APt8oAJJMJ/Nuzyn6f/tJaZr7d+JFyyVu7I fzD+eCSDzmkA== X-IronPort-AV: E=Sophos;i="5.79,400,1602572400"; d="scan'208";a="372397378" Received: from unknown (HELO localhost.localdomain) ([10.240.183.80]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Feb 2021 01:04:02 -0800 From: Xie wei To: dts@dpdk.org Cc: Xie wei Date: Thu, 4 Feb 2021 17:07:44 +0800 Message-Id: <20210204090745.21686-2-weix.xie@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210204090745.21686-1-weix.xie@intel.com> References: <20210204090745.21686-1-weix.xie@intel.com> Subject: [dts] [PATCH V1 1/2] tests/vf_jumboframe: change jumbo frames to adpat dpdk X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" a).According to dpdk commit e8326d3, fix Rx bytes statistics. After testing, found that: when send a packet which length is 1513 bytes. for i40e nic; the statistic from "show port stats 0" is: RX-bytes: 1513, but before that it show "RX-bytes: 1517". b).DPDK can receive max packet length is mtu + 14(IP_hearder_len) + 4(CRC) + 4(VLAN header len) + 4(VLAN header len). Signed-off-by: Xie wei --- tests/TestSuite_vf_jumboframe.py | 19 +++---------------- 1 file changed, 3 insertions(+), 16 deletions(-) diff --git a/tests/TestSuite_vf_jumboframe.py b/tests/TestSuite_vf_jumboframe.py index cb77cf31..3eb441f2 100644 --- a/tests/TestSuite_vf_jumboframe.py +++ b/tests/TestSuite_vf_jumboframe.py @@ -192,11 +192,6 @@ class TestVfJumboFrame(TestCase): else: return None - def check_vf_driver(self): - output = self.vm_testpmd.execute_cmd("show port info 0") - vf0_driver = re.findall("Driver\s*name:\s*(\w+)", output) - return vf0_driver[0] - def jumboframes_send_packet(self, pktsize, received=True): """ Send 1 packet to portid @@ -221,19 +216,11 @@ class TestVfJumboFrame(TestCase): rx_bytes -= rx_bytes_ori rx_err -= rx_err_ori - vf_driver = self.check_vf_driver() - if received: self.verify((rx_pkts == 1) and (tx_pkts == 1), "Packet forward assert error") - if self.kdriver == "ixgbe" or self.kdriver == 'ice': + if self.kdriver in ["ixgbe", "ice", "i40e"]: self.verify((rx_bytes + 4) == pktsize, "Rx packet size should be packet size - 4") - else: - if self.kdriver == "i40e": - if vf_driver == "net_iavf": - self.verify((rx_bytes + 4) == pktsize, "Rx packet size should be packet size - 4") - else: - self.verify(rx_bytes == pktsize, "Rx packet size should be equal to packet size") if self.kdriver == "igb": self.verify(tx_bytes == pktsize, "Tx packet size should be packet size") @@ -293,7 +280,7 @@ class TestVfJumboFrame(TestCase): self.vm_testpmd.execute_cmd("start") # On igb, for example i350, refer to :DPDK-1117 - # For PF, the max-pkt-len = mtu + 18 + 4(VLAN header len). + # For PF, the max-pkt-len = mtu + 14(IP_hearder_len) + 4(CRC) + 4(VLAN header len) + 4(VLAN header len). # For VF, the real max-pkt-len = the given max-pkt-len + 4(VLAN header len). # This behavior is leveraged from kernel driver. # And it means max-pkt-len is always 4 bytes longer than assumed. @@ -301,7 +288,7 @@ class TestVfJumboFrame(TestCase): if self.kdriver == "igb": self.jumboframes_send_packet(ETHER_STANDARD_MTU + 1 + 4, False) else: - self.jumboframes_send_packet(ETHER_STANDARD_MTU + 1, False) + self.jumboframes_send_packet(ETHER_STANDARD_MTU + 1 + 4 + 4, False) def test_vf_jumbo_withjumbo(self): """ -- 2.17.1