test suite reviews and discussions
 help / color / mirror / Atom feed
From: sunqin <qinx.sun@intel.com>
To: dts@dpdk.org
Cc: sunqin <qinx.sun@intel.com>
Subject: [dts] [PATCH V1] tests/cvl_advanced_rss_pppoe_vlan_esp_ah_l2tp_pfcp: remove invalid case
Date: Fri,  5 Feb 2021 16:47:09 +0000
Message-ID: <20210205164709.31384-1-qinx.sun@intel.com> (raw)

duplicated_rules confirmed as an invalid case,so remove it from test plan and suite.

Signed-off-by: sunqin <qinx.sun@intel.com>
---
 ..._pppoe_vlan_esp_ah_l2tp_pfcp_test_plan.rst | 23 ++++---------------
 ...dvanced_rss_pppoe_vlan_esp_ah_l2tp_pfcp.py |  7 ------
 2 files changed, 4 insertions(+), 26 deletions(-)

diff --git a/test_plans/cvl_advanced_rss_pppoe_vlan_esp_ah_l2tp_pfcp_test_plan.rst b/test_plans/cvl_advanced_rss_pppoe_vlan_esp_ah_l2tp_pfcp_test_plan.rst
index 52702686..f60c9ec7 100644
--- a/test_plans/cvl_advanced_rss_pppoe_vlan_esp_ah_l2tp_pfcp_test_plan.rst
+++ b/test_plans/cvl_advanced_rss_pppoe_vlan_esp_ah_l2tp_pfcp_test_plan.rst
@@ -6024,22 +6024,7 @@ Subcase 1: wrong hash input set
 
   there is no listed.
 
-Subcase 2: duplicated rules (not supported in 20.08)
-----------------------------------------------------
-
-1. create a  PFCP rule::
-
-     testpmd> flow create 0 ingress pattern eth / ipv4 / udp / pfcp / end actions rss types pfcp end key_len 0 queues end / end
-
-   the rule is created successfully.
-
-2. create the same rule again, Failed to create flow, report message::
-
-    Add rule failed.: Operation not permitted
-
-3. check only the first rule exists in the list.
-
-Subcase 3: void action
+Subcase 2: void action
 ----------------------
 
 1. validate a rule with void action::
@@ -6064,7 +6049,7 @@ Subcase 3: void action
 
    there is no rule listed.
 
-Subcase 4: delete a non-existing rule
+Subcase 3: delete a non-existing rule
 -------------------------------------
 
 1. show the rule list of port 0::
@@ -6085,7 +6070,7 @@ Subcase 4: delete a non-existing rule
 
    There is no error message reported.
 
-Subcase 5: unsupported pattern with OS default package
+Subcase 4: unsupported pattern with OS default package
 ------------------------------------------------------
 
 1. load os default package and launch testpmd as step 3-5 in Prerequisites.
@@ -6114,7 +6099,7 @@ Subcase 5: unsupported pattern with OS default package
 
    there is no rule listed.
 
-Subcase 6: invalid port
+Subcase 5: invalid port
 -----------------------
 
 1. create a rule with invalid port::
diff --git a/tests/TestSuite_cvl_advanced_rss_pppoe_vlan_esp_ah_l2tp_pfcp.py b/tests/TestSuite_cvl_advanced_rss_pppoe_vlan_esp_ah_l2tp_pfcp.py
index acde66b2..bf5422d9 100644
--- a/tests/TestSuite_cvl_advanced_rss_pppoe_vlan_esp_ah_l2tp_pfcp.py
+++ b/tests/TestSuite_cvl_advanced_rss_pppoe_vlan_esp_ah_l2tp_pfcp.py
@@ -5590,13 +5590,6 @@ class Advanced_rss_pppoe_vlan_ah_l2tp_pfcp(TestCase):
             self.rsspro.validate_rule(rule, check_stats=False, check_msg='Invalid argument')
             self.rsspro.create_rule(rule, check_stats=False, msg='Invalid argument')
 
-    def test_duplicated_rules(self):
-        self.switch_testpmd(symmetric=True)
-        rule = 'flow create 0 ingress pattern eth / ipv4 / udp / pfcp / end actions rss types pfcp end key_len 0 queues end / end'
-        self.rsspro.create_rule(rule)
-        self.rsspro.create_rule(rule, check_stats=False, msg='Operation not permitted')
-        self.rsspro.check_rule(rule_list=[rule])
-
     def test_void_action(self):
         self.switch_testpmd(symmetric=True)
         rule = 'flow create 0 ingress pattern eth / ipv4 / udp / pfcp / end actions end'
-- 
2.17.1


             reply	other threads:[~2021-02-05  8:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-05 16:47 sunqin [this message]
2021-02-19  7:43 ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210205164709.31384-1-qinx.sun@intel.com \
    --to=qinx.sun@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ https://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git