test suite reviews and discussions
 help / color / mirror / Atom feed
From: ohilyard@iol.unh.edu
To: dts@dpdk.org
Cc: lijuan.tu@intel.com, Owen Hilyard <ohilyard@iol.unh.edu>
Subject: [dts] [PATCH] bugfix: Fixed a timeout with mlx5_core on ARM
Date: Thu, 11 Feb 2021 16:44:14 -0500	[thread overview]
Message-ID: <20210211214415.1454192-1-ohilyard@iol.unh.edu> (raw)

From: Owen Hilyard <ohilyard@iol.unh.edu>

The time to unbind this driver has been increasing with DPDK releases, to
the point that it is now about 14 seconds. This means that, with the
default timeout of 15 seconds, there isn't much room for any kind of
disruption during testing. DTS throwing a timeout error here is not
indicative of an acutal problem, and as such I have increased the timeout
to allow continued stable functioning. The new 30 second timeout should
have minimal affect on the detection speed of any real error.

Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>
---
 framework/dut.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/framework/dut.py b/framework/dut.py
index bef0d15f..21f72e98 100644
--- a/framework/dut.py
+++ b/framework/dut.py
@@ -447,7 +447,7 @@ class Dut(Crb):
                 port = GetNicObj(self, domain_id, bus_id, devfun_id)
 
                 self.send_expect('echo %s > /sys/bus/pci/devices/%s\:%s\:%s/driver/unbind'
-                                 % (pci_bus, domain_id, bus_id, devfun_id), '# ')
+                                 % (pci_bus, domain_id, bus_id, devfun_id), '# ', timeout=30)
                 # bind to linux kernel driver
                 self.send_expect('modprobe %s' % driver, '# ')
                 self.send_expect('echo %s > /sys/bus/pci/drivers/%s/bind'
-- 
2.27.0


             reply	other threads:[~2021-02-11 21:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-11 21:44 ohilyard [this message]
2021-02-19  6:58 ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210211214415.1454192-1-ohilyard@iol.unh.edu \
    --to=ohilyard@iol.unh.edu \
    --cc=dts@dpdk.org \
    --cc=lijuan.tu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).