test suite reviews and discussions
 help / color / mirror / Atom feed
From: xiewei <weix.xie@intel.com>
To: dts@dpdk.org
Cc: xiewei <weix.xie@intel.com>
Subject: [dts] [PATCH 1/2] tests/rxtx_offload: adapt to CVL NIC
Date: Wed, 24 Mar 2021 19:24:42 +0800	[thread overview]
Message-ID: <20210324112443.29319-2-weix.xie@intel.com> (raw)
In-Reply-To: <20210324112443.29319-1-weix.xie@intel.com>

for CVL NIC,
a.rxtx_offload/rxoffload_port: disable jumboframe per-queue will change the RSS key, then pkt can be distributed to queues by RSS.
b.rxtx_offload/txoffload_queue: it failed to enable mbuf_fast_free per_queue.

Signed-off-by: xiewei <weix.xie@intel.com>
---
 tests/TestSuite_rxtx_offload.py | 23 ++++++++++++++++++-----
 1 file changed, 18 insertions(+), 5 deletions(-)

diff --git a/tests/TestSuite_rxtx_offload.py b/tests/TestSuite_rxtx_offload.py
index 0e70526f..f7481089 100644
--- a/tests/TestSuite_rxtx_offload.py
+++ b/tests/TestSuite_rxtx_offload.py
@@ -314,7 +314,10 @@ class TestRxTx_Offload(TestCase):
             scanner = re.compile(result_scanner, re.DOTALL)
             m = scanner.search(outstring)
             queue_id = m.group(1)
-            self.verify(int(expect_queue) == int(queue_id), "the offload setting doesn't take effect.")
+            if self.nic in ['columbiaville_25g', 'columbiaville_100g']:
+                self.verify(int(queue_id) in [0, 1, 2, 3], "the offload setting doesn't take effect.")
+            else:
+                self.verify(int(expect_queue) == int(queue_id), "the offload setting doesn't take effect.")
 
     def start_tcpdump(self, rxItf):
 
@@ -346,10 +349,16 @@ class TestRxTx_Offload(TestCase):
         pkt2_queue = self.get_queue_number(self.jumbo_pkt2)
 
         # Failed to disable jumboframe per_queue, foxvillee 2.5g not support
-        if self.nic != 'foxville':
+        if self.nic in ['columbiaville_25g', 'columbiaville_100g']:
             self.dut.send_expect("port stop 0", "testpmd> ")
-            self.dut.send_expect("port 0 rxq %s rx_offload jumbo_frame off" % pkt1_queue, "testpmd> ")
+            for i in range(4):
+                self.dut.send_expect("port 0 rxq %s rx_offload jumbo_frame off" % i, "testpmd> ")
             self.verify_result(self.jumbo_pkt1, 1, pkt1_queue)
+        else:
+            if self.nic != 'foxville':
+                self.dut.send_expect("port stop 0", "testpmd> ")
+                self.dut.send_expect("port 0 rxq %s rx_offload jumbo_frame off" % pkt1_queue, "testpmd> ")
+                self.verify_result(self.jumbo_pkt1, 1, pkt1_queue)
 
         # Succeed to disable jumboframe per_port
         self.dut.send_expect("port stop 0", "testpmd> ")
@@ -698,8 +707,12 @@ class TestRxTx_Offload(TestCase):
         self.dut.send_expect("port 0 txq 1 tx_offload mbuf_fast_free on", "testpmd> ")
         self.dut.send_expect("port 0 txq 2 tx_offload mbuf_fast_free on", "testpmd> ")
         self.dut.send_expect("port 0 txq 3 tx_offload mbuf_fast_free on", "testpmd> ")
-        offload = ["mbuf_fast_free", "mbuf_fast_free", "mbuf_fast_free", "mbuf_fast_free"]
-        self.check_queue_config("tx", offload)
+        if self.nic in ['columbiaville_25g', 'columbiaville_100g']:
+            out = self.dut.send_expect("port start 0", "testpmd> ")
+            self.verify("Fail to configure port 0 tx queues" in out, "mbuf_fast_free can be set by queue.")
+        else:
+            offload = ["mbuf_fast_free", "mbuf_fast_free", "mbuf_fast_free", "mbuf_fast_free"]
+            self.check_queue_config("tx", offload)
 
         # Disable mbuf_fast_free per_queue.
         self.dut.send_expect("port stop 0", "testpmd> ")
-- 
2.17.1


  parent reply	other threads:[~2021-03-24  3:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-24 11:24 [dts] [PATCH 0/2] " xiewei
2021-03-24  3:05 ` Xie, WeiX
2021-03-24 11:24 ` xiewei [this message]
2021-03-24 11:24 ` [dts] [PATCH 2/2] test_plans/rxtx_offload_test_plan: " xiewei
2021-03-25  7:20   ` Tu, Lijuan
2021-03-25  3:18 ` [dts] [PATCH 0/2] " Peng, Yuan
2021-03-25  3:19 ` Peng, Yuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210324112443.29319-2-weix.xie@intel.com \
    --to=weix.xie@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).