test suite reviews and discussions
 help / color / mirror / Atom feed
From: Xia Yan <yanx.xia@intel.com>
To: dts@dpdk.org
Cc: Xia Yan <yanx.xia@intel.com>
Subject: [dts] [PATCG V1] tests/generic_flow_api: Amend the queue list to
Date: Thu,  8 Apr 2021 18:19:30 +0800	[thread overview]
Message-ID: <20210408101930.18682-1-yanx.xia@intel.com> (raw)

origin: Collect the queue for flow rule validate & create and leave it for later validation
now: only collect flow rule create for later verification, the queue during validate does not need to be verified

Signed-off-by: Xia Yan <yanx.xia@intel.com>
---
 tests/TestSuite_generic_flow_api.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_generic_flow_api.py b/tests/TestSuite_generic_flow_api.py
index 6822f8ab..e8171589 100644
--- a/tests/TestSuite_generic_flow_api.py
+++ b/tests/TestSuite_generic_flow_api.py
@@ -241,11 +241,11 @@ class TestGeneric_flow_api(TestCase):
         for flow_action in basic_flow_actions:
             # generate the flow rule and corresponding packet.
             flow_process = self.generate_random_command(**flow_action)
-            expected_queue.append(flow_process['queue'])
             # caculate the rule number created.
             rule_created = self.flow_test_process(flow_process, flow_action)
             if rule_created:
                 rule_num += 1
+                expected_queue.append(flow_process['queue'])
                 extra_packet.append(flow_process['extrapacket'])
         # Configure a return value.
         extrapkt_rulenum = {'extrapacket': extra_packet, 'rulenum': rule_num, 'queue': expected_queue}
-- 
2.17.1


             reply	other threads:[~2021-04-08 10:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-08 10:19 Xia Yan [this message]
2021-04-08 10:33 ` Peng, Yuan
2021-04-12  5:43   ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210408101930.18682-1-yanx.xia@intel.com \
    --to=yanx.xia@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).