test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] framework/pmd_output: add timeout parameter for start_pmd method
@ 2021-04-09 11:48 sunqin
  0 siblings, 0 replies; 5+ messages in thread
From: sunqin @ 2021-04-09 11:48 UTC (permalink / raw)
  To: dts; +Cc: sunqin

some cases start testpmd with 'cmdline-file' may need more than 120 seconds,

so add 'timeout' parameter to support customization and default value still set as 120

Signed-off-by: sunqin <qinx.sun@intel.com>
---
 framework/pmd_output.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/framework/pmd_output.py b/framework/pmd_output.py
index 1ad4ce79..838fa0bd 100644
--- a/framework/pmd_output.py
+++ b/framework/pmd_output.py
@@ -148,7 +148,8 @@ class PmdOutput():
         command = command.replace('  ', ' ')
         if self.session != self.dut:
             self.session.send_expect("cd %s" % self.dut.base_dir, "# ")
-        out = self.session.send_expect(command, expected, 120)
+        timeout = config.get('timeout',120)
+        out = self.session.send_expect(command, expected, timeout)
         self.command = command
         # wait 10s to ensure links getting up before test start.
         sleep(10)
-- 
2.17.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V1] framework/pmd_output: add timeout parameter for start_pmd method
  2021-04-12  2:22   ` Zhao, HaiyangX
@ 2021-04-12  5:48     ` Tu, Lijuan
  0 siblings, 0 replies; 5+ messages in thread
From: Tu, Lijuan @ 2021-04-12  5:48 UTC (permalink / raw)
  To: Zhao, HaiyangX, Sun, QinX, dts



> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Zhao, HaiyangX
> Sent: 2021年4月12日 10:22
> To: Sun, QinX <qinx.sun@intel.com>; dts@dpdk.org
> Subject: Re: [dts] [PATCH V1] framework/pmd_output: add timeout parameter
> for start_pmd method
> 
> 
> 
> > -----Original Message-----
> > From: dts <dts-bounces@dpdk.org> On Behalf Of Sun, QinX
> > Sent: Monday, April 12, 2021 10:19
> > To: dts@dpdk.org
> > Subject: Re: [dts] [PATCH V1] framework/pmd_output: add timeout
> > parameter for start_pmd method
> >
> > > -----Original Message-----
> > > From: Sun, QinX <qinx.sun@intel.com>
> > > Sent: Friday, April 9, 2021 8:26 PM
> > > To: dts@dpdk.org
> > > Cc: Sun, QinX <qinx.sun@intel.com>
> > > Subject: [dts] [PATCH V1] framework/pmd_output: add timeout
> > parameter for start_pmd method
> >
> > Tested-by: Sun Qin <qinx.sun@intel.com>
> 
> Acked-by: Haiyang Zhao <haiyangx.zhao@intel.com>

Applied

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V1] framework/pmd_output: add timeout parameter for start_pmd method
  2021-04-12  2:19 ` Sun, QinX
@ 2021-04-12  2:22   ` Zhao, HaiyangX
  2021-04-12  5:48     ` Tu, Lijuan
  0 siblings, 1 reply; 5+ messages in thread
From: Zhao, HaiyangX @ 2021-04-12  2:22 UTC (permalink / raw)
  To: Sun, QinX, dts



> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Sun, QinX
> Sent: Monday, April 12, 2021 10:19
> To: dts@dpdk.org
> Subject: Re: [dts] [PATCH V1] framework/pmd_output: add timeout
> parameter for start_pmd method
> 
> > -----Original Message-----
> > From: Sun, QinX <qinx.sun@intel.com>
> > Sent: Friday, April 9, 2021 8:26 PM
> > To: dts@dpdk.org
> > Cc: Sun, QinX <qinx.sun@intel.com>
> > Subject: [dts] [PATCH V1] framework/pmd_output: add timeout
> parameter for start_pmd method
> 
> Tested-by: Sun Qin <qinx.sun@intel.com>

Acked-by: Haiyang Zhao <haiyangx.zhao@intel.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V1] framework/pmd_output: add timeout parameter for start_pmd method
  2021-04-09 12:25 sunqin
@ 2021-04-12  2:19 ` Sun, QinX
  2021-04-12  2:22   ` Zhao, HaiyangX
  0 siblings, 1 reply; 5+ messages in thread
From: Sun, QinX @ 2021-04-12  2:19 UTC (permalink / raw)
  To: dts

[-- Attachment #1: Type: text/plain, Size: 304 bytes --]

> -----Original Message-----
> From: Sun, QinX <qinx.sun@intel.com>
> Sent: Friday, April 9, 2021 8:26 PM
> To: dts@dpdk.org
> Cc: Sun, QinX <qinx.sun@intel.com>
> Subject: [dts] [PATCH V1] framework/pmd_output: add timeout parameter for start_pmd method

Tested-by: Sun Qin <qinx.sun@intel.com>

[-- Attachment #2: TestCvlLimitValue.log --]
[-- Type: application/octet-stream, Size: 3365765 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [dts] [PATCH V1] framework/pmd_output: add timeout parameter for start_pmd method
@ 2021-04-09 12:25 sunqin
  2021-04-12  2:19 ` Sun, QinX
  0 siblings, 1 reply; 5+ messages in thread
From: sunqin @ 2021-04-09 12:25 UTC (permalink / raw)
  To: dts; +Cc: sunqin

some cases start testpmd with 'cmdline-file' may need more than 120 seconds,

so add 'timeout' parameter to support customization and default value still set as 120

Signed-off-by: sunqin <qinx.sun@intel.com>
---
 framework/pmd_output.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/framework/pmd_output.py b/framework/pmd_output.py
index 1ad4ce79..838fa0bd 100644
--- a/framework/pmd_output.py
+++ b/framework/pmd_output.py
@@ -148,7 +148,8 @@ class PmdOutput():
         command = command.replace('  ', ' ')
         if self.session != self.dut:
             self.session.send_expect("cd %s" % self.dut.base_dir, "# ")
-        out = self.session.send_expect(command, expected, 120)
+        timeout = config.get('timeout',120)
+        out = self.session.send_expect(command, expected, timeout)
         self.command = command
         # wait 10s to ensure links getting up before test start.
         sleep(10)
-- 
2.17.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-04-12  5:48 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-09 11:48 [dts] [PATCH V1] framework/pmd_output: add timeout parameter for start_pmd method sunqin
2021-04-09 12:25 sunqin
2021-04-12  2:19 ` Sun, QinX
2021-04-12  2:22   ` Zhao, HaiyangX
2021-04-12  5:48     ` Tu, Lijuan

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ https://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git