From: dliu <dliu@iol.unh.edu> To: dts@dpdk.org Cc: Owen Hilyard <ohilyard@iol.unh.edu> Subject: [dts] [PATCH] Strip prompt by default in send_expect Date: Thu, 15 Apr 2021 10:03:02 -0400 Message-ID: <20210415140303.22620-1-dliu@iol.unh.edu> (raw) From: Owen Hilyard <ohilyard@iol.unh.edu> During investigation of timeout exceptions during performance testing, the community lab found that trailing whitespace in run commands was the cause of some of the timeouts. This patch makes the Crb version of send_expect strip whitespace from the expected string by default. It is possible to disable this behavior should it be needed, but we expect that the majority of use-cases are matching non-whitespace characters. Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu> --- framework/crb.py | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/framework/crb.py b/framework/crb.py index e7c1cc1c..3964e213 100644 --- a/framework/crb.py +++ b/framework/crb.py @@ -79,12 +79,19 @@ class Crb(object): self.alt_session = None def send_expect(self, cmds, expected, timeout=TIMEOUT, - alt_session=False, verify=False): + alt_session=False, verify=False, trim_whitespace=True): """ Send commands to crb and return string before expected string. If there's no expected string found before timeout, TimeoutException will be raised. + + By default, it will trim the whitespace from the expected string. This + behavior can be turned off via the trim_whitespace argument. """ + + if trim_whitespace: + expected = expected.strip() + # sometimes there will be no alt_session like VM dut if alt_session and self.alt_session: return self.alt_session.session.send_expect(cmds, expected, -- 2.27.0
next reply other threads:[~2021-04-15 14:03 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-15 14:03 dliu [this message] 2021-04-15 14:09 dliu 2021-04-19 14:01 ` Owen Hilyard 2021-06-09 7:22 ` Tu, Lijuan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210415140303.22620-1-dliu@iol.unh.edu \ --to=dliu@iol.unh.edu \ --cc=dts@dpdk.org \ --cc=ohilyard@iol.unh.edu \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
test suite reviews and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dts/0 dts/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dts dts/ https://inbox.dpdk.org/dts \ dts@dpdk.org public-inbox-index dts Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dts AGPL code for this site: git clone https://public-inbox.org/public-inbox.git