test suite reviews and discussions
 help / color / mirror / Atom feed
From: Zbigniew Sikora <zbigniewx.sikora@intel.com>
To: dts@dpdk.org, zbigniewx.sikora@intel.com, reshma.pattan@intel.com
Subject: [dts] [PATCH] vm_pw_mgmt_policy: fixes core mask and driver
Date: Fri, 23 Apr 2021 12:14:20 +0200	[thread overview]
Message-ID: <20210423101420.2991473-1-zbigniewx.sikora@intel.com> (raw)

1. Now vm_power_manager only grants access to the cores listed
   in its coremask, so change core number to be the one
   from vm_power_mgr core mask.
2. Replaced driver igb_uio to vfio-pci
3. Resetsynchronize system clock after the test completion.

Relevant DPDK patch:
http://patches.dpdk.org/project/dpdk/patch/20210115125250.22416-1-david.hunt@intel.com/

Signed-off-by: Zbigniew Sikora <zbigniewx.sikora@intel.com>

diff --git a/test_plans/vm_pw_mgmt_policy_test_plan.rst b/test_plans/vm_pw_mgmt_policy_test_plan.rst
index cfbfe96..98894ff 100644
--- a/test_plans/vm_pw_mgmt_policy_test_plan.rst
+++ b/test_plans/vm_pw_mgmt_policy_test_plan.rst
@@ -172,7 +172,7 @@ Set up testing environment
     export RTE_TARGET=x86_64-native-linuxapp-gcc
     make -C examples/vm_power_manager

-   ./examples/vm_power_manager/build/vm_power_mgr -c 0x7 -n 4
+   ./examples/vm_power_manager/build/vm_power_mgr -c 0xffff -n 4

     vmpower> add_vm <vm_name>
     vmpower> add_channels <vm_name> all
@@ -195,7 +195,7 @@ Set up testing environment
     make -C examples/vm_power_manager/guest_cli

    ./examples/vm_power_manager/guest_cli/build/guest_vm_power_mgr \
-   -c 0x1f -n 4 --file-prefix=vmpower2 -- -i --vm-name=<vm name> \
+   -c 0xff -n 4 --file-prefix=vmpower2 -- -i --vm-name=<vm name> \
    --policy=<policy name> --vcpu-list=<vcpus list> --busy-hours=<time stage>

     options description::
diff --git a/tests/TestSuite_vm_pw_mgmt_policy.py b/tests/TestSuite_vm_pw_mgmt_policy.py
index 9abcafd..f074f6d 100644
--- a/tests/TestSuite_vm_pw_mgmt_policy.py
+++ b/tests/TestSuite_vm_pw_mgmt_policy.py
@@ -311,7 +311,7 @@ class TestVmPwMgmtPolicy(TestCase):
                 'name': ch_name.format(cnt)}
             self.vm.add_vm_virtio_serial_channel(**channel)
         # set vm default driver
-        self.vm.def_driver = 'igb_uio'
+        self.vm.def_driver = 'vfio-pci'
         # boot up vm
         self.vm_dut = self.vm.start()
         self.is_vm_on = True
@@ -348,7 +348,7 @@ class TestVmPwMgmtPolicy(TestCase):
             '-v '
             '-c {core_mask} '
             '-n {mem_channel} ').format(**{
-                'core_mask': self.get_cores_mask("1S/3C/1T"),
+                'core_mask': self.get_cores_mask("1S/12C/1T"),
                 'mem_channel': self.dut.get_memory_channels(), })
         prompt = 'vmpower>'
         cmd = [' '.join([self.vm_power_mgr, eal_option]), prompt, 30]
@@ -566,7 +566,7 @@ class TestVmPwMgmtPolicy(TestCase):
         drv_name = output.splitlines()[0].strip()
         return drv_name

-    def get_linux_cpu_attrs(self, core_num, name="cpuinfo_cur_freq"):
+    def get_linux_cpu_attrs(self, core_num, name="scaling_setspeed"):
         freq_path = "/sys/devices/system/cpu/cpu{0}/cpufreq/{1}".format(
             core_num, name)
         output = self.d_a_con("cat %s" % freq_path)
@@ -924,6 +924,7 @@ class TestVmPwMgmtPolicy(TestCase):
         """
         Run after each test case.
         """
+        self.dut.send_expect('systemctl restart chronyd', '# ')
         self.vm_dut.kill_all()
         self.dut.kill_all()

--
1.8.3.1

--------------------------------------------------------------
Intel Research and Development Ireland Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263


This e-mail and any attachments may contain confidential material for the sole
use of the intended recipient(s). Any review or distribution by others is
strictly prohibited. If you are not the intended recipient, please contact the
sender and delete all copies.


             reply	other threads:[~2021-04-23 10:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-23 10:14 Zbigniew Sikora [this message]
2021-04-23 11:35 ` Pattan, Reshma
2021-05-06 10:51   ` Pattan, Reshma
2021-05-24  6:01 ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210423101420.2991473-1-zbigniewx.sikora@intel.com \
    --to=zbigniewx.sikora@intel.com \
    --cc=dts@dpdk.org \
    --cc=reshma.pattan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).