test suite reviews and discussions
 help / color / mirror / Atom feed
From: blo@iol.unh.edu
To: dts@dpdk.org
Cc: Brandon Lo <blo@iol.unh.edu>
Subject: [dts] [PATCH v2] Add m flag to tar command
Date: Mon,  7 Jun 2021 11:09:02 -0400	[thread overview]
Message-ID: <20210607150902.8664-1-blo@iol.unh.edu> (raw)
In-Reply-To: <20210607135618.7710-1-blo@iol.unh.edu>

From: Brandon Lo <blo@iol.unh.edu>

The m flag for tar makes it so that the untar process touches
each file. This will prevent any time presevation issues like
clock skew.

Signed-off-by: Brandon Lo <blo@iol.unh.edu>
---
 framework/project_dpdk.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/framework/project_dpdk.py b/framework/project_dpdk.py
index 2975e2ef..f7946664 100644
--- a/framework/project_dpdk.py
+++ b/framework/project_dpdk.py
@@ -462,7 +462,7 @@ class DPDKdut(Dut):
             self.send_expect("rm -rf %s" % self.base_dir, "#")
 
             # unpack dpdk
-            out = self.send_expect("tar zxf %s%s -C %s" %
+            out = self.send_expect("tar zxfm %s%s -C %s" %
                                    (dst_dir, self.package.split('/')[-1], p_dir),
                                    "# ", 30, verify=True)
             if out == -1:
@@ -704,10 +704,10 @@ class DPDKtester(Tester):
             self.session.copy_file_to("dep/tgen.tgz")
             self.session.copy_file_to("dep/tclclient.tgz")
             # unpack tgen
-            out = self.send_expect("tar zxf tgen.tgz", "# ")
+            out = self.send_expect("tar zxfm tgen.tgz", "# ")
             assert "Error" not in out
             # unpack tclclient
-            out = self.send_expect("tar zxf tclclient.tgz", "# ")
+            out = self.send_expect("tar zxfm tclclient.tgz", "# ")
             assert "Error" not in out
 
         self.send_expect("modprobe uio", "# ")
-- 
2.25.1


  reply	other threads:[~2021-06-07 15:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-07 13:56 [dts] [PATCH] " blo
2021-06-07 15:09 ` blo [this message]
2021-06-07 15:07 [dts] [PATCH v2] " blo
2021-06-09  8:09 ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210607150902.8664-1-blo@iol.unh.edu \
    --to=blo@iol.unh.edu \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).