test suite reviews and discussions
 help / color / mirror / Atom feed
From: Qin Sun <qinx.sun@intel.com>
To: dts@dpdk.org
Cc: Qin Sun <qinx.sun@intel.com>
Subject: [dts] [PATCH V2] tests/cvl_dcf_flow_priority: modify PPP proto field to byte type
Date: Fri, 16 Jul 2021 12:01:53 +0000	[thread overview]
Message-ID: <20210716120153.7743-1-qinx.sun@intel.com> (raw)

modify PPP proto field to byte type to adapt scapy2.4.4, replace 'insmod xxx'
with 'modprobe ice' to reduce configure file

Signed-off-by: Qin Sun <qinx.sun@intel.com>
---
 v2: add comment for set_up, add unsupport-pkg decorate for exclusive_case case

 tests/TestSuite_cvl_dcf_flow_priority.py | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/tests/TestSuite_cvl_dcf_flow_priority.py b/tests/TestSuite_cvl_dcf_flow_priority.py
index 532d9934..07d99d2c 100644
--- a/tests/TestSuite_cvl_dcf_flow_priority.py
+++ b/tests/TestSuite_cvl_dcf_flow_priority.py
@@ -1155,11 +1155,9 @@ class CVLDCFFlowPriorityTest(TestCase):
         """
         Run before each test case.
         """
-        self.suite_config = rfc.get_suite_config(self)
-        ice_driver_file_location = self.suite_config["ice_driver_file_location"]
+        #Switch's recpri resource cannot be released,so need to reload ice driver to release it, this is a known issue of ND
         self.dut.send_expect("rmmod ice","#",30)
-        self.dut.send_expect("insmod %s" % ice_driver_file_location, "# ", 60)
-        time.sleep(10)
+        self.dut.send_expect("modprobe ice","#",30)
   
     def create_testpmd_command(self):
         """
@@ -1672,6 +1670,7 @@ class CVLDCFFlowPriorityTest(TestCase):
                        "flow create 0 priority 0 ingress pattern eth / ipv4 src is 192.168.0.1 dst is 192.168.0.2 / end actions vf id 4 / end"]
         self.create_switch_filter_rule(negative_rule, check_stats=False)
 
+    @skip_unsupported_pkg(['os default', 'wireless'])
     def test_exclusive_case(self):
         self.setup_1pf_vfs_env()
 
@@ -1733,7 +1732,7 @@ class CVLDCFFlowPriorityTest(TestCase):
         self.dut.send_expect("flow destroy 0 rule 1", "testpmd> ", 15)
         matched_dic["expect_results"]["expect_pkts"]=0
         self.send_and_check_packets(matched_dic)
-        matched_dic = {"scapy_str":['Ether(dst="00:11:22:33:44:55",type=0x8100)/Dot1Q(vlan=1,type=0x8100)/Dot1Q(vlan=0x2,type=0x8864)/PPPoE(sessionid=0x1)/PPP(proto=0x21)/IP()/UDP(dport=23)/("X"*480)'],
+        matched_dic = {"scapy_str":['Ether(dst="00:11:22:33:44:55",type=0x8100)/Dot1Q(vlan=1,type=0x8100)/Dot1Q(vlan=0x2,type=0x8864)/PPPoE(sessionid=1)/PPP(b\'\\x00\\x21\')/IP()/UDP(dport=23)/("X"*480)'],
                        "check_func":{"func":rfc.check_vf_rx_packets_number,
                                      "param":{"expect_port":2, "expect_queue":"null"}},
                        "expect_results":{"expect_pkts":1}}
-- 
2.17.1


             reply	other threads:[~2021-07-16  3:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-16 12:01 Qin Sun [this message]
2021-07-21  6:53 ` Sun, QinX
2021-07-26  5:26   ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210716120153.7743-1-qinx.sun@intel.com \
    --to=qinx.sun@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).