test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH] ci/pylama: Added pylama config file
@ 2021-08-12 16:22 ohilyard
  2021-08-12 16:29 ` Owen Hilyard
  0 siblings, 1 reply; 2+ messages in thread
From: ohilyard @ 2021-08-12 16:22 UTC (permalink / raw)
  To: dts; +Cc: lijuan.tu, juraj.linkes, Owen Hilyard

From: Owen Hilyard <ohilyard@iol.unh.edu>

I ended up turning off most of the formatting-releated checks due to
some minor conflicts with black (black allows lines > 80 characters for
instance). This produces a very substantial list of errors, some of
which may need to be simply disabled instead of being fixed due to
architectural reasons.

Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>
---
 ci/requirements.txt | 5 ++++-
 pylama.ini          | 5 +++++
 2 files changed, 9 insertions(+), 1 deletion(-)
 create mode 100644 pylama.ini

diff --git a/ci/requirements.txt b/ci/requirements.txt
index 0abd6716..e19e540e 100644
--- a/ci/requirements.txt
+++ b/ci/requirements.txt
@@ -29,4 +29,7 @@
 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-argparse==1.4.0
\ No newline at end of file
+argparse==1.4.0
+pylama
+pylama_pylint
+black
\ No newline at end of file
diff --git a/pylama.ini b/pylama.ini
new file mode 100644
index 00000000..aef408c0
--- /dev/null
+++ b/pylama.ini
@@ -0,0 +1,5 @@
+[pylama]
+format = pylint
+linters = pep8,pycodestyle,pylint
+ignore = F0401,C0111,E731,E266,E501,E203
+
-- 
2.30.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH] ci/pylama: Added pylama config file
  2021-08-12 16:22 [dts] [PATCH] ci/pylama: Added pylama config file ohilyard
@ 2021-08-12 16:29 ` Owen Hilyard
  0 siblings, 0 replies; 2+ messages in thread
From: Owen Hilyard @ 2021-08-12 16:29 UTC (permalink / raw)
  To: dts

[-- Attachment #1: Type: text/plain, Size: 1838 bytes --]

This depends on the requirements file that I added when adding the other ci
script. I want to make it as easy as possible to install everything needed
for CI, which means all of it should go in one requirements file. Even with
my removing many issues, this still has a lot of issues with the DTS
codebase, 35126 issues to be exact. We may want to bring this back to the
working group and discuss more, after fixing just the errors, since there
is a manageable amount of those.

On Thu, Aug 12, 2021 at 12:23 PM <ohilyard@iol.unh.edu> wrote:

> From: Owen Hilyard <ohilyard@iol.unh.edu>
>
> I ended up turning off most of the formatting-releated checks due to
> some minor conflicts with black (black allows lines > 80 characters for
> instance). This produces a very substantial list of errors, some of
> which may need to be simply disabled instead of being fixed due to
> architectural reasons.
>
> Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>
> ---
>  ci/requirements.txt | 5 ++++-
>  pylama.ini          | 5 +++++
>  2 files changed, 9 insertions(+), 1 deletion(-)
>  create mode 100644 pylama.ini
>
> diff --git a/ci/requirements.txt b/ci/requirements.txt
> index 0abd6716..e19e540e 100644
> --- a/ci/requirements.txt
> +++ b/ci/requirements.txt
> @@ -29,4 +29,7 @@
>  # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
>  # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>
> -argparse==1.4.0
> \ No newline at end of file
> +argparse==1.4.0
> +pylama
> +pylama_pylint
> +black
> \ No newline at end of file
> diff --git a/pylama.ini b/pylama.ini
> new file mode 100644
> index 00000000..aef408c0
> --- /dev/null
> +++ b/pylama.ini
> @@ -0,0 +1,5 @@
> +[pylama]
> +format = pylint
> +linters = pep8,pycodestyle,pylint
> +ignore = F0401,C0111,E731,E266,E501,E203
> +
> --
> 2.30.2
>
>

[-- Attachment #2: Type: text/html, Size: 2398 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-08-12 16:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-12 16:22 [dts] [PATCH] ci/pylama: Added pylama config file ohilyard
2021-08-12 16:29 ` Owen Hilyard

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ https://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git