test suite reviews and discussions
 help / color / mirror / Atom feed
From: Zhimin Huang <zhiminx.huang@intel.com>
To: dts@dpdk.org
Cc: Zhimin Huang <zhiminx.huang@intel.com>
Subject: [dts] [PATCH V1] tests/cvl_fdir:fix testplan and testcase not synchronization issue
Date: Sat,  9 Oct 2021 22:42:05 +0800	[thread overview]
Message-ID: <20211009144205.25338-1-zhiminx.huang@intel.com> (raw)

fixed testplan confusing description and sync testcase code with plan.
the last pkt need received by port 1 and not affect by rule in port 0.

Signed-off-by: Zhimin Huang <zhiminx.huang@intel.com>
---
 test_plans/cvl_fdir_test_plan.rst | 4 ++--
 tests/TestSuite_cvl_fdir.py       | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/test_plans/cvl_fdir_test_plan.rst b/test_plans/cvl_fdir_test_plan.rst
index 24586016..1d8421e1 100644
--- a/test_plans/cvl_fdir_test_plan.rst
+++ b/test_plans/cvl_fdir_test_plan.rst
@@ -4011,8 +4011,8 @@ Subcase 3: two ports multi patterns count query
    packet 1 to queue 1 of port 1, packet 2 to queue 6-7 of port 1, packet 3 to queue 6-7 of port 1,
    packet 4 to queue 2 of port 1, packet 5 dropped of port 1,
    packet 6 to dropped of port 0, packet 7 to queue 1 of port 0.
-   packet 8 received by port 1.
-   all the received packets have specified FDIR matched ID.
+   the received packets have specified FDIR matched ID.
+   packet 8 received by port 1 and not have matched ID.
 
 3. query count::
 
diff --git a/tests/TestSuite_cvl_fdir.py b/tests/TestSuite_cvl_fdir.py
index 18836756..90acafd7 100644
--- a/tests/TestSuite_cvl_fdir.py
+++ b/tests/TestSuite_cvl_fdir.py
@@ -3273,7 +3273,7 @@ class TestCVLFdir(TestCase):
         out7 = self.send_pkts_getouput(pkts[6], port_id=0, count=10)
         rfc.check_mark(out7, pkt_num=10, check_param={"port_id": 0, "queue": 1, "mark_id": 1})
         out8 = self.send_pkts_getouput(pkts[7], port_id=1, count=10)
-        rfc.check_mark(out8, pkt_num=10, check_param={"port_id": 1, "mark_id": 0})
+        rfc.check_mark(out8, pkt_num=10, check_param={"port_id": 1})
         self.query_count(1, 20, 1, 0)
         self.query_count(1, 20, 1, 1)
         self.query_count(1, 10, 1, 2)
-- 
2.17.1


             reply	other threads:[~2021-10-09  6:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-09 14:42 Zhimin Huang [this message]
2021-10-09  6:21 ` Huang, ZhiminX
2021-10-25  9:12   ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211009144205.25338-1-zhiminx.huang@intel.com \
    --to=zhiminx.huang@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).