test suite reviews and discussions
 help / color / mirror / Atom feed
* Re: [dts] [PATCH V2 2/2] tests/kernelpf_iavf: modify dts because case design is unreasonable
  2021-10-22 15:59 ` [dts] [PATCH V2 2/2] tests/kernelpf_iavf: " Yan Xia
@ 2021-10-22  8:37   ` Chen, LingliX
  2021-10-25  1:59   ` Lin, Xueqin
  1 sibling, 0 replies; 6+ messages in thread
From: Chen, LingliX @ 2021-10-22  8:37 UTC (permalink / raw)
  To: dts

[-- Attachment #1: Type: text/plain, Size: 549 bytes --]


> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Yan Xia
> Sent: Saturday, October 23, 2021 12:00 AM
> To: dts@dpdk.org
> Cc: Xia, YanX <yanx.xia@intel.com>
> Subject: [dts] [PATCH V2 2/2] tests/kernelpf_iavf: modify dts because case
> design is unreasonable
> 
> validate strip function need to enable vlan filter and received the packets, in
> addition, strip function has nothing to do with driver version.
> 
> Signed-off-by: Yan Xia <yanx.xia@intel.com>
> ---
Tested-by: Yan Xia <yanx.xia@intel.com>

[-- Attachment #2: TestKernelpfIavf.log --]
[-- Type: application/octet-stream, Size: 21007 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [dts] [PATCH V2 0/2] *** modify dts because case design is unreasonable ***
@ 2021-10-22 15:59 Yan Xia
  2021-10-22 15:59 ` [dts] [PATCH V2 1/2] test_plans/kernelpf_iavf : modify dts because case design is unreasonable Yan Xia
  2021-10-22 15:59 ` [dts] [PATCH V2 2/2] tests/kernelpf_iavf: " Yan Xia
  0 siblings, 2 replies; 6+ messages in thread
From: Yan Xia @ 2021-10-22 15:59 UTC (permalink / raw)
  To: dts; +Cc: Yan Xia

*** validate strip function need to enable vlan filter and received the
packets, in addition, strip function has nothing to do with driver
version. ***

Yan Xia (2):
  test_plans/kernelpf_iavf : modify dts because case design is
    unreasonable
  tests/kernelpf_iavf: modify dts because case design is unreasonable

 test_plans/kernelpf_iavf_test_plan.rst |  3 +++
 tests/TestSuite_kernelpf_iavf.py       | 20 +++++++++++---------
 2 files changed, 14 insertions(+), 9 deletions(-)

-- 
2.33.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [dts] [PATCH V2 1/2] test_plans/kernelpf_iavf : modify dts because case design is unreasonable
  2021-10-22 15:59 [dts] [PATCH V2 0/2] *** modify dts because case design is unreasonable *** Yan Xia
@ 2021-10-22 15:59 ` Yan Xia
  2021-10-22 15:59 ` [dts] [PATCH V2 2/2] tests/kernelpf_iavf: " Yan Xia
  1 sibling, 0 replies; 6+ messages in thread
From: Yan Xia @ 2021-10-22 15:59 UTC (permalink / raw)
  To: dts; +Cc: Yan Xia

validate strip function need to enable vlan filter and received the
packets, in addition, strip function has nothing to do with driver
version.

Signed-off-by: Yan Xia <yanx.xia@intel.com>
---
 test_plans/kernelpf_iavf_test_plan.rst | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/test_plans/kernelpf_iavf_test_plan.rst b/test_plans/kernelpf_iavf_test_plan.rst
index 4351f791..72223c77 100644
--- a/test_plans/kernelpf_iavf_test_plan.rst
+++ b/test_plans/kernelpf_iavf_test_plan.rst
@@ -312,8 +312,11 @@ Test case: VF vlan strip
 
 Enable VF vlan strip::
 
+    testpmd> vlan set filter on 0
+    testpmd> rx_vlan add 20 0
     testpmd> vlan set strip on 0
     testpmd> set fwd mac
+    testpmd> set verbose 1
     testpmd> start
 
 Send packets with vlan tag::
-- 
2.33.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [dts] [PATCH V2 2/2] tests/kernelpf_iavf: modify dts because case design is unreasonable
  2021-10-22 15:59 [dts] [PATCH V2 0/2] *** modify dts because case design is unreasonable *** Yan Xia
  2021-10-22 15:59 ` [dts] [PATCH V2 1/2] test_plans/kernelpf_iavf : modify dts because case design is unreasonable Yan Xia
@ 2021-10-22 15:59 ` Yan Xia
  2021-10-22  8:37   ` Chen, LingliX
  2021-10-25  1:59   ` Lin, Xueqin
  1 sibling, 2 replies; 6+ messages in thread
From: Yan Xia @ 2021-10-22 15:59 UTC (permalink / raw)
  To: dts; +Cc: Yan Xia

validate strip function need to enable vlan filter and received the
packets, in addition, strip function has nothing to do with driver
version.

Signed-off-by: Yan Xia <yanx.xia@intel.com>
---
 tests/TestSuite_kernelpf_iavf.py | 20 +++++++++++---------
 1 file changed, 11 insertions(+), 9 deletions(-)

diff --git a/tests/TestSuite_kernelpf_iavf.py b/tests/TestSuite_kernelpf_iavf.py
index 6a858fc5..ff1f83a6 100644
--- a/tests/TestSuite_kernelpf_iavf.py
+++ b/tests/TestSuite_kernelpf_iavf.py
@@ -529,29 +529,31 @@ class TestKernelpfIavf(TestCase):
         random_vlan = random.randint(1, MAX_VLAN)
         self.vm_testpmd.start_testpmd("all")
         self.vm_testpmd.execute_cmd("port stop all")
-        self.vm_testpmd.execute_cmd("vlan set filter off 0")
+        self.vm_testpmd.execute_cmd("vlan set filter on 0")
+        self.vm_testpmd.execute_cmd("rx_vlan add %s 0" % random_vlan)
         self.vm_testpmd.execute_cmd("vlan set strip off 0")
-        self.vm_testpmd.execute_cmd("vlan set strip on 0")
         self.vm_testpmd.execute_cmd("port start all")
         self.vm_testpmd.execute_cmd("set fwd mac")
         self.vm_testpmd.execute_cmd("set verbose 1")
         self.vm_testpmd.execute_cmd("start")
+
+        #enable strip
+        self.vm_testpmd.execute_cmd("vlan set strip on 0")
         self.start_tcpdump(self.tester_intf)
         self.send_and_getout(vlan=random_vlan, pkt_type="VLAN_UDP")
         tcpdump_out = self.get_tcpdump_package()
-        receive_pkt = re.findall('vlan %s' % random_vlan, tcpdump_out)
-        self.verify(len(receive_pkt) == 1, 'Failed to received vlan packet!!!')
+        self.verify('> %s' % self.vf_mac in tcpdump_out and '%s >' % self.vf_mac in tcpdump_out, 'Failed to received packet!!!')
+        receive_vlan_pkt = re.findall('vlan %s' % random_vlan, tcpdump_out)
+        self.verify(len(receive_vlan_pkt) == 1, 'Failed to received vlan packet!!!')
 
         # disable strip
         self.vm_testpmd.execute_cmd("vlan set strip off 0")
         self.start_tcpdump(self.tester_intf)
         self.send_and_getout(vlan=random_vlan, pkt_type="VLAN_UDP")
         tcpdump_out = self.get_tcpdump_package()
-        receive_pkt = re.findall('vlan %s' % random_vlan, tcpdump_out)
-        if self.driver_version < "2.13.10" or self.kdriver == 'ice':
-            self.verify(len(receive_pkt) == 2, 'Failed to not received vlan packet!!!')
-        else:
-            self.verify(len(receive_pkt) == 1, 'Failed to not received vlan packet!!!')
+        self.verify('> %s' % self.vf_mac in tcpdump_out and '%s >' % self.vf_mac in tcpdump_out, 'Failed to received packet!!!')
+        receive_vlan_pkt = re.findall('vlan %s' % random_vlan, tcpdump_out)
+        self.verify(len(receive_vlan_pkt) == 2, 'Failed to not received vlan packet!!!')
 
     def test_vf_vlan_filter(self):
         random_vlan = random.randint(2, MAX_VLAN)
-- 
2.33.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dts] [PATCH V2 2/2] tests/kernelpf_iavf: modify dts because case design is unreasonable
  2021-10-22 15:59 ` [dts] [PATCH V2 2/2] tests/kernelpf_iavf: " Yan Xia
  2021-10-22  8:37   ` Chen, LingliX
@ 2021-10-25  1:59   ` Lin, Xueqin
  2021-10-25  8:45     ` Tu, Lijuan
  1 sibling, 1 reply; 6+ messages in thread
From: Lin, Xueqin @ 2021-10-25  1:59 UTC (permalink / raw)
  To: Xia, YanX, dts; +Cc: Xia, YanX

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Yan Xia
> Sent: Saturday, October 23, 2021 12:00 AM
> To: dts@dpdk.org
> Cc: Xia, YanX <yanx.xia@intel.com>
> Subject: [dts] [PATCH V2 2/2] tests/kernelpf_iavf: modify dts because case
> design is unreasonable
> 
> validate strip function need to enable vlan filter and received the packets, in
> addition, strip function has nothing to do with driver version.
> 
> Signed-off-by: Yan Xia <yanx.xia@intel.com>
Acked-by: Xueqin Lin <xueqin.lin@intel.com>
> ---
>  tests/TestSuite_kernelpf_iavf.py | 20 +++++++++++---------
>  1 file changed, 11 insertions(+), 9 deletions(-)
> 
> diff --git a/tests/TestSuite_kernelpf_iavf.py b/tests/TestSuite_kernelpf_iavf.py
> index 6a858fc5..ff1f83a6 100644
> --- a/tests/TestSuite_kernelpf_iavf.py
> +++ b/tests/TestSuite_kernelpf_iavf.py
> @@ -529,29 +529,31 @@ class TestKernelpfIavf(TestCase):
>          random_vlan = random.randint(1, MAX_VLAN)
>          self.vm_testpmd.start_testpmd("all")
>          self.vm_testpmd.execute_cmd("port stop all")
> -        self.vm_testpmd.execute_cmd("vlan set filter off 0")
> +        self.vm_testpmd.execute_cmd("vlan set filter on 0")
> +        self.vm_testpmd.execute_cmd("rx_vlan add %s 0" % random_vlan)
>          self.vm_testpmd.execute_cmd("vlan set strip off 0")
> -        self.vm_testpmd.execute_cmd("vlan set strip on 0")
>          self.vm_testpmd.execute_cmd("port start all")
>          self.vm_testpmd.execute_cmd("set fwd mac")
>          self.vm_testpmd.execute_cmd("set verbose 1")
>          self.vm_testpmd.execute_cmd("start")
> +
> +        #enable strip
> +        self.vm_testpmd.execute_cmd("vlan set strip on 0")
>          self.start_tcpdump(self.tester_intf)
>          self.send_and_getout(vlan=random_vlan, pkt_type="VLAN_UDP")
>          tcpdump_out = self.get_tcpdump_package()
> -        receive_pkt = re.findall('vlan %s' % random_vlan, tcpdump_out)
> -        self.verify(len(receive_pkt) == 1, 'Failed to received vlan packet!!!')
> +        self.verify('> %s' % self.vf_mac in tcpdump_out and '%s >' % self.vf_mac
> in tcpdump_out, 'Failed to received packet!!!')
> +        receive_vlan_pkt = re.findall('vlan %s' % random_vlan, tcpdump_out)
> +        self.verify(len(receive_vlan_pkt) == 1, 'Failed to received
> + vlan packet!!!')
> 
>          # disable strip
>          self.vm_testpmd.execute_cmd("vlan set strip off 0")
>          self.start_tcpdump(self.tester_intf)
>          self.send_and_getout(vlan=random_vlan, pkt_type="VLAN_UDP")
>          tcpdump_out = self.get_tcpdump_package()
> -        receive_pkt = re.findall('vlan %s' % random_vlan, tcpdump_out)
> -        if self.driver_version < "2.13.10" or self.kdriver == 'ice':
> -            self.verify(len(receive_pkt) == 2, 'Failed to not received vlan packet!!!')
> -        else:
> -            self.verify(len(receive_pkt) == 1, 'Failed to not received vlan packet!!!')
> +        self.verify('> %s' % self.vf_mac in tcpdump_out and '%s >' % self.vf_mac
> in tcpdump_out, 'Failed to received packet!!!')
> +        receive_vlan_pkt = re.findall('vlan %s' % random_vlan, tcpdump_out)
> +        self.verify(len(receive_vlan_pkt) == 2, 'Failed to not received
> + vlan packet!!!')
> 
>      def test_vf_vlan_filter(self):
>          random_vlan = random.randint(2, MAX_VLAN)
> --
> 2.33.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dts] [PATCH V2 2/2] tests/kernelpf_iavf: modify dts because case design is unreasonable
  2021-10-25  1:59   ` Lin, Xueqin
@ 2021-10-25  8:45     ` Tu, Lijuan
  0 siblings, 0 replies; 6+ messages in thread
From: Tu, Lijuan @ 2021-10-25  8:45 UTC (permalink / raw)
  To: Lin, Xueqin, Xia, YanX, dts; +Cc: Xia, YanX


> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Lin, Xueqin
> Sent: 2021年10月25日 10:00
> To: Xia, YanX <yanx.xia@intel.com>; dts@dpdk.org
> Cc: Xia, YanX <yanx.xia@intel.com>
> Subject: Re: [dts] [PATCH V2 2/2] tests/kernelpf_iavf: modify dts because case
> design is unreasonable
> 
> > -----Original Message-----
> > From: dts <dts-bounces@dpdk.org> On Behalf Of Yan Xia
> > Sent: Saturday, October 23, 2021 12:00 AM
> > To: dts@dpdk.org
> > Cc: Xia, YanX <yanx.xia@intel.com>
> > Subject: [dts] [PATCH V2 2/2] tests/kernelpf_iavf: modify dts because
> > case design is unreasonable
> >
> > validate strip function need to enable vlan filter and received the
> > packets, in addition, strip function has nothing to do with driver version.
> >
> > Signed-off-by: Yan Xia <yanx.xia@intel.com>
> Acked-by: Xueqin Lin <xueqin.lin@intel.com>

Applied

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-10-25  8:45 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-22 15:59 [dts] [PATCH V2 0/2] *** modify dts because case design is unreasonable *** Yan Xia
2021-10-22 15:59 ` [dts] [PATCH V2 1/2] test_plans/kernelpf_iavf : modify dts because case design is unreasonable Yan Xia
2021-10-22 15:59 ` [dts] [PATCH V2 2/2] tests/kernelpf_iavf: " Yan Xia
2021-10-22  8:37   ` Chen, LingliX
2021-10-25  1:59   ` Lin, Xueqin
2021-10-25  8:45     ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).