From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7745BA0C41; Wed, 17 Nov 2021 17:23:42 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 467C940687; Wed, 17 Nov 2021 17:23:42 +0100 (CET) Received: from mail-vk1-f226.google.com (mail-vk1-f226.google.com [209.85.221.226]) by mails.dpdk.org (Postfix) with ESMTP id 42C6D40040 for ; Wed, 17 Nov 2021 17:23:41 +0100 (CET) Received: by mail-vk1-f226.google.com with SMTP id b192so1995161vkf.3 for ; Wed, 17 Nov 2021 08:23:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=FrBYaoELqU07SCmfAN86cOZFBUa46XMKq/BcFeHl5Cc=; b=FG8Nmfv0CDWRQ3f2X0G89bdOL8GZuEowevGL+EINl+niYxQ53Qxu1aXe702o7IYQ6t wzPCVfAxim5heRTJHs1TaxQgwKT2rbUXwRoMObhPW8JxCSI7WJhFNEgXGtDP1l5YURdF a4uFZDlxGA21VZ8F9LKJj8RYr7mjzUFFk1Vck= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=FrBYaoELqU07SCmfAN86cOZFBUa46XMKq/BcFeHl5Cc=; b=GOIx3Q8Qekhkvhz+GUCKXmhEFGTSj+OgcBk3GgvsR1D2wafzhTf0NqjCALm+9iXCRT PJO3aGhSAufOo3hdBbUqJLgQBu8XV4CZYvq+CdqLQjzcA8g1t3QTH6TfOz7vPaupC3+B tBULLuNR17xHpGsNE1l3L0XAX1yCYC0EzimSw6cuZgmuKSj7/ye6jYxyn65UaPSHiPlr CCxVZfT6MSvsKbcrGEDiEuT45h37hYQumPQO+DoDsoXP1YPZZMDgjiMpHefNPXaENoQ+ 0tsu8TLl7veWup9rCnwUa8+cw2ES58rCD/QZxpoVOL1hWecGHKxLtTE2yLZUxjs1sB0C Dvtg== X-Gm-Message-State: AOAM532cu36eD2XaMqCyigo2VcqOCtP4e3rVi/13VEO82i+uamPQQJrN obv7gzSXHOsD5rGptfAaGDKzqc+vZQzctjf+D0QmRWYQP1RMNcI+z8OvTe7alWn911AIyViwbQH fH9uP9jzKF4rnOXXP7CWWWc1++CxhUzSQd72v+Cf/j7KpZ2VVZ+1SOsKUchY2oSzQKqqrXn6oRg == X-Google-Smtp-Source: ABdhPJwU4DREISqJPOeN5K6wctTc/lmFLz9H64hw9DC17yFAFdQcmSKhADaBysghT1b9WBnTKGOimElLtau3 X-Received: by 2002:a05:6122:2090:: with SMTP id i16mr91446940vkd.18.1637166220630; Wed, 17 Nov 2021 08:23:40 -0800 (PST) Received: from postal.iol.unh.edu (postal.iol.unh.edu. [132.177.123.84]) by smtp-relay.gmail.com with ESMTPS id az39sm164666uab.1.2021.11.17.08.23.40 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 Nov 2021 08:23:40 -0800 (PST) X-Relaying-Domain: iol.unh.edu Received: from iol.unh.edu (unknown [IPv6:2606:4100:3880:1257::105d]) by postal.iol.unh.edu (Postfix) with ESMTP id 2D55C605247D; Wed, 17 Nov 2021 11:23:40 -0500 (EST) From: ohilyard@iol.unh.edu To: dts@dpdk.org Cc: lijuan.tu@intel.com, Owen Hilyard Subject: [PATCH] framework: Advise against using root passwords Date: Wed, 17 Nov 2021 11:23:30 -0500 Message-Id: <20211117162330.25896-1-ohilyard@iol.unh.edu> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org From: Owen Hilyard Added messages to notify the user that a blank password field will use ssh keys, and that using root passwords is insecure. --- conf/crbs.cfg | 4 ++-- tools/setup.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/conf/crbs.cfg b/conf/crbs.cfg index b6c0a9af..a12e60a4 100644 --- a/conf/crbs.cfg +++ b/conf/crbs.cfg @@ -2,10 +2,10 @@ #[DUT IP] # dut_ip: DUT ip address # dut_user: Login DUT username -# dut_passwd: Login DUT password +# dut_passwd: [INSECURE] Login DUT password, leaving this blank will force using SSH keys # os: operation system type linux or freebsd # tester_ip: Tester ip address -# tester_passwd: Tester password +# tester_passwd: [INSECURE] Tester password, leaving this blank will force using SSH keys # pktgen_group: packet generator group name: ixia/trex/ixia_network # channels: Board channel number # bypass_core0: Whether by pass core0 diff --git a/tools/setup.py b/tools/setup.py index 3873a884..c70730c7 100755 --- a/tools/setup.py +++ b/tools/setup.py @@ -105,7 +105,7 @@ def config_crbs(): passwd_option = {'prompt': 'DUT root password', 'type': 'string', - 'help': 'Please input password of DUT crb', + 'help': '[INSECURE] Please input password of DUT crb (leave blank to use preconfigured SSH keys)', 'default': ''} opt = Option(**passwd_option) dut_pass = opt.parse_input() @@ -120,7 +120,7 @@ def config_crbs(): passwd_option = {'prompt': 'Tester root password', 'type': 'string', - 'help': 'Please input password of Tester crb', + 'help': '[INSECURE] Please input password of Tester crb (leave blank to use preconfigured SSH keys)', 'default': ''} opt = Option(**passwd_option) tester_pass = opt.parse_input() -- 2.30.2