From: ohilyard@iol.unh.edu
To: dts@dpdk.org
Cc: lijuan.tu@intel.com, Owen Hilyard <ohilyard@iol.unh.edu>
Subject: [PATCH v2] framework: Advise against using root passwords
Date: Wed, 17 Nov 2021 12:01:07 -0500 [thread overview]
Message-ID: <20211117170107.30162-1-ohilyard@iol.unh.edu> (raw)
In-Reply-To: <20211117162330.25896-1-ohilyard@iol.unh.edu>
From: Owen Hilyard <ohilyard@iol.unh.edu>
Added messages to notify the user that a blank password field will use
ssh keys, and that using root passwords is insecure.
Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>
---
conf/crbs.cfg | 4 ++--
tools/setup.py | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/conf/crbs.cfg b/conf/crbs.cfg
index b6c0a9af..a12e60a4 100644
--- a/conf/crbs.cfg
+++ b/conf/crbs.cfg
@@ -2,10 +2,10 @@
#[DUT IP]
# dut_ip: DUT ip address
# dut_user: Login DUT username
-# dut_passwd: Login DUT password
+# dut_passwd: [INSECURE] Login DUT password, leaving this blank will force using SSH keys
# os: operation system type linux or freebsd
# tester_ip: Tester ip address
-# tester_passwd: Tester password
+# tester_passwd: [INSECURE] Tester password, leaving this blank will force using SSH keys
# pktgen_group: packet generator group name: ixia/trex/ixia_network
# channels: Board channel number
# bypass_core0: Whether by pass core0
diff --git a/tools/setup.py b/tools/setup.py
index 3873a884..c70730c7 100755
--- a/tools/setup.py
+++ b/tools/setup.py
@@ -105,7 +105,7 @@ def config_crbs():
passwd_option = {'prompt': 'DUT root password',
'type': 'string',
- 'help': 'Please input password of DUT crb',
+ 'help': '[INSECURE] Please input password of DUT crb (leave blank to use preconfigured SSH keys)',
'default': ''}
opt = Option(**passwd_option)
dut_pass = opt.parse_input()
@@ -120,7 +120,7 @@ def config_crbs():
passwd_option = {'prompt': 'Tester root password',
'type': 'string',
- 'help': 'Please input password of Tester crb',
+ 'help': '[INSECURE] Please input password of Tester crb (leave blank to use preconfigured SSH keys)',
'default': ''}
opt = Option(**passwd_option)
tester_pass = opt.parse_input()
--
2.30.2
next prev parent reply other threads:[~2021-11-17 17:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 16:23 [PATCH] " ohilyard
2021-11-17 17:01 ` ohilyard [this message]
2021-11-18 10:16 ` [PATCH v2] " Juraj Linkeš
2021-11-23 14:28 ` Tu, Lijuan
2021-11-17 16:26 ohilyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211117170107.30162-1-ohilyard@iol.unh.edu \
--to=ohilyard@iol.unh.edu \
--cc=dts@dpdk.org \
--cc=lijuan.tu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).