test suite reviews and discussions
 help / color / mirror / Atom feed
From: ohilyard@iol.unh.edu
To: dts@dpdk.org
Cc: lijuan.tu@intel.com, Owen Hilyard <ohilyard@iol.unh.edu>
Subject: [PATCH v1] framework: Add makefile deprecation warning
Date: Wed, 26 Jan 2022 14:52:00 -0500	[thread overview]
Message-ID: <20220126195200.40058-1-ohilyard@iol.unh.edu> (raw)

From: Owen Hilyard <ohilyard@iol.unh.edu>

Adds the following deprecation warning to DTS when running a makefile

Makefile builds have been deprecated and will be removed in the next release.
Please switch to using meson builds.

Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>
 framework/dts.py | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/framework/dts.py b/framework/dts.py
index 892aa1fc..1baddb84 100644
--- a/framework/dts.py
+++ b/framework/dts.py
@@ -35,6 +35,7 @@ import copy  # copy module for duplicate variable
 import imp
 import inspect  # load attribute
 import json  # json format
+import logging
 import os  # operation system module
 import re  # regular expressions module
 import signal  # signal module for debug mode
@@ -77,7 +78,7 @@ stats_report = None
 log_handler = None
-def dts_parse_param(config, section):
+def dts_parse_param(config, section, log_handler):
     Parse execution file parameters.
@@ -94,11 +95,16 @@ def dts_parse_param(config, section):
     parameters = config.get(section, 'parameters').split(':')
     drivername = config.get(section, 'drivername').split('=')[-1]
-    # get the build method, default is makefile
+    # get the build method, default is meson
         buildtype = config.get(section, 'build_type').split('=')[-1]
         buildtype = 'meson'
+    if buildtype == 'makefile':
+        log_handler.warning("Makefile builds have been deprecated and will be removed in the next release.")
+        log_handler.warning("Please switch to using meson builds.")
     buildtype = buildtype.lower()
     settings.save_global_setting(settings.HOST_BUILD_TYPE_SETTING, buildtype)
@@ -588,7 +594,7 @@ def run_all(config_file, pkgName, git, patch, skip_setup,
     # for all Execution sections
     for section in config.sections():
         crbInsts = list()
-        dts_parse_param(config, section)
+        dts_parse_param(config, section, log_handler)
         # verify if the delimiter is good if the lists are vertical
         duts, targets, test_suites = dts_parse_config(config, section)

             reply	other threads:[~2022-01-26 19:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-26 19:52 ohilyard [this message]
2022-02-09  1:53 ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220126195200.40058-1-ohilyard@iol.unh.edu \
    --to=ohilyard@iol.unh.edu \
    --cc=dts@dpdk.org \
    --cc=lijuan.tu@intel.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).