test suite reviews and discussions
 help / color / mirror / Atom feed
From: Tadhg Kearney <tadhg.kearney@intel.com>
To: reshma.pattan@intel.com
Cc: dts@dpdk.org, Tadhg Kearney <tadhg.kearney@intel.com>
Subject: [PATCH] tests/vm_power_manager: remove multimvs test case
Date: Thu, 24 Feb 2022 16:00:47 +0000	[thread overview]
Message-ID: <20220224160047.669996-1-tadhg.kearney@intel.com> (raw)

Test "test_vm_power_multivms" removed due to:
  1.Not being relevant to the power managment test suite.
  2.Not a test that needs to be carried out regardless.

Signed-off-by: Tadhg Kearney <tadhg.kearney@intel.com>
---
 tests/TestSuite_vm_power_manager.py | 49 -----------------------------
 1 file changed, 49 deletions(-)

diff --git a/tests/TestSuite_vm_power_manager.py b/tests/TestSuite_vm_power_manager.py
index ea104a38..06419de6 100644
--- a/tests/TestSuite_vm_power_manager.py
+++ b/tests/TestSuite_vm_power_manager.py
@@ -224,55 +224,6 @@ class TestVmPowerManager(TestCase):
             print((utils.GREEN("After frequency min, freq is %d\n" % min_freq)))
         self.vm_dut.send_expect("quit", "# ")
 
-    def test_vm_power_multivms(self):
-        """
-        Check power management channel connected in multiple VMs
-        """
-        vm_name = "vm1"
-        cpus = self.dut.get_core_list('1S/4C/1T', socket=1)
-        self.verify(len(cpus) == 4, "Can't allocate cores from numa 1")
-
-        vm2 = LibvirtKvm(self.dut, vm_name, self.suite_name)
-        channels = [
-            {'path': '/tmp/powermonitor/%s.0' %
-                vm_name, 'name': 'virtio.serial.port.poweragent.0'},
-            {'path': '/tmp/powermonitor/%s.1' %
-                vm_name, 'name': 'virtio.serial.port.poweragent.1'},
-            {'path': '/tmp/powermonitor/%s.2' %
-                vm_name, 'name': 'virtio.serial.port.poweragent.2'},
-            {'path': '/tmp/powermonitor/%s.3' %
-                vm_name, 'name': 'virtio.serial.port.poweragent.3'}
-        ]
-        for channel in channels:
-            vm2.add_vm_virtio_serial_channel(**channel)
-
-        # start vm2 with socket 1 cpus
-        cpupin = ''
-        for cpu in cpus:
-            cpupin += '%s ' % cpu
-        vm2_cpus = {'number': '4', 'cpupin': cpupin[:-1]}
-        vm2.set_vm_cpu(**vm2_cpus)
-        vm2_dut = vm2.start()
-
-        self.dut.send_expect("add_vm %s" % vm_name, "vmpower>")
-        self.dut.send_expect("add_channels %s all" % vm_name, "vmpower>")
-        vm_info = self.dut.send_expect("show_vm %s" % vm_name, "vmpower>")
-
-        # check host core has correct mapped
-        cpu_idx = 0
-        for cpu in cpus:
-            cpu_map = '[%d]: Physical CPU %s' % (cpu_idx, cpu)
-            self.verify(cpu_map in vm_info, "Failed to map host cpu %s" % cpu)
-            cpu_idx += 1
-
-        out = vm2_dut.build_dpdk_apps("examples/vm_power_manager/guest_cli")
-        self.verify("Error" not in out, "Compilation error")
-        self.verify("No such" not in out, "Compilation error")
-
-        out = vm2_dut.send_expect(self.guest_cmd, "vmpower\(guest\)>", 120)
-        vm2_dut.send_expect("quit", "# ")
-        vm2.stop()
-
     def get_freq_in_transmission(self):
         self.cur_freq = self.get_cpu_frequency(self.vcpu_map[1])
         print((utils.GREEN("Current cpu frequency %d" % self.cur_freq)))
-- 
2.25.1

--------------------------------------------------------------
Intel Research and Development Ireland Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263


This e-mail and any attachments may contain confidential material for the sole
use of the intended recipient(s). Any review or distribution by others is
strictly prohibited. If you are not the intended recipient, please contact the
sender and delete all copies.


             reply	other threads:[~2022-02-24 16:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-24 16:00 Tadhg Kearney [this message]
2022-02-24 16:30 ` Pattan, Reshma
2022-02-27 14:14 ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220224160047.669996-1-tadhg.kearney@intel.com \
    --to=tadhg.kearney@intel.com \
    --cc=dts@dpdk.org \
    --cc=reshma.pattan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).