test suite reviews and discussions
 help / color / mirror / Atom feed
From: Jun Dong <junx.dong@intel.com>
To: dts@dpdk.org, ohilyard@iol.unh.edu
Cc: lijuan.tu@intel.com, qingx.sun@intel.com, junx.dong@intel.com
Subject: [dts] [V1 5/5] tests/TestSuite_stats_checks: fix pylama errors
Date: Fri, 11 Mar 2022 10:00:21 +0800	[thread overview]
Message-ID: <20220311020022.6678-6-junx.dong@intel.com> (raw)
In-Reply-To: <20220311020022.6678-1-junx.dong@intel.com>

Pylama found the following errors:
tests/TestSuite_stats_checks.py:265: [E] E0102 method already defined line 65 [pylint]
tests/TestSuite_stats_checks.py:271: [E] E0102 method already defined line 71 [pylint]

Signed-off-by: Jun Dong <junx.dong@intel.com>
---
 tests/TestSuite_stats_checks.py | 22 ----------------------
 1 file changed, 22 deletions(-)

diff --git a/tests/TestSuite_stats_checks.py b/tests/TestSuite_stats_checks.py
index ab120010..e72a67ab 100644
--- a/tests/TestSuite_stats_checks.py
+++ b/tests/TestSuite_stats_checks.py
@@ -48,7 +48,6 @@ from framework.test_case import TestCase
 
 ETHER_HEADER_LEN = 18
 IP_HEADER_LEN = 20
-ETHER_STANDARD_MTU = 1518
 RANDOM_IP_POOL = ['192.168.10.222/0']
 prefix_list = ['rx_good_packets', 'tx_good_packets', 'rx_good_bytes', 'tx_good_bytes']
 
@@ -62,21 +61,6 @@ class TestStatsChecks(TestCase):
     # of TestCase. This was done because the current test system doesn't support
     # inheritance.
     #
-    def tear_down(self):
-        """
-        Run after each test case.
-        """
-        self.dut.kill_all()
-
-    def tear_down_all(self):
-        """
-        When the case of this test suite finished, the environment should
-        clear up.
-        """
-        self.tester.send_expect(f"ifconfig {self.tester.get_interface(self.tester.get_local_port(self.rx_port))} " +
-                                f"mtu {ETHER_STANDARD_MTU}", "# ")
-        super().tear_down_all()
-
     def exec(self, command: str) -> str:
         """
         An abstraction to remove repeated code throughout the subclasses of this class
@@ -275,12 +259,6 @@ class TestStatsChecks(TestCase):
         """
         self.dut.kill_all()
 
-    #
-    #
-    #
-    # Test cases.
-    #
-
     def test_stats_checks(self):
         self.pmdout.start_testpmd("Default")
         self.exec("port start all")
-- 
2.25.1


  parent reply	other threads:[~2022-03-11  2:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-11  2:00 [dts] [V1 0/5] " Jun Dong
2022-03-11  2:00 ` [dts] [V1 1/5] framework/ixia_network/ixnet: " Jun Dong
2022-03-11  2:00 ` [dts] [V1 2/5] framework/pktgen_ixia_network: " Jun Dong
2022-03-11  2:00 ` [dts] [V1 3/5] framework/tester: " Jun Dong
2022-03-11  2:00 ` [dts] [V1 4/5] tests/TestSuite_mtu_update: " Jun Dong
2022-03-11  2:00 ` Jun Dong [this message]
2022-03-11  5:14   ` [dts] [V1 5/5] tests/TestSuite_stats_checks: " Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220311020022.6678-6-junx.dong@intel.com \
    --to=junx.dong@intel.com \
    --cc=dts@dpdk.org \
    --cc=lijuan.tu@intel.com \
    --cc=ohilyard@iol.unh.edu \
    --cc=qingx.sun@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).