From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 92888A0093; Fri, 11 Mar 2022 03:01:00 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8843B4113E; Fri, 11 Mar 2022 03:01:00 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 3896E4113E for ; Fri, 11 Mar 2022 03:00:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646964057; x=1678500057; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=jjAcTMlU+ho9uZoVT/epsZxeBCvApo2hh26bFrWRhkA=; b=YA+LwuzffOEap2t84Uj2mCLKhHgRkwpKClmTuKvlb0AGA/fmt68qWMtc 0BOXxMTeuxybzEqNrLND8UztUq7aUQVI4LFbOMxEsB8TAYWYJtW9ZL5xg gD0A8QLOqA4csk5QT3jLpNDh9j88tpg4ChtOgaLQhvypGAsbWY29uEg6e KbqD7Imtq4Jtv1b2T5DyO5YVefRMRYOFJST7X2+wgu4X1vUlAXdhIxWqY u1kYLzFrjbARDgF1KTIzzRDC+E9zk/g/sUGASY8iMAxv6M60ZI2V93qtW jJZBVi/kkop5h6JxFWtBBLnE0+EXYhmGHqgPWy+ovUBZ8fRlMoiPNRS5N A==; X-IronPort-AV: E=McAfee;i="6200,9189,10282"; a="255421933" X-IronPort-AV: E=Sophos;i="5.90,172,1643702400"; d="scan'208";a="255421933" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Mar 2022 18:00:40 -0800 X-IronPort-AV: E=Sophos;i="5.90,172,1643702400"; d="scan'208";a="633256560" Received: from shwdenpg197.ccr.corp.intel.com ([10.253.109.70]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Mar 2022 18:00:38 -0800 From: Jun Dong To: dts@dpdk.org, ohilyard@iol.unh.edu Cc: lijuan.tu@intel.com, qingx.sun@intel.com, junx.dong@intel.com Subject: [dts] [V1 5/5] tests/TestSuite_stats_checks: fix pylama errors Date: Fri, 11 Mar 2022 10:00:21 +0800 Message-Id: <20220311020022.6678-6-junx.dong@intel.com> X-Mailer: git-send-email 2.33.1.windows.1 In-Reply-To: <20220311020022.6678-1-junx.dong@intel.com> References: <20220311020022.6678-1-junx.dong@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Pylama found the following errors: tests/TestSuite_stats_checks.py:265: [E] E0102 method already defined line 65 [pylint] tests/TestSuite_stats_checks.py:271: [E] E0102 method already defined line 71 [pylint] Signed-off-by: Jun Dong --- tests/TestSuite_stats_checks.py | 22 ---------------------- 1 file changed, 22 deletions(-) diff --git a/tests/TestSuite_stats_checks.py b/tests/TestSuite_stats_checks.py index ab120010..e72a67ab 100644 --- a/tests/TestSuite_stats_checks.py +++ b/tests/TestSuite_stats_checks.py @@ -48,7 +48,6 @@ from framework.test_case import TestCase ETHER_HEADER_LEN = 18 IP_HEADER_LEN = 20 -ETHER_STANDARD_MTU = 1518 RANDOM_IP_POOL = ['192.168.10.222/0'] prefix_list = ['rx_good_packets', 'tx_good_packets', 'rx_good_bytes', 'tx_good_bytes'] @@ -62,21 +61,6 @@ class TestStatsChecks(TestCase): # of TestCase. This was done because the current test system doesn't support # inheritance. # - def tear_down(self): - """ - Run after each test case. - """ - self.dut.kill_all() - - def tear_down_all(self): - """ - When the case of this test suite finished, the environment should - clear up. - """ - self.tester.send_expect(f"ifconfig {self.tester.get_interface(self.tester.get_local_port(self.rx_port))} " + - f"mtu {ETHER_STANDARD_MTU}", "# ") - super().tear_down_all() - def exec(self, command: str) -> str: """ An abstraction to remove repeated code throughout the subclasses of this class @@ -275,12 +259,6 @@ class TestStatsChecks(TestCase): """ self.dut.kill_all() - # - # - # - # Test cases. - # - def test_stats_checks(self): self.pmdout.start_testpmd("Default") self.exec("port start all") -- 2.25.1