test suite reviews and discussions
 help / color / mirror / Atom feed
From: Jiale Song <songx.jiale@intel.com>
To: dts@dpdk.org
Cc: Jiale Song <songx.jiale@intel.com>
Subject: [dts] [PATCH V2] tests/distributor: remove dpdk modification
Date: Thu, 31 Mar 2022 12:43:20 +0000	[thread overview]
Message-ID: <20220331124320.4774-1-songx.jiale@intel.com> (raw)

According to dpdk commit e7f6d1289bc2 ("examples/distributor: reduce Tx queue number to 1").
remove the modification of dpdk code.

Signed-off-by: Jiale Song <songx.jiale@intel.com>
---
 test_plans/distributor_test_plan.rst | 4 ----
 tests/TestSuite_distributor.py       | 9 ---------
 2 files changed, 13 deletions(-)

diff --git a/test_plans/distributor_test_plan.rst b/test_plans/distributor_test_plan.rst
index 1e99a037..7a1f96bf 100644
--- a/test_plans/distributor_test_plan.rst
+++ b/test_plans/distributor_test_plan.rst
@@ -71,10 +71,6 @@ Verify burst distributor API cost much less cycles then normal version
 
 Test case: Distribute with maximum workers
 ==========================================
-In order to make more queue as worker, let a core receive and a core send::
-
-           sed -i -e 's/.*txRings = .*/\\tconst uint16_t rxRings = 1, txRings = 1;/' ./examples/distributor/main.c
-
 Start distributor sample with 63(0xeffffffffffffffff0) workers
 
 Send several packets with ip address increasing
diff --git a/tests/TestSuite_distributor.py b/tests/TestSuite_distributor.py
index c945fb32..24dd6d5e 100644
--- a/tests/TestSuite_distributor.py
+++ b/tests/TestSuite_distributor.py
@@ -45,11 +45,6 @@ class TestDistributor(TestCase):
         """
         Run at the start of each test suite.
         """
-        # reduce tx queues for enable many workers
-        self.dut.send_expect(
-            "sed -i -e 's/.*txRings = .*/\\tconst uint16_t rxRings = 1, txRings = 1;/' ./examples/distributor/main.c",
-            "#",
-        )
         out = self.dut.build_dpdk_apps("./examples/distributor")
         self.verify("Error" not in out, "Compilation error")
         self.verify("No such" not in out, "Compilation error")
@@ -301,8 +296,4 @@ class TestDistributor(TestCase):
         """
         Run after each test suite.
         """
-        self.dut.send_expect(
-            "sed -i -e 's/.*txRings = .*/\\tconst uint16_t rxRings = 1, txRings = rte_lcore_count() - 1;/' ./examples/distributor/main.c",
-            "#",
-        )
         pass
-- 
2.17.1


             reply	other threads:[~2022-03-31  4:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-31 12:43 Jiale Song [this message]
2022-03-31  5:19 ` Huang, ZhiminX
2022-03-31  6:36 ` lijuan.tu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220331124320.4774-1-songx.jiale@intel.com \
    --to=songx.jiale@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).