test suite reviews and discussions
 help / color / mirror / Atom feed
From: Jiale Song <songx.jiale@intel.com>
To: dts@dpdk.org
Cc: Jiale Song <songx.jiale@intel.com>
Subject: [dts] [PATCH V1] tests/generic_flow_api: add ICE nic to checklist and check link status
Date: Fri, 10 Jun 2022 13:15:48 +0800	[thread overview]
Message-ID: <20220610051548.890350-1-songx.jiale@intel.com> (raw)

fix 2 issue:
  1."jumbo_frame_size" is designed for NIC (82599, I350, 82576 and 82580) in testplan, so ICE NIC
not support this case, add to checklist.
  2.confirm that the port link status is up before sending the package.

Signed-off-by: Jiale Song <songx.jiale@intel.com>
---
 conf/test_case_checklist.json       | 5 ++++-
 tests/TestSuite_generic_flow_api.py | 1 +
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/conf/test_case_checklist.json b/conf/test_case_checklist.json
index 053841ce..b3fd5c1f 100644
--- a/conf/test_case_checklist.json
+++ b/conf/test_case_checklist.json
@@ -126,7 +126,10 @@
                 "cavium_a011",
                 "I40E_10G-SFP_X722",
                 "I40E_10G-10G_BASE_T_X722",
-                "I40E_10G-10G_BASE_T_BC"
+                "I40E_10G-10G_BASE_T_BC",
+                "ICE_100G-E810C_QSFP",
+                "ICE_25G-E810C_SFP",
+                "ICE_25G-E810_XXV_SFP"
             ],
             "Target": [
                 "ALL"
diff --git a/tests/TestSuite_generic_flow_api.py b/tests/TestSuite_generic_flow_api.py
index 1f1c5d0f..0e414bbf 100644
--- a/tests/TestSuite_generic_flow_api.py
+++ b/tests/TestSuite_generic_flow_api.py
@@ -4887,6 +4887,7 @@ class TestGeneric_flow_api(TestCase):
             "created",
         )
 
+        self.pmdout.wait_link_status_up(0)
         self.sendpkt(
             pktstr='Ether(dst="%s")/IP(src="2.2.2.5",dst="2.2.2.4")/TCP(dport=80,flags="S")/Raw(load="\x50"*8962)'
             % self.pf_mac
-- 
2.25.1


             reply	other threads:[~2022-06-10  5:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-10  5:15 Jiale Song [this message]
2022-06-15  8:38 ` lijuan.tu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220610051548.890350-1-songx.jiale@intel.com \
    --to=songx.jiale@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).