test suite reviews and discussions
 help / color / mirror / Atom feed
From: Jiale Song <songx.jiale@intel.com>
To: dts@dpdk.org
Cc: Jiale Song <songx.jiale@intel.com>
Subject: [dts] [PATCH V1] tests/ip_pipeline: optimize scripts
Date: Thu, 16 Jun 2022 15:14:48 +0800	[thread overview]
Message-ID: <20220616071448.136874-1-songx.jiale@intel.com> (raw)

optimize 2 issue:
  1.the app should be closed after the case test, otherwise the
execution of other cases will be affected.
  2.sometimes the port link status changes slowly. need to ensure that
the port link status is up before sending the package.


Signed-off-by: Jiale Song <songx.jiale@intel.com>
---
 tests/TestSuite_ip_pipeline.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_ip_pipeline.py b/tests/TestSuite_ip_pipeline.py
index ab1637b5..be9c05b9 100644
--- a/tests/TestSuite_ip_pipeline.py
+++ b/tests/TestSuite_ip_pipeline.py
@@ -103,6 +103,8 @@ class TestIPPipeline(TestCase):
 
         self.tcpdump_start_sniff(rx_interface, filters)
 
+        # check that the link status of the port sending the packet is up
+        self.tester.is_interface_up(tx_interface)
         # Prepare the pkts to be sent
         self.tester.scapy_foreground()
         self.tester.scapy_append('pkt = rdpcap("%s")' % (pcap_file))
@@ -1036,7 +1038,8 @@ class TestIPPipeline(TestCase):
         """
         Run after each test case.
         """
-        pass
+        # close app
+        self.dut.send_expect("^C", "# ")
 
     def tear_down_all(self):
         """
-- 
2.25.1


             reply	other threads:[~2022-06-16  7:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-16  7:14 Jiale Song [this message]
2022-06-21  6:54 ` lijuan.tu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220616071448.136874-1-songx.jiale@intel.com \
    --to=songx.jiale@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).