test suite reviews and discussions
 help / color / mirror / Atom feed
From: Wei Ling <weix.ling@intel.com>
To: dts@dpdk.org
Cc: Wei Ling <weix.ling@intel.com>
Subject: [dts][PATCH V1 2/2] tests/virtio_user_as_exceptional_path: delete modify dpdk code steps
Date: Fri, 24 Jun 2022 02:55:29 -0400	[thread overview]
Message-ID: <20220624065529.2832947-1-weix.ling@intel.com> (raw)

According to the dpdk commit 1945c64674(app/testpmd: perform SW IP
checksum for GRO/GSO packets) and commit 8ba1723783(net/vhost:
perform SW checksum in Tx path), no need to modify DPDK code to test.

Signed-off-by: Wei Ling <weix.ling@intel.com>
---
 ...stSuite_virtio_user_as_exceptional_path.py | 26 -------------------
 1 file changed, 26 deletions(-)

diff --git a/tests/TestSuite_virtio_user_as_exceptional_path.py b/tests/TestSuite_virtio_user_as_exceptional_path.py
index 1f7d8330..c5105d5f 100644
--- a/tests/TestSuite_virtio_user_as_exceptional_path.py
+++ b/tests/TestSuite_virtio_user_as_exceptional_path.py
@@ -44,7 +44,6 @@ class TestVirtioUserAsExceptionalPath(TestCase):
             self.socket_mem = "1024,1024"
         self.pktgen_helper = PacketGeneratorHelper()
         self.peer_pci_setup = False
-        self.prepare_dpdk()
         self.app_testpmd_path = self.dut.apps_name["test-pmd"]
         self.testpmd_name = self.app_testpmd_path.split("/")[-1]
 
@@ -181,30 +180,6 @@ class TestVirtioUserAsExceptionalPath(TestCase):
             "ip netns exec ns1 ethtool -K %s tso on" % self.nic_in_kernel, "#"
         )
 
-    def prepare_dpdk(self):
-        #
-        # Changhe the testpmd checksum fwd code for mac change
-        self.dut.send_expect(
-            "cp ./app/test-pmd/csumonly.c ./app/test-pmd/csumonly_backup.c", "#"
-        )
-        self.dut.send_expect(
-            "sed -i '/ether_addr_copy(&peer_eth/i\#if 0' ./app/test-pmd/csumonly.c", "#"
-        )
-        self.dut.send_expect(
-            "sed -i '/parse_ethernet(eth_hdr, &info/i\#endif' ./app/test-pmd/csumonly.c",
-            "#",
-        )
-        self.dut.build_install_dpdk(self.dut.target)
-        time.sleep(3)
-
-    def unprepare_dpdk(self):
-        # Recovery the DPDK code to original
-        self.dut.send_expect(
-            "cp ./app/test-pmd/csumonly_backup.c ./app/test-pmd/csumonly.c ", "#"
-        )
-        self.dut.send_expect("rm -rf ./app/test-pmd/csumonly_backup.c", "#")
-        self.dut.build_install_dpdk(self.dut.target)
-
     def iperf_result_verify(self, vm_client, direction):
         """
         Get the iperf test result
@@ -375,7 +350,6 @@ class TestVirtioUserAsExceptionalPath(TestCase):
         for i in self.dut_ports:
             port = self.dut.ports_info[i]["port"]
             port.bind_driver(self.def_driver)
-        self.unprepare_dpdk()
         if self.peer_pci_setup:
             self.dut.send_expect(
                 "./usertools/dpdk-devbind.py -u %s" % (self.pci), "# ", 30
-- 
2.25.1


             reply	other threads:[~2022-06-24  6:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-24  6:55 Wei Ling [this message]
2022-06-24  7:09 ` Huang, ChenyuX
2022-06-29  2:17 ` lijuan.tu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220624065529.2832947-1-weix.ling@intel.com \
    --to=weix.ling@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).