From: Jiale Song <songx.jiale@intel.com>
To: dts@dpdk.org
Cc: Jiale Song <songx.jiale@intel.com>
Subject: [dts] [PATCH V1 1/2] tests/ice_dcf_switch_filter_gtpu: remove the method of checking testpmd status
Date: Wed, 20 Jul 2022 17:11:12 +0000 [thread overview]
Message-ID: <20220720171113.902-1-songx.jiale@intel.com> (raw)
1.the "testpmd_status" is the wrong status when launch app timeout,
it will affect other cases test.remove this method.
2.add timeout.
Signed-off-by: Jiale Song <songx.jiale@intel.com>
---
tests/TestSuite_ice_dcf_switch_filter_gtpu.py | 26 +++++++------------
1 file changed, 10 insertions(+), 16 deletions(-)
diff --git a/tests/TestSuite_ice_dcf_switch_filter_gtpu.py b/tests/TestSuite_ice_dcf_switch_filter_gtpu.py
index 0f48d78d..c79eb1b2 100644
--- a/tests/TestSuite_ice_dcf_switch_filter_gtpu.py
+++ b/tests/TestSuite_ice_dcf_switch_filter_gtpu.py
@@ -3550,7 +3550,6 @@ class ICEDCFSwitchFilterGTPUTest(TestCase):
localPort = self.tester.get_local_port(self.dut_ports[0])
self.__tx_iface = self.tester.get_interface(localPort)
self.pkt = Packet()
- self.testpmd_status = "close"
self.pass_flag = "passed"
self.fail_flag = "failed"
# bind pf to kernel
@@ -3592,8 +3591,7 @@ class ICEDCFSwitchFilterGTPUTest(TestCase):
"""
dcf switch need reload driver to ensure create rule sucessful
"""
- self.dut.send_expect("rmmod ice", "# ", 15)
- self.dut.send_expect("modprobe ice", "# ", 15)
+ self.dut.send_expect("rmmod ice && modprobe ice", "# ", 120)
def create_testpmd_command(self):
"""
@@ -3617,8 +3615,7 @@ class ICEDCFSwitchFilterGTPUTest(TestCase):
launch testpmd with the command
"""
command = self.create_testpmd_command()
- self.dut.send_expect(command, "testpmd> ", 15)
- self.testpmd_status = "running"
+ self.dut.send_expect(command, "testpmd> ", 30)
self.dut.send_expect("set portlist 1", "testpmd> ", 15)
self.dut.send_expect("set fwd rxonly", "testpmd> ", 15)
self.dut.send_expect("set verbose 1", "testpmd> ", 15)
@@ -3817,17 +3814,14 @@ class ICEDCFSwitchFilterGTPUTest(TestCase):
"""
quit testpmd and destroy vf
"""
- if self.testpmd_status != "close":
- # destroy all flow rules on DCF
- self.dut.send_expect("flow flush 0", "testpmd> ", 15)
- self.dut.send_expect("clear port stats all", "testpmd> ", 15)
- self.dut.send_expect("quit", "#", 15)
- # kill all DPDK application
- self.dut.kill_all()
- # destroy vfs
- for port_id in self.dut_ports:
- self.dut.destroy_sriov_vfs_by_port(port_id)
- self.testpmd_status = "close"
+ # destroy all flow rules on DCF
+ self.dut.send_expect("quit", "# ")
+ # kill all DPDK application
+ self.dut.kill_all()
+ # destroy vfs
+ for port_id in self.dut_ports:
+ self.dut.destroy_sriov_vfs_by_port(port_id)
+
if getattr(self, "session_secondary", None):
self.dut.close_session(self.session_secondary)
--
2.17.1
next reply other threads:[~2022-07-20 8:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 17:11 Jiale Song [this message]
2022-07-20 17:11 ` [dts] [PATCH V1 2/2] tests/ice_dcf_switch_filter: " Jiale Song
2022-08-26 6:37 ` Li, WeiyuanX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220720171113.902-1-songx.jiale@intel.com \
--to=songx.jiale@intel.com \
--cc=dts@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).