test suite reviews and discussions
 help / color / mirror / Atom feed
From: Jiale Song <songx.jiale@intel.com>
To: dts@dpdk.org
Cc: Jiale Song <songx.jiale@intel.com>
Subject: [dts] [PATCH V1] tests/rxtx_offload: delete check times
Date: Thu,  4 Aug 2022 16:43:56 +0000	[thread overview]
Message-ID: <20220804164356.133220-1-songx.jiale@intel.com> (raw)

optimize script, the number of TX packages can not reach the specified
number within the specified times.therefore, delete the check times.

Signed-off-by: Jiale Song <songx.jiale@intel.com>
---
 tests/TestSuite_rxtx_offload.py | 18 +++++++-----------
 1 file changed, 7 insertions(+), 11 deletions(-)

diff --git a/tests/TestSuite_rxtx_offload.py b/tests/TestSuite_rxtx_offload.py
index c60bb68b..c3c9bde1 100644
--- a/tests/TestSuite_rxtx_offload.py
+++ b/tests/TestSuite_rxtx_offload.py
@@ -228,11 +228,11 @@ class TestRxTx_Offload(TestCase):
                 )
             i = i + 1
 
-    def verify_packets_increasing(self, rxtx="tx", count=2):
+    def verify_packets_increasing(self, rxtx="tx"):
         # Verify RXTX-packets increasing on each ports, check count < 25
         out1 = self.dut.send_expect("show port stats all", "testpmd> ")
-        i = 0
-        while i < count:
+        i = 1
+        while i:
             if rxtx == "tx":
                 pks_l1 = re.findall(r"TX-packets: (\w+)", out1)
                 time.sleep(15)
@@ -241,8 +241,6 @@ class TestRxTx_Offload(TestCase):
                 self.logger.info(
                     "Times="
                     + str(i)
-                    + ", count="
-                    + str(count)
                     + ", pks2_cur="
                     + str(pks_l2)
                     + ", pks1_before="
@@ -252,12 +250,10 @@ class TestRxTx_Offload(TestCase):
                     self.verify(
                         int(pks_l2[index]) > int(pks_l1[index]), "TX-packets hang"
                     )
-                if int(pks_l1[index]) < 100000000 or int(pks_l2[index]) < 100000000:
-                    count += 1
-            i += 1
-            if count > 25:
-                self.verify(False, "Check count timeout")
-                break
+                if int(pks_l2[index]) < 100000000:
+                    i += 1
+                else:
+                    break
 
     def get_queue_number(self, packet):
         """
-- 
2.25.1


                 reply	other threads:[~2022-08-04  8:43 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220804164356.133220-1-songx.jiale@intel.com \
    --to=songx.jiale@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).