test suite reviews and discussions
 help / color / mirror / Atom feed
From: Lingli Chen <linglix.chen@intel.com>
To: dts@dpdk.org
Cc: Lingli Chen <linglix.chen@intel.com>
Subject: [dts][PATCH V1] tests/dual_vlan: modify case vlan_tpid_config sync with testplan
Date: Wed, 10 Aug 2022 05:05:07 -0400	[thread overview]
Message-ID: <20220810090507.27306-1-linglix.chen@intel.com> (raw)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=y, Size: 1867 bytes --]

1.modify case vlan_tpid_config tpid 0x1234 sync with testplan
2.replace qinq with extend: Change the command according to the modification of dpdk commit 2a0b41984c7

Signed-off-by: Lingli Chen <linglix.chen@intel.com>
---
 test_plans/dual_vlan_test_plan.rst | 6 ++----
 tests/TestSuite_dual_vlan.py       | 2 +-
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/test_plans/dual_vlan_test_plan.rst b/test_plans/dual_vlan_test_plan.rst
index 762147f0..985394a2 100644
--- a/test_plans/dual_vlan_test_plan.rst
+++ b/test_plans/dual_vlan_test_plan.rst
@@ -245,7 +245,7 @@ Test Case: Configure receive port outer VLAN TPID
 
 Enable vlan header QinQ on port ``0`` firstly to support set TPID::
 
-    testpmd> vlan set qinq on 0
+    testpmd> vlan set extend on 0
 
 Check whether the mode is set successfully::
 
@@ -260,9 +260,7 @@ Check whether the mode is set successfully::
     Allmulticast mode: disabled
     Maximum number of MAC addresses: 127
     VLAN offload:
-      strip off
-      filter off
-      qinq(extend) on
+      strip off, filter off, extend on, qinq strip off
 
 Set Tag Protocol ID ``0x1234`` on port ``0``.
 Nic only support inner model, except Intel® Ethernet 700 Series::
diff --git a/tests/TestSuite_dual_vlan.py b/tests/TestSuite_dual_vlan.py
index 99f47a82..15d6f2b2 100644
--- a/tests/TestSuite_dual_vlan.py
+++ b/tests/TestSuite_dual_vlan.py
@@ -520,7 +520,7 @@ class TestDualVlan(TestCase):
 
         self.mode_config(filter="on", strip="on", extend="on")
         # nic only support inner model, except Intel® Ethernet 700 Series nic
-        self.dut.send_expect("vlan set inner tpid 1234 %s" % dutRxPortId, "testpmd> ")
+        self.dut.send_expect("vlan set inner tpid 0x1234 %s" % dutRxPortId, "testpmd> ")
         self.vlan_send_packet(outvlan, invlan)
 
         out = self.get_tcpdump_package()
-- 
2.17.1


             reply	other threads:[~2022-08-10  9:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-10  9:05 Lingli Chen [this message]
2022-08-24  8:42 ` Li, WeiyuanX
2022-08-25  5:06 ` Peng, Yuan
2022-09-07  9:35 ` lijuan.tu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220810090507.27306-1-linglix.chen@intel.com \
    --to=linglix.chen@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).