test suite reviews and discussions
 help / color / mirror / Atom feed
From: Jiale Song <songx.jiale@intel.com>
To: dts@dpdk.org
Cc: Jiale Song <songx.jiale@intel.com>
Subject: [dts] [PATCH V1 2/5] tests/ice_switch_filter: optimize the rte_flow test process
Date: Mon, 15 Aug 2022 14:00:32 +0000	[thread overview]
Message-ID: <20220815140035.1186904-2-songx.jiale@intel.com> (raw)
In-Reply-To: <20220815140035.1186904-1-songx.jiale@intel.com>

1. synchronize test plans, lower log level.
2. optimization scripts, remove the method of reload ice.
3. optimize the rte_flow test process that the action is switch to queue.

Signed-off-by: Jiale Song <songx.jiale@intel.com>
---
 tests/TestSuite_ice_switch_filter.py | 24 +++++++++++++-----------
 1 file changed, 13 insertions(+), 11 deletions(-)

diff --git a/tests/TestSuite_ice_switch_filter.py b/tests/TestSuite_ice_switch_filter.py
index 76bd630f..f5f8ec1f 100644
--- a/tests/TestSuite_ice_switch_filter.py
+++ b/tests/TestSuite_ice_switch_filter.py
@@ -4279,16 +4279,14 @@ class ICESwitchFilterTest(TestCase):
 
         self.generate_file_with_fdir_rules()
         self.path = self.dut.apps_name["test-pmd"]
-
-    def reload_ice(self):
-        self.dut.send_expect("rmmod ice", "# ", 15)
-        self.dut.send_expect("modprobe ice", "# ", 15)
+        self.rxq = 16
+        self.rxq_param = "--rxq={0} --txq={0}".format(self.rxq)
 
     def set_up(self):
         """
         Run before each test case.
         """
-        self.reload_ice()
+        pass
 
     def generate_file_with_fdir_rules(self):
         """
@@ -4327,9 +4325,8 @@ class ICESwitchFilterTest(TestCase):
         # Prepare testpmd EAL and parameters
         all_eal_param = self.dut.create_eal_parameters(cores="1S/4C/1T", ports=[0])
         command = (
-            self.path + all_eal_param + ' --log-level="ice,8" -- -i --rxq=16 --txq=16 '
+            self.path + all_eal_param + ' --log-level="ice,7" -- -i %s' % self.rxq_param
         )
-        # command = "./%s/app/testpmd %s --log-level=\"ice,8\" -- -i %s" % (self.dut.target, all_eal_param, "--rxq=16 --txq=16")
         return command
 
     def create_testpmd_command_pipeline_mode(self):
@@ -4341,7 +4338,7 @@ class ICESwitchFilterTest(TestCase):
             cores="1S/4C/1T", ports=[0], port_options={0: "pipeline-mode-support=1"}
         )
         command = (
-            self.path + all_eal_param + ' --log-level="ice,8" -- -i --rxq=16 --txq=16'
+            self.path + all_eal_param + ' --log-level="ice,7" -- -i %s' % self.rxq_param
         )
         return command
 
@@ -4370,13 +4367,15 @@ class ICESwitchFilterTest(TestCase):
         """
         # Specify the port to use
         dic["check_func"]["param"]["expect_port"] = port
+        dic["check_func"]["param"]["rxq"] = self.rxq
+        self.pmd.wait_link_status_up(port)
         self.dut.send_expect("start", "testpmd> ", 15)
-        time.sleep(2)
         # send packets
         self.pkt.update_pkt(dic["scapy_str"])
         self.pkt.send_pkt(self.tester, tx_port=self.__tx_iface, count=1, timeout=370)
-        time.sleep(3)
-        out = self.dut.send_expect("stop", "testpmd> ", 15)
+        out1 = self.pmd.get_output(timeout=1)
+        out2 = self.pmd.execute_cmd("stop")
+        out = out1 + out2
         result_flag, log_msg = dic["check_func"]["func"](
             out, dic["check_func"]["param"], dic["expect_results"]
         )
@@ -4701,6 +4700,9 @@ class ICESwitchFilterTest(TestCase):
         count = 1
         for tv in test_vectors:
             pattern_name = tv["name"]
+            self.logger.info(
+                GREEN("{0} case_name:{1} {0}".format("*" * 20, pattern_name))
+            )
             test_results[pattern_name] = OrderedDict()
             # get the queues that packets originally came to
             if count == 1:
-- 
2.25.1


  reply	other threads:[~2022-08-15  6:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-15 14:00 [dts] [PATCH V1 1/5] test_plans/ice_switch_filter: change log level Jiale Song
2022-08-15 14:00 ` Jiale Song [this message]
2022-09-07 10:26   ` [dts] [PATCH V1 2/5] tests/ice_switch_filter: optimize the rte_flow test process Peng, Yuan
2022-08-15 14:00 ` [dts] [PATCH V1 3/5] test_plans/ice_switch_filter_pppoe: change log level Jiale Song
2022-09-07 10:26   ` Peng, Yuan
2022-08-15 14:00 ` [dts] [PATCH V1 4/5] tests/ice_switch_filter_pppoe: optimize the rte_flow test process Jiale Song
2022-09-07 10:26   ` Peng, Yuan
2022-08-15 14:00 ` [dts] [PATCH V1 5/5] tests/rte_flow_common: " Jiale Song
2022-08-26  6:15   ` Li, WeiyuanX
2022-09-07 10:26   ` Peng, Yuan
2022-09-08  1:50   ` lijuan.tu
2022-09-07 10:25 ` [dts] [PATCH V1 1/5] test_plans/ice_switch_filter: change log level Peng, Yuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220815140035.1186904-2-songx.jiale@intel.com \
    --to=songx.jiale@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).