test suite reviews and discussions
 help / color / mirror / Atom feed
From: Weiyuan Li <weiyuanx.li@intel.com>
To: dts@dpdk.org
Cc: Weiyuan Li <weiyuanx.li@intel.com>, Jiale Song <songx.jiale@intel.com>
Subject: [dts][PATCH V2 03/10] tests/checksum_offload: update dts code for dpdk csum change
Date: Fri, 26 Aug 2022 10:43:01 +0800	[thread overview]
Message-ID: <20220826024308.17447-3-weiyuanx.li@intel.com> (raw)
In-Reply-To: <20220826024308.17447-1-weiyuanx.li@intel.com>

According to dpdk commit 9b4ea7ae77fa(app/testpmd: revert MAC update in checksum forwarding) modify
the script adapt to this chagne.

1. Modify VF case to enable promisc.
2. Modify PF case to send packet dst mac is random.

Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
---
Tested-by: Jiale Song < songx.jiale@intel.com>

v2:
-modify dst mac address

 tests/TestSuite_checksum_offload.py | 35 +++++++++++++----------------
 1 file changed, 16 insertions(+), 19 deletions(-)

diff --git a/tests/TestSuite_checksum_offload.py b/tests/TestSuite_checksum_offload.py
index 3554f5eb..1ccc884c 100644
--- a/tests/TestSuite_checksum_offload.py
+++ b/tests/TestSuite_checksum_offload.py
@@ -204,11 +204,10 @@ class TestChecksumOffload(TestCase):
             self.tester.get_local_port(self.dut_ports[0])
         )
 
-        sniff_src = self.dut.get_mac_address(self.dut_ports[0])
+        sniff_src = "52:00:00:00:00:00"
         result = dict()
 
         chksum = self.get_chksum_values(packets_expected)
-
         inst = self.tester.tcpdump_sniff_packets(
             intf=rx_interface,
             count=len(packets_sent) * 4,
@@ -424,8 +423,9 @@ class TestChecksumOffload(TestCase):
     ):
         if os.path.isfile(capture_file_path):
             os.remove(capture_file_path)
+        src_mac = "52:00:00:00:00:00"
         self.tester.send_expect(
-            f"tcpdump -i '{iface}' ether src {dut_mac} -s 0 -w {capture_file_path} &",
+            f"tcpdump -i '{iface}' ether src {src_mac} -s 0 -w {capture_file_path} -Q in &",
             "# ",
         )
 
@@ -502,7 +502,8 @@ class TestChecksumOffload(TestCase):
         Verify that the same number of packet are correctly received on the
         traffic generator side.
         """
-        mac = self.dut.get_mac_address(self.dut_ports[0])
+        # mac = self.dut.get_mac_address(self.dut_ports[0])
+        mac = "52:00:00:00:00:01"
 
         pktsChkErr = {
             "IP/UDP": 'Ether(dst="%s", src="52:00:00:00:00:00")/Dot1Q(vlan=1)/IP(chksum=0x0)/UDP(chksum=0xf)/("X"*46)'
@@ -546,7 +547,7 @@ class TestChecksumOffload(TestCase):
         transmit packet.Enable Checksum offload.
         Verify the checksum valid-flags.
         """
-        mac = self.dut.get_mac_address(self.dut_ports[0])
+        mac = "52:00:00:00:00:01"
 
         pkts_ref = {
             "IP/UDP": 'Ether(dst="%s", src="52:00:00:00:00:00")/IP()/UDP()/("X"*46)'
@@ -611,7 +612,7 @@ class TestChecksumOffload(TestCase):
         Verify that the same number of packet are correctly received on the
         traffic generator side.
         """
-        mac = self.dut.get_mac_address(self.dut_ports[0])
+        mac = "52:00:00:00:00:01"
 
         pkts = {
             "IP/UDP": 'Ether(dst="%s", src="52:00:00:00:00:00")/IP(chksum=0x0)/UDP(chksum=0xf)/("X"*46)'
@@ -660,7 +661,7 @@ class TestChecksumOffload(TestCase):
         Verify that the same number of packet are correctly received on
         the traffic generator side.
         """
-        mac = self.dut.get_mac_address(self.dut_ports[0])
+        mac = "52:00:00:00:00:01"
         sndIP = "10.0.0.1"
         sndIPv6 = "::1"
         sndPkts = {
@@ -816,9 +817,8 @@ class TestChecksumOffload(TestCase):
         verification_errors: List[VerifyFailure] = []
 
         iface = self.tester.get_interface(self.tester.get_local_port(self.dut_ports[0]))
-        dut_mac = self.dut.get_mac_address(self.dut_ports[0])
-        tester_mac = self.tester.get_mac(self.tester.get_local_port(self.dut_ports[0]))
-
+        dut_mac = "52:00:00:00:00:01"
+        tester_mac = "52:00:00:00:00:00"
         self.scapy_exec(f"eth = Ether(dst='{dut_mac}', src='{tester_mac}')")
         self.scapy_exec(f"iface = '{iface}'")
 
@@ -848,8 +848,8 @@ class TestChecksumOffload(TestCase):
         verification_errors: List[VerifyFailure] = []
 
         iface = self.tester.get_interface(self.tester.get_local_port(self.dut_ports[0]))
-        dut_mac = self.dut.get_mac_address(self.dut_ports[0])
-        tester_mac = self.tester.get_mac(self.tester.get_local_port(self.dut_ports[0]))
+        dut_mac = "52:00:00:00:00:01"
+        tester_mac = "52:00:00:00:00:00"
         eth = Ether(dst=dut_mac, src=tester_mac)
 
         checksum_options = (
@@ -903,9 +903,8 @@ class TestChecksumOffload(TestCase):
         verification_errors: List[VerifyFailure] = []
 
         iface = self.tester.get_interface(self.tester.get_local_port(self.dut_ports[0]))
-        dut_mac = self.dut.get_mac_address(self.dut_ports[0])
-        tester_mac = self.tester.get_mac(self.tester.get_local_port(self.dut_ports[0]))
-
+        dut_mac = "52:00:00:00:00:01"
+        tester_mac = "52:00:00:00:00:00"
         self.tester.send_expect("scapy", ">>> ")
         self.scapy_exec(f"eth = Ether(dst='{dut_mac}', src='{tester_mac}')")
         self.scapy_exec(f"iface = '{iface}'")
@@ -1003,9 +1002,8 @@ class TestChecksumOffload(TestCase):
         verification_errors: List[VerifyFailure] = []
 
         iface = self.tester.get_interface(self.tester.get_local_port(self.dut_ports[0]))
-        dut_mac = self.dut.get_mac_address(self.dut_ports[0])
-        tester_mac = self.tester.get_mac(self.tester.get_local_port(self.dut_ports[0]))
-
+        dut_mac = "52:00:00:00:00:01"
+        tester_mac = "52:00:00:00:00:00"
         packets = self.get_packets(dut_mac, tester_mac)
 
         capture_file_name = "test_hardware_checksum_check_l4_tx_capture.pcap"
@@ -1022,7 +1020,6 @@ class TestChecksumOffload(TestCase):
         )
 
         captured_packets = rdpcap("output/tmp/pcap/" + capture_file_name)
-
         self.verify(
             len(packets) == len(captured_packets), "Not all packets were received"
         )
-- 
2.25.1


  parent reply	other threads:[~2022-08-26  2:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-26  2:42 [dts][PATCH V2 01/10] tests/vf_offload: " Weiyuan Li
2022-08-26  2:43 ` [dts][PATCH V2 02/10] test_plans/vf_offload: " Weiyuan Li
2022-08-26  2:43 ` Weiyuan Li [this message]
2022-08-26  2:43 ` [dts][PATCH V2 04/10] tests/ice_advanced_iavf_rss: " Weiyuan Li
2022-08-26  2:43 ` [dts][PATCH V2 05/10] test_plans/ice_advanced_iavf_rss: " Weiyuan Li
2022-08-26  2:43 ` [dts][PATCH V2 06/10] tests/ice_advanced_rss: " Weiyuan Li
2022-08-26  2:43 ` [dts][PATCH V2 07/10] test_plans/ice_advanced_rss: " Weiyuan Li
2022-08-26  2:43 ` [dts][PATCH V2 08/10] test_plans/ice_iavf_fdir: " Weiyuan Li
2022-08-26  2:43 ` [dts][PATCH V2 09/10] tests/tx_preparation: " Weiyuan Li
2022-08-26  2:43 ` [dts][PATCH V2 10/10] test_plans/ice_iavf_fdir: " Weiyuan Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220826024308.17447-3-weiyuanx.li@intel.com \
    --to=weiyuanx.li@intel.com \
    --cc=dts@dpdk.org \
    --cc=songx.jiale@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).