test suite reviews and discussions
 help / color / mirror / Atom feed
From: Weiyuan Li <weiyuanx.li@intel.com>
To: dts@dpdk.org
Cc: Weiyuan Li <weiyuanx.li@intel.com>
Subject: [dts][PATCH V2 1/2] tests/dual_vlan: optimize script case vlan_tpid_config add check tpid
Date: Thu,  8 Sep 2022 13:53:47 +0800	[thread overview]
Message-ID: <20220908055348.32751-1-weiyuanx.li@intel.com> (raw)

Optimize script case vlan_tpid_config add check tpid.

Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
---

v2:
-Patch conflict modification

 tests/TestSuite_dual_vlan.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_dual_vlan.py b/tests/TestSuite_dual_vlan.py
index 15d6f2b2..87c5325b 100644
--- a/tests/TestSuite_dual_vlan.py
+++ b/tests/TestSuite_dual_vlan.py
@@ -502,7 +502,7 @@ class TestDualVlan(TestCase):
 
     def test_vlan_tpid_config(self):
         """
-        Configure receive port out vlan TPID
+        Configure receive port inner VLAN TPID
         """
         self.verify(
             self.nic
@@ -524,6 +524,7 @@ class TestDualVlan(TestCase):
         self.vlan_send_packet(outvlan, invlan)
 
         out = self.get_tcpdump_package()
+        self.verify("0x8100" in out, "tpid is error: " + out)
         self.verify("vlan %s" % outvlan in out, "vlan tpid disable error: " + out)
         self.verify("vlan %s" % invlan in out, "vlan tpid disable error: " + out)
 
@@ -531,6 +532,7 @@ class TestDualVlan(TestCase):
         self.vlan_send_packet(outvlan, invlan)
 
         out = self.get_tcpdump_package()
+        self.verify("0x8100" in out, "tpid is error: " + out)
         self.verify(
             out is not None and "vlan" not in out, "vlane tpid enable error: " + out
         )
-- 
2.25.1


             reply	other threads:[~2022-09-08  5:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-08  5:53 Weiyuan Li [this message]
2022-09-08  5:53 ` [dts][PATCH V2 2/2] test_plans/dual_vlan: optimize dual_vlan test plan Weiyuan Li
2022-09-20  7:42   ` Fu, Qi
2022-09-20  8:08   ` lijuan.tu
2022-09-20  7:42 ` [dts][PATCH V2 1/2] tests/dual_vlan: optimize script case vlan_tpid_config add check tpid Fu, Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220908055348.32751-1-weiyuanx.li@intel.com \
    --to=weiyuanx.li@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).