test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1 1/2] tests/ice_dcf_switch_filter_gtpu: optimization script
@ 2022-09-14 10:33 Song Jiale
  2022-09-14 10:33 ` [dts] [PATCH V1 2/2] tests/ice_dcf_switch_filter_pppoe: " Song Jiale
  0 siblings, 1 reply; 2+ messages in thread
From: Song Jiale @ 2022-09-14 10:33 UTC (permalink / raw)
  To: dts; +Cc: Song Jiale

1.the "testpmd_status" is the wrong status when launch app timeout,
it will affect other cases test. therefore, changing the status first 
and then starting the app can solve this issue.
2.add timeout.

Signed-off-by: Song Jiale <songx.jiale@intel.com>
---
 tests/TestSuite_ice_dcf_switch_filter_gtpu.py | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/tests/TestSuite_ice_dcf_switch_filter_gtpu.py b/tests/TestSuite_ice_dcf_switch_filter_gtpu.py
index 0f48d78d..9e7a0e4d 100644
--- a/tests/TestSuite_ice_dcf_switch_filter_gtpu.py
+++ b/tests/TestSuite_ice_dcf_switch_filter_gtpu.py
@@ -3592,8 +3592,7 @@ class ICEDCFSwitchFilterGTPUTest(TestCase):
         """
         dcf switch need reload driver to ensure create rule sucessful
         """
-        self.dut.send_expect("rmmod ice", "# ", 15)
-        self.dut.send_expect("modprobe ice", "# ", 15)
+        self.dut.send_expect("rmmod ice && modprobe ice", "# ", 60)
 
     def create_testpmd_command(self):
         """
@@ -3617,8 +3616,8 @@ class ICEDCFSwitchFilterGTPUTest(TestCase):
         launch testpmd with the command
         """
         command = self.create_testpmd_command()
-        self.dut.send_expect(command, "testpmd> ", 15)
         self.testpmd_status = "running"
+        self.dut.send_expect(command, "testpmd> ", 30)
         self.dut.send_expect("set portlist 1", "testpmd> ", 15)
         self.dut.send_expect("set fwd rxonly", "testpmd> ", 15)
         self.dut.send_expect("set verbose 1", "testpmd> ", 15)
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [dts] [PATCH V1 2/2] tests/ice_dcf_switch_filter_pppoe: optimization script
  2022-09-14 10:33 [dts] [PATCH V1 1/2] tests/ice_dcf_switch_filter_gtpu: optimization script Song Jiale
@ 2022-09-14 10:33 ` Song Jiale
  0 siblings, 0 replies; 2+ messages in thread
From: Song Jiale @ 2022-09-14 10:33 UTC (permalink / raw)
  To: dts; +Cc: Song Jiale

1.the "testpmd_status" is the wrong status when launch app timeout,
it will affect other cases test. therefore, changing the status first 
and then starting the app can solve this issue.
2.add timeout.

Signed-off-by: Song Jiale <songx.jiale@intel.com>
---
 tests/TestSuite_ice_dcf_switch_filter_pppoe.py | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/tests/TestSuite_ice_dcf_switch_filter_pppoe.py b/tests/TestSuite_ice_dcf_switch_filter_pppoe.py
index 7b974e01..d8c8cb42 100644
--- a/tests/TestSuite_ice_dcf_switch_filter_pppoe.py
+++ b/tests/TestSuite_ice_dcf_switch_filter_pppoe.py
@@ -867,8 +867,7 @@ class ICEDCFSwitchFilterPPPOETest(TestCase):
         time.sleep(5)
 
     def reload_ice(self):
-        self.dut.send_expect("rmmod ice", "# ", 15)
-        self.dut.send_expect("modprobe ice", "# ", 15)
+        self.dut.send_expect("rmmod ice && modprobe ice", "# ", 60)
 
     def set_up(self):
         """
@@ -896,8 +895,8 @@ class ICEDCFSwitchFilterPPPOETest(TestCase):
         launch testpmd with the command
         """
         command = self.create_testpmd_command()
-        out = self.dut.send_expect(command, "testpmd> ", 15)
         self.testpmd_status = "running"
+        self.dut.send_expect(command, "testpmd> ", 30)
         self.dut.send_expect("set portlist 1", "testpmd> ", 15)
         self.dut.send_expect("set fwd rxonly", "testpmd> ", 15)
         self.dut.send_expect("set verbose 1", "testpmd> ", 15)
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-09-14  2:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-14 10:33 [dts] [PATCH V1 1/2] tests/ice_dcf_switch_filter_gtpu: optimization script Song Jiale
2022-09-14 10:33 ` [dts] [PATCH V1 2/2] tests/ice_dcf_switch_filter_pppoe: " Song Jiale

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).