test suite reviews and discussions
 help / color / mirror / Atom feed
From: Wei Ling <weix.ling@intel.com>
To: dts@dpdk.org
Cc: Wei Ling <weix.ling@intel.com>
Subject: [dts][PATCH V1] tests/pvp_vhost_user_reconnect: use the iperf test result as the expect value
Date: Tue, 20 Sep 2022 03:36:06 -0400	[thread overview]
Message-ID: <20220920073606.673212-1-weix.ling@intel.com> (raw)

Delete the hard code, use the iperf test result as the expect value.

Signed-off-by: Wei Ling <weix.ling@intel.com>
---
 tests/TestSuite_pvp_vhost_user_reconnect.py | 34 +++------------------
 1 file changed, 4 insertions(+), 30 deletions(-)

diff --git a/tests/TestSuite_pvp_vhost_user_reconnect.py b/tests/TestSuite_pvp_vhost_user_reconnect.py
index feb91bd4..646a9202 100644
--- a/tests/TestSuite_pvp_vhost_user_reconnect.py
+++ b/tests/TestSuite_pvp_vhost_user_reconnect.py
@@ -426,9 +426,6 @@ class TestPVPVhostUserReconnect(TestCase):
         self.config_vm_intf()
         self.start_iperf()
         self.before_data = self.iperf_result_verify(vm_cycle, "before reconnet")
-        # Because of repeat iperf test on Intel® Ethernet Converged Network Adapter XL710-QDA2 nic,
-        # the result is unstable, so use 15Gb/s as check value.
-        self.check_data = 15.000
 
         vm_cycle = 1
         # reconnet from vhost
@@ -440,12 +437,7 @@ class TestPVPVhostUserReconnect(TestCase):
             self.reconnect_data = self.iperf_result_verify(
                 vm_cycle, "reconnet from vhost"
             )
-            self.verify(
-                self.reconnect_data >= self.check_data,
-                "iperf test result lower than {0} after reconnect from vhost".format(
-                    self.check_data
-                ),
-            )
+            self.check_reconnect_perf()
 
         # reconnet from VM
         self.logger.info("now reconnect from vm")
@@ -458,12 +450,7 @@ class TestPVPVhostUserReconnect(TestCase):
             self.config_vm_intf()
             self.start_iperf()
             self.reconnect_data = self.iperf_result_verify(vm_cycle, "reconnet from vm")
-            self.verify(
-                self.reconnect_data > self.check_data,
-                "iperf test result lower than {0} after reconnect from vm".format(
-                    self.check_data
-                ),
-            )
+            self.check_reconnect_perf()
         self.result_table_print()
 
     def test_perf_packed_ring_reconnet_one_vm(self):
@@ -556,9 +543,6 @@ class TestPVPVhostUserReconnect(TestCase):
         self.config_vm_intf()
         self.start_iperf()
         self.before_data = self.iperf_result_verify(vm_cycle, "before reconnet")
-        # Because of repeat iperf test on Intel® Ethernet Converged Network Adapter XL710-QDA2 nic,
-        # the result is unstable, so use 15Gb/s as check value.
-        self.check_data = 15.000
 
         vm_cycle = 1
         # reconnet from vhost
@@ -570,12 +554,7 @@ class TestPVPVhostUserReconnect(TestCase):
             self.reconnect_data = self.iperf_result_verify(
                 vm_cycle, "reconnet from vhost"
             )
-            self.verify(
-                self.reconnect_data > self.check_data,
-                "iperf test result lower than {0} after reconnect from vhost".format(
-                    self.check_data
-                ),
-            )
+            self.check_reconnect_perf()
 
         # reconnet from VM
         self.logger.info("now reconnect from vm")
@@ -587,12 +566,7 @@ class TestPVPVhostUserReconnect(TestCase):
             self.config_vm_intf()
             self.start_iperf()
             self.reconnect_data = self.iperf_result_verify(vm_cycle, "reconnet from vm")
-            self.verify(
-                self.reconnect_data > self.check_data,
-                "iperf test result lower than {0} after recconnect from vm".format(
-                    self.check_data
-                ),
-            )
+            self.check_reconnect_perf()
         self.result_table_print()
 
     def tear_down(self):
-- 
2.25.1


             reply	other threads:[~2022-09-20  7:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-20  7:36 Wei Ling [this message]
2022-10-08  6:36 ` lijuan.tu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220920073606.673212-1-weix.ling@intel.com \
    --to=weix.ling@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).