test suite reviews and discussions
 help / color / mirror / Atom feed
From: Wei Ling <weix.ling@intel.com>
To: dts@dpdk.org
Cc: Wei Ling <weix.ling@intel.com>
Subject: [dts][PATCH V1 2/2] tests/vm2vm_virtio_net_perf: add tso=1 parameter when start virtio backend side
Date: Tue, 20 Sep 2022 03:50:04 -0400	[thread overview]
Message-ID: <20220920075004.673785-1-weix.ling@intel.com> (raw)

As DPDK commit 6d7046215a(net/vhost: fix TSO feature default disablement),
add tso=1 parameter when start virtio backend side to open the TSO
feature.

Signed-off-by: Wei Ling <weix.ling@intel.com>
---
 tests/TestSuite_vm2vm_virtio_net_perf.py | 39 +++++++++++-------------
 1 file changed, 18 insertions(+), 21 deletions(-)

diff --git a/tests/TestSuite_vm2vm_virtio_net_perf.py b/tests/TestSuite_vm2vm_virtio_net_perf.py
index ec659519..aef00404 100644
--- a/tests/TestSuite_vm2vm_virtio_net_perf.py
+++ b/tests/TestSuite_vm2vm_virtio_net_perf.py
@@ -68,40 +68,35 @@ class TestVM2VMVirtioNetPerf(TestCase):
         enable_queues=1,
         nb_cores=2,
         rxq_txq=None,
-        exchange_cbdma=False,
     ):
         """
         launch the testpmd with different parameters
         """
         testcmd = self.app_testpmd_path + " "
         if not client_mode:
-            vdev1 = "--vdev 'net_vhost0,iface=%s/vhost-net0,queues=%d' " % (
+            vdev1 = "--vdev 'net_vhost0,iface=%s/vhost-net0,queues=%d,tso=1' " % (
                 self.base_dir,
                 enable_queues,
             )
-            vdev2 = "--vdev 'net_vhost1,iface=%s/vhost-net1,queues=%d' " % (
+            vdev2 = "--vdev 'net_vhost1,iface=%s/vhost-net1,queues=%d,tso=1' " % (
                 self.base_dir,
                 enable_queues,
             )
         else:
-            vdev1 = "--vdev 'net_vhost0,iface=%s/vhost-net0,client=1,queues=%d' " % (
-                self.base_dir,
-                enable_queues,
+            vdev1 = (
+                "--vdev 'net_vhost0,iface=%s/vhost-net0,client=1,queues=%d,tso=1' "
+                % (
+                    self.base_dir,
+                    enable_queues,
+                )
             )
-            vdev2 = "--vdev 'net_vhost1,iface=%s/vhost-net1,client=1,queues=%d' " % (
-                self.base_dir,
-                enable_queues,
+            vdev2 = (
+                "--vdev 'net_vhost1,iface=%s/vhost-net1,client=1,queues=%d,tso=1' "
+                % (
+                    self.base_dir,
+                    enable_queues,
+                )
             )
-        if exchange_cbdma:
-            vdev1 = "--vdev 'net_vhost0,iface=%s/vhost-net0,client=1,queues=%d' " % (
-                self.base_dir,
-                enable_queues,
-            )
-            vdev2 = "--vdev 'net_vhost1,iface=%s/vhost-net1,client=1,queues=%d' " % (
-                self.base_dir,
-                enable_queues,
-            )
-
         eal_params = self.dut.create_eal_parameters(
             cores=self.cores_list, prefix="vhost", no_pci=no_pci
         )
@@ -256,8 +251,10 @@ class TestVM2VMVirtioNetPerf(TestCase):
         out_tx = self.vhost.send_expect("show port xstats 0", "testpmd> ", 20)
         out_rx = self.vhost.send_expect("show port xstats 1", "testpmd> ", 20)
 
-        rx_info = re.search("rx_size_1523_to_max_packets:\s*(\d*)", out_rx)
-        tx_info = re.search("tx_size_1523_to_max_packets:\s*(\d*)", out_tx)
+        # rx_info = re.search("rx_size_1523_to_max_packets:\s*(\d*)", out_rx)
+        rx_info = re.search("rx_q0_size_1519_max_packets:\s*(\d*)", out_rx)
+        # tx_info = re.search("tx_size_1523_to_max_packets:\s*(\d*)", out_tx)
+        tx_info = re.search("tx_q0_size_1519_max_packets:\s*(\d*)", out_tx)
 
         self.verify(
             int(rx_info.group(1)) > 0, "Port 1 not receive packet greater than 1522"
-- 
2.25.1


             reply	other threads:[~2022-09-20  7:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-20  7:50 Wei Ling [this message]
2022-10-08  6:37 ` lijuan.tu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220920075004.673785-1-weix.ling@intel.com \
    --to=weix.ling@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).