test suite reviews and discussions
 help / color / mirror / Atom feed
From: Weiyuan Li <weiyuanx.li@intel.com>
To: dts@dpdk.org
Cc: Weiyuan Li <weiyuanx.li@intel.com>,
	Lingli Chen <linglix.chen@intel.com>,
	Fu@dpdk.org, Qi <qi.fu@intel.com>
Subject: [dts][PATCH V3 2/2] tests/checksum_offload: checksum suite script and testplan optimization
Date: Fri, 23 Sep 2022 13:53:21 +0800	[thread overview]
Message-ID: <20220923055321.23361-2-weiyuanx.li@intel.com> (raw)
In-Reply-To: <20220923055321.23361-1-weiyuanx.li@intel.com>

Optimize the test case name to match test plan, add test case in test
plan to map test suite and delete the cmd "tx_checksum set 0x0 0" using "csum set".

Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
---
Tested-by: Lingli Chen <linglix.chen@intel.com>
Acked-by: Fu, Qi <qi.fu@intel.com>

v2:
-modify test plan delete IXIA description.
v3:
-delete case "Validate checksum on the receive packet".
-optimize the case in the test plan enable csum to used "csum set
ip|tcp|udp|sctp hw 0.
-optimzie the test steps of cases in the test plan change from IXIA to
scapy.

 tests/TestSuite_checksum_offload.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_checksum_offload.py b/tests/TestSuite_checksum_offload.py
index 1ccc884c..b181bf37 100644
--- a/tests/TestSuite_checksum_offload.py
+++ b/tests/TestSuite_checksum_offload.py
@@ -605,7 +605,7 @@ class TestChecksumOffload(TestCase):
         # send the packet checksum value different from the expected value
         self.checksum_valid_flags(pkts_bad, 0)
 
-    def test_checksum_offload_enable(self):
+    def test_insert_checksum_on_the_transmit_packet(self):
         """
         Insert IPv4/IPv6 UDP/TCP/SCTP checksum on the transmit packet.
         Enable Checksum offload.
@@ -654,7 +654,7 @@ class TestChecksumOffload(TestCase):
 
         self.verify(len(result) == 0, ",".join(list(result.values())))
 
-    def test_checksum_offload_disable(self):
+    def test_do_not_insert_checksum_on_the_transmit_packet(self):
         """
         Do not insert IPv4/IPv6 UDP/TCP checksum on the transmit packet.
         Disable Checksum offload.
-- 
2.25.1


  reply	other threads:[~2022-09-23  5:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-23  5:53 [dts][PATCH V3 1/2] test_plans/checksum_offload: " Weiyuan Li
2022-09-23  5:53 ` Weiyuan Li [this message]
2022-10-10  3:21   ` [dts][PATCH V3 2/2] tests/checksum_offload: " lijuan.tu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220923055321.23361-2-weiyuanx.li@intel.com \
    --to=weiyuanx.li@intel.com \
    --cc=Fu@dpdk.org \
    --cc=dts@dpdk.org \
    --cc=linglix.chen@intel.com \
    --cc=qi.fu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).