test suite reviews and discussions
 help / color / mirror / Atom feed
From: Weiyuan Li <weiyuanx.li@intel.com>
To: dts@dpdk.org
Cc: Weiyuan Li <weiyuanx.li@intel.com>
Subject: [dts][PATCH V1] tests/port_control: Optimize script check the port status after restarting the port
Date: Mon, 17 Oct 2022 13:16:51 +0800	[thread overview]
Message-ID: <20221017051651.21306-1-weiyuanx.li@intel.com> (raw)

The port status should be checked when the port is stopped and
restarted, not after the pmd is started.

Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
---
 tests/TestSuite_port_control.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_port_control.py b/tests/TestSuite_port_control.py
index bdb1b0ad..71b2ed87 100644
--- a/tests/TestSuite_port_control.py
+++ b/tests/TestSuite_port_control.py
@@ -124,9 +124,9 @@ class TestPortControl(TestCase):
 
     def start_pmd_port(self, terminal):
         terminal.execute_cmd("port start all")
+        terminal.wait_link_status_up("all")
         terminal.execute_cmd("start")
         time.sleep(5)
-        terminal.wait_link_status_up("all", timeout=5)
         ret = terminal.get_port_link_status(self.port_id_0)
         self.verify(ret == "up", "port not up!")
 
-- 
2.27.0


             reply	other threads:[~2022-10-17  5:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-17  5:16 Weiyuan Li [this message]
2022-10-27  5:40 ` Jiale, SongX
2022-10-28  2:25 ` Huang, ZhiminX
2022-11-18  8:15 ` lijuan.tu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221017051651.21306-1-weiyuanx.li@intel.com \
    --to=weiyuanx.li@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).