* [dts][PATCH V1] tests/port_control: Optimize script check the port status after restarting the port
@ 2022-10-17 5:16 Weiyuan Li
2022-10-27 5:40 ` Jiale, SongX
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Weiyuan Li @ 2022-10-17 5:16 UTC (permalink / raw)
To: dts; +Cc: Weiyuan Li
The port status should be checked when the port is stopped and
restarted, not after the pmd is started.
Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
---
tests/TestSuite_port_control.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/TestSuite_port_control.py b/tests/TestSuite_port_control.py
index bdb1b0ad..71b2ed87 100644
--- a/tests/TestSuite_port_control.py
+++ b/tests/TestSuite_port_control.py
@@ -124,9 +124,9 @@ class TestPortControl(TestCase):
def start_pmd_port(self, terminal):
terminal.execute_cmd("port start all")
+ terminal.wait_link_status_up("all")
terminal.execute_cmd("start")
time.sleep(5)
- terminal.wait_link_status_up("all", timeout=5)
ret = terminal.get_port_link_status(self.port_id_0)
self.verify(ret == "up", "port not up!")
--
2.27.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [dts][PATCH V1] tests/port_control: Optimize script check the port status after restarting the port
2022-10-17 5:16 [dts][PATCH V1] tests/port_control: Optimize script check the port status after restarting the port Weiyuan Li
@ 2022-10-27 5:40 ` Jiale, SongX
2022-10-28 2:25 ` Huang, ZhiminX
2022-11-18 8:15 ` lijuan.tu
2 siblings, 0 replies; 4+ messages in thread
From: Jiale, SongX @ 2022-10-27 5:40 UTC (permalink / raw)
To: dts; +Cc: Li, WeiyuanX
> -----Original Message-----
> From: Weiyuan Li <weiyuanx.li@intel.com>
> Sent: Monday, October 17, 2022 1:17 PM
> To: dts@dpdk.org
> Cc: Li, WeiyuanX <weiyuanx.li@intel.com>
> Subject: [dts][PATCH V1] tests/port_control: Optimize script check the port
> status after restarting the port
>
> The port status should be checked when the port is stopped and restarted,
> not after the pmd is started.
>
> Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
> ---
Tested-by: Song Jiale <songx.jiale@intel.com >
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [dts][PATCH V1] tests/port_control: Optimize script check the port status after restarting the port
2022-10-17 5:16 [dts][PATCH V1] tests/port_control: Optimize script check the port status after restarting the port Weiyuan Li
2022-10-27 5:40 ` Jiale, SongX
@ 2022-10-28 2:25 ` Huang, ZhiminX
2022-11-18 8:15 ` lijuan.tu
2 siblings, 0 replies; 4+ messages in thread
From: Huang, ZhiminX @ 2022-10-28 2:25 UTC (permalink / raw)
To: Li, WeiyuanX, dts; +Cc: Li, WeiyuanX
> -----Original Message-----
> From: Weiyuan Li <weiyuanx.li@intel.com>
> Sent: Monday, October 17, 2022 1:17 PM
> To: dts@dpdk.org
> Cc: Li, WeiyuanX <weiyuanx.li@intel.com>
> Subject: [dts][PATCH V1] tests/port_control: Optimize script check the port
> status after restarting the port
>
> The port status should be checked when the port is stopped and restarted, not
> after the pmd is started.
>
> Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
> ---
Acked-by: Zhimin Huang <zhiminx.huang@intel.com >
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dts][PATCH V1] tests/port_control: Optimize script check the port status after restarting the port
2022-10-17 5:16 [dts][PATCH V1] tests/port_control: Optimize script check the port status after restarting the port Weiyuan Li
2022-10-27 5:40 ` Jiale, SongX
2022-10-28 2:25 ` Huang, ZhiminX
@ 2022-11-18 8:15 ` lijuan.tu
2 siblings, 0 replies; 4+ messages in thread
From: lijuan.tu @ 2022-11-18 8:15 UTC (permalink / raw)
To: dts, Weiyuan Li; +Cc: Weiyuan Li
On Mon, 17 Oct 2022 13:16:51 +0800, Weiyuan Li <weiyuanx.li@intel.com> wrote:
> The port status should be checked when the port is stopped and
> restarted, not after the pmd is started.
>
> Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-11-18 8:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-17 5:16 [dts][PATCH V1] tests/port_control: Optimize script check the port status after restarting the port Weiyuan Li
2022-10-27 5:40 ` Jiale, SongX
2022-10-28 2:25 ` Huang, ZhiminX
2022-11-18 8:15 ` lijuan.tu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).