test suite reviews and discussions
 help / color / mirror / Atom feed
From: Weiyuan Li <weiyuanx.li@intel.com>
To: dts@dpdk.org, lijuan.tu@intel.com
Cc: Weiyuan Li <weiyuanx.li@intel.com>
Subject: [dts][PATCH V2 3/8] test_plans/vlan: modify script and test plan to support i40e fimware > 8.3
Date: Thu, 10 Nov 2022 13:33:53 +0800	[thread overview]
Message-ID: <20221110053358.437591-3-weiyuanx.li@intel.com> (raw)
In-Reply-To: <20221110053358.437591-1-weiyuanx.li@intel.com>

Modify script and test plan to i40e support fimware > 8.3.
When the fimrware > 8.3, if the filter is to take effect need to enable
extend.

Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
---

v2:
-use the firmware version to judge whether to add command `extend on`.

 test_plans/vlan_test_plan.rst | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/test_plans/vlan_test_plan.rst b/test_plans/vlan_test_plan.rst
index 6e2bf74e..442e4efe 100644
--- a/test_plans/vlan_test_plan.rst
+++ b/test_plans/vlan_test_plan.rst
@@ -61,6 +61,10 @@ Enable the receipt of VLAN packets with VLAN Tag Identifier 1 on port 0::
 
   testpmd> rx_vlan add 1 0
   testpmd> vlan set strip off 0
+  
+  if the i40e firmware version >= 8.4 the dpdk can only add 'extend on' to make the single VLAN filter work normally:
+  testpmd> vlan set extend on 0
+  
   testpmd> start
     rxonly packet forwarding - CRC stripping disabled - packets/burst=32
     nb forwarding cores=1 - nb forwarding ports=10
@@ -111,7 +115,10 @@ Test Case: Disable receipt of VLAN packets
 Disable the receipt of VLAN packets with Tag Identifier ``1`` on port 0.
 Send VLAN packets with the Tag Identifier ``1`` check that no packet is received
 on port ``B``, meaning that VLAN packets are now dropped on port 0::
-
+  
+  if the i40e firmware version >= 8.4 the dpdk can only add 'extend on' to make the single VLAN filter work normally:
+  testpmd> vlan set extend on 0
+  
   testpmd> rx_vlan rm 1 0
   testpmd> start
   rxonly packet forwarding - CRC stripping disabled - packets/burst=32
-- 
2.27.0


  parent reply	other threads:[~2022-11-10  5:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-10  5:33 [dts][PATCH V2 1/8] " Weiyuan Li
2022-11-10  5:33 ` [dts][PATCH V2 2/8] tests/vlan_ethertype_config: " Weiyuan Li
2022-11-10  5:33 ` Weiyuan Li [this message]
2022-11-10  5:33 ` [dts][PATCH V2 4/8] tests/vlan: " Weiyuan Li
2022-11-10  5:33 ` [dts][PATCH V2 5/8] test_plans/ipgre: " Weiyuan Li
2022-11-10  5:33 ` [dts][PATCH V2 6/8] tests/ipgre: " Weiyuan Li
2022-11-10  5:33 ` [dts][PATCH V2 7/8] test_plans/dual_vlan: " Weiyuan Li
2022-11-10  5:33 ` [dts][PATCH V2 8/8] tests/dual_vlan: " Weiyuan Li
2022-11-18  1:59   ` Jiale, SongX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221110053358.437591-3-weiyuanx.li@intel.com \
    --to=weiyuanx.li@intel.com \
    --cc=dts@dpdk.org \
    --cc=lijuan.tu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).