test suite reviews and discussions
 help / color / mirror / Atom feed
From: Lingli Chen <linglix.chen@intel.com>
To: dts@dpdk.org
Cc: zhiminx.huang@intel.com, Lingli Chen <linglix.chen@intel.com>
Subject: [dts][PATCH V1 6/8] tests/ddp_ppp_l2tp: remove --pkt-filter-mode sync dpdk change
Date: Thu, 15 Dec 2022 01:42:02 -0500	[thread overview]
Message-ID: <20221215064204.30802-6-linglix.chen@intel.com> (raw)
In-Reply-To: <20221215064204.30802-1-linglix.chen@intel.com>

According to dpdk commit 5007ac1318 (ethdev: remove deprecated Flow Director configuration) remove flow_director_filter raw pkt test case.

Signed-off-by: Lingli Chen <linglix.chen@intel.com>
---
 tests/TestSuite_ddp_ppp_l2tp.py | 162 +-------------------------------
 1 file changed, 1 insertion(+), 161 deletions(-)

diff --git a/tests/TestSuite_ddp_ppp_l2tp.py b/tests/TestSuite_ddp_ppp_l2tp.py
index c0890a48..7353fb1c 100644
--- a/tests/TestSuite_ddp_ppp_l2tp.py
+++ b/tests/TestSuite_ddp_ppp_l2tp.py
@@ -55,7 +55,7 @@ class TestDdpPppL2tp(TestCase):
         """
         self.dut_testpmd.start_testpmd(
             "Default",
-            "--pkt-filter-mode=perfect --port-topology=chained \
+            "--port-topology=chained \
             --txq=%s --rxq=%s"
             % (self.PF_QUEUE, self.PF_QUEUE),
         )
@@ -295,60 +295,6 @@ class TestDdpPppL2tp(TestCase):
                 result = "difq"
             self.verify(result == chk, "Faild to verify RSS when key word change!!!")
 
-    def run_fd_test(self, crlwords, flowtype, pctype, keywords, qchecks):
-        """
-        Use dynamic flowtype/pctype mapping, use default or dynamic change
-        control words to set flow director input configuration for new
-        protocol, setup raw flow type filter for flow director, check flow
-        director could work.
-        crlwords: control words of keyword
-        flowtype: define flow type 23~63 values for PPPoE and PPPoL2TPv2 packet
-                  types as test plan table.
-        pctype: profile defines below 14~21 pctypes for PPPoE and PPPoL2TPv2
-                packet types.
-        keywords: keywords have Session ID, S-Port, D-Port, IP SA, IP DA and
-                  etc.
-        qchecks: define sameq and difq. If change keywords, direct packets to
-                 queue 0, otherwise direct packets to same queue.
-        """
-
-        self.pctype_flowtype_mapping(flowtype, pctype)
-        if crlwords is not None:
-            self.dut_testpmd.execute_cmd("port stop all")
-            time.sleep(1)
-            self.dut_testpmd.execute_cmd(
-                "port config 0 pctype %s fdir_inset clear all" % pctype
-            )
-            for word in crlwords:
-                self.dut_testpmd.execute_cmd(
-                    "port config 0 pctype %s fdir_inset set field %s" % (pctype, word)
-                )
-            self.dut_testpmd.execute_cmd("port start all")
-        self.dut_testpmd.execute_cmd("start")
-        qnum = self.send_and_verify(flowtype, "def", "fd")
-        self.verify(qnum == 0, "Receive packet from wrong queue!!!")
-        self.raw_packet_generate(flowtype)
-        queue = random.randint(1, self.PF_QUEUE - 1)
-        self.dut_testpmd.execute_cmd(
-            "flow_director_filter 0 mode raw add flow %d fwd queue %d \
-            fd_id 1 packet /tmp/test.raw"
-            % (flowtype, queue)
-        )
-        qnum = self.send_and_verify(flowtype, "def", "fd")
-        qdef = qnum
-        self.verify(qnum == queue, "Receive packet from wrong queue!!!")
-        for word, chk in zip(keywords, qchecks):
-            qnum = self.send_and_verify(flowtype, word, "fd")
-            if qnum == qdef:
-                result = "sameq"
-            elif qnum == 0:
-                result = "difq"
-            self.verify(
-                result == chk,
-                "Faild to verify flow director when \
-                key word change!!!",
-            )
-
     def test_rss_pppoe(self):
         """
         PPPoE is supported by NVM with profile updated. Download profile then
@@ -481,112 +427,6 @@ class TestDdpPppL2tp(TestCase):
         qchecks = ["difq", "sameq"]
         self.run_rss_test(crlwords, 23, 18, keywords, qchecks)
 
-    def test_fd_pppoe(self):
-        """
-        PPPoE is supported by NVM with profile updated. Download profile then
-        set flowtype/pctype mapping, default flow director input set are MAC
-        SA, session ID, setup raw flow type filter for flow director, check
-        flow director could work when sending matched packets to configured
-        queue, otherwise direct packets to queue 0.
-        """
-        crlwords = None
-        keywords = ["src_mac", "session_id", "dst_mac"]
-        qchecks = ["difq", "difq", "sameq"]
-        self.run_fd_test(crlwords, 30, 17, keywords, qchecks)
-
-    def test_fd_l2tp(self):
-        """
-        L2TPv2 PAY is supported by NVM with profile updated. Download profile
-        then set flowtype/pctype mapping, default flow director input set are
-        MAC SA, session ID, setup raw flow type filter for flow director, check
-        flow director could work when sending matched packets to configured
-        queue, otherwise direct packets to queue 0.
-        """
-        crlwords = None
-        keywords = ["src_mac", "session_id", "dst_mac"]
-        qchecks = ["difq", "difq", "sameq"]
-        self.run_fd_test(crlwords, 26, 21, keywords, qchecks)
-
-    def test_fd_pppoe_ipv4(self):
-        """
-        PPPoE IPv4 is supported by NVM with profile updated. Download
-        profile then set flowtype/pctype mapping, default flow director input
-        set are IPv4 SA, IPv4 DA, S-Port, D-Port, setup raw flow type filter
-        for flow director, check flow director could work when sending matched
-        packets to configured queue, otherwise direct packets to queue 0.
-        """
-        crlwords = None
-        keywords = ["src_ip", "dst_ip", "sport", "dport", "session_id"]
-        qchecks = ["difq", "difq", "difq", "difq", "sameq"]
-        self.run_fd_test(crlwords, 28, 15, keywords, qchecks)
-
-    def test_fd_pppoe_ipv6(self):
-        """
-        PPPoE IPv6 is supported by NVM with profile updated. Download
-        profile then set flowtype/pctype mapping, default flow director input
-        set are IPv6 SA, IPv6 DA, S-Port, D-Port, setup raw flow type filter
-        for flow director, check flow director could work when sending matched
-        packets to configured queue, otherwise direct packets to queue 0.
-        """
-        crlwords = None
-        keywords = ["src_ipv6", "dst_ipv6", "sport", "dport", "session_id"]
-        qchecks = ["difq", "difq", "difq", "difq", "sameq"]
-        self.run_fd_test(crlwords, 29, 16, keywords, qchecks)
-
-    def test_fd_pppol2tp_ipv4(self):
-        """
-        PPPoL2TPv2 IPv4 is supported by NVM with profile updated. Download
-        profile then set flowtype/pctype mapping, default flow director input
-        set are IPv4 SA, IPv4 DA, S-Port, D-Port, setup raw flow type filter
-        for flow director, check flow director could work when sending matched
-        packets to configured queue, otherwise direct packets to queue 0.
-        """
-        crlwords = None
-        keywords = ["src_ip", "dst_ip", "sport", "dport"]
-        qchecks = ["difq", "difq", "difq", "difq"]
-        self.run_fd_test(crlwords, 23, 18, keywords, qchecks)
-
-    def test_fd_pppol2tp_ipv6(self):
-        """
-        PPPoL2TPv2 IPv6 is supported by NVM with profile updated. Download
-        profile then set flowtype/pctype mapping, default flow director input
-        set are IPv6 SA, IPv6 DA, S-Port, D-Port, setup raw flow type filter
-        for flow director, check flow director could work when sending matched
-        packets to configured queue, otherwise direct packets to queue 0.
-        """
-        crlwords = None
-        keywords = ["src_ipv6", "dst_ipv6", "sport", "dport"]
-        qchecks = ["difq", "difq", "difq", "difq"]
-        self.run_fd_test(crlwords, 24, 19, keywords, qchecks)
-
-    def test_fd_pppol2tp_ipv4_dstip(self):
-        """
-        PPPoL2TPv2 IPv4 is supported by NVM with profile updated. Download
-        profile then set flowtype/pctype mapping, dynamic to change flow
-        director input set configuration for IPv4 DA words 27~28, setup
-        raw flow type filter for flow director, check flow director could
-        work when sending matched IPv4 DA packets to configured queue,
-        otherwise direct packets to queue 0.
-        """
-        crlwords = list(range(27, 29))
-        keywords = ["src_ip", "sport", "dport", "dst_ip"]
-        qchecks = ["sameq", "sameq", "sameq", "difq"]
-        self.run_fd_test(crlwords, 23, 18, keywords, qchecks)
-
-    def test_fd_pppol2tp_ipv6_dstipv6(self):
-        """
-        PPPoL2TPv2 IPv6 is supported by NVM with profile updated. Download
-        profile then set flowtype/pctype mapping, dynamic to change flow
-        director input set configuration for IPv6 DA words 21~28, setup
-        raw flow type filter for flow director, check flow director could
-        work when sending matched IPv6 DA packets to configured queue,
-        otherwise direct packets to queue 0.
-        """
-        crlwords = list(range(21, 29))
-        keywords = ["src_ipv6", "sport", "dport", "dst_ipv6"]
-        qchecks = ["sameq", "sameq", "sameq", "difq"]
-        self.run_fd_test(crlwords, 24, 19, keywords, qchecks)
-
     def tear_down(self):
         self.dut_testpmd.execute_cmd("stop")
         out = self.dut_testpmd.execute_cmd("ddp get list 0")
-- 
2.17.1


  parent reply	other threads:[~2022-12-15  7:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-15  6:41 [dts][PATCH V1 1/8] test_plans/ddp_gtp_qregion: " Lingli Chen
2022-12-15  6:41 ` [dts][PATCH V1 2/8] tests/ddp_gtp_qregion: " Lingli Chen
2022-12-15  6:41 ` [dts][PATCH V1 3/8] test_plans/ddp_l2tpv3: " Lingli Chen
2022-12-15  6:42 ` [dts][PATCH V1 4/8] tests/ddp_l2tpv3: " Lingli Chen
2022-12-15  6:42 ` [dts][PATCH V1 5/8] test_plans/ddp_ppp_l2tp: " Lingli Chen
2022-12-15  6:42 ` Lingli Chen [this message]
2022-12-22 12:00   ` [dts][PATCH V1 6/8] tests/ddp_ppp_l2tp: " lijuan.tu
2022-12-15  6:42 ` [dts][PATCH V1 7/8] test_plans/rss_to_rte_flow: " Lingli Chen
2022-12-15  6:42 ` [dts][PATCH V1 8/8] tests/rss_to_rte_flow: " Lingli Chen
2022-12-22  8:33   ` Li, WeiyuanX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221215064204.30802-6-linglix.chen@intel.com \
    --to=linglix.chen@intel.com \
    --cc=dts@dpdk.org \
    --cc=zhiminx.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).