test suite reviews and discussions
 help / color / mirror / Atom feed
From: Lingli Chen <linglix.chen@intel.com>
To: dts@dpdk.org
Cc: zhiminx.huang@intel.com, Lingli Chen <linglix.chen@intel.com>
Subject: [dts][PATCH V1] tests/*: add wait_link_status_up after start testpmd
Date: Wed, 21 Dec 2022 01:54:46 -0500	[thread overview]
Message-ID: <20221221065446.22316-1-linglix.chen@intel.com> (raw)

optimize script: external_mempool_handler, mtu_update add wait_link_status_up after start testpmd
to enhance script robustness.

Signed-off-by: Lingli Chen <linglix.chen@intel.com>
---
 tests/TestSuite_external_mempool_handler.py | 2 +-
 tests/TestSuite_mtu_update.py               | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_external_mempool_handler.py b/tests/TestSuite_external_mempool_handler.py
index aa22a35a..92790b2e 100644
--- a/tests/TestSuite_external_mempool_handler.py
+++ b/tests/TestSuite_external_mempool_handler.py
@@ -53,7 +53,7 @@ class TestExternalMempool(TestCase):
         self.pmdout.start_testpmd("1S/2C/1T", "--portmask=0x3")
         self.pmdout.execute_cmd("set fwd mac")
         self.pmdout.execute_cmd("start")
-
+        self.pmdout.wait_link_status_up('all')
         tgen_input = []
         tx_port = self.tester.get_local_port(self.dut_ports[0])
         rx_port = self.tester.get_local_port(self.dut_ports[1])
diff --git a/tests/TestSuite_mtu_update.py b/tests/TestSuite_mtu_update.py
index 4fc3c335..8fe53e22 100644
--- a/tests/TestSuite_mtu_update.py
+++ b/tests/TestSuite_mtu_update.py
@@ -219,7 +219,7 @@ class TestMtuUpdate(TestCase):
         self.exec("port start all")
         self.exec("set fwd mac")
         self.exec("start")
-        self.pmdout.wait_link_status_up(self.dut_ports[0])
+        self.pmdout.wait_link_status_up('all')
         """
         On 1G NICs, when the jubmo frame MTU set > 1500, the software adjust it to MTU+4.
         """
-- 
2.17.1


                 reply	other threads:[~2022-12-21  7:52 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221221065446.22316-1-linglix.chen@intel.com \
    --to=linglix.chen@intel.com \
    --cc=dts@dpdk.org \
    --cc=zhiminx.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).