test suite reviews and discussions
 help / color / mirror / Atom feed
From: Dukai Yuan <dukaix.yuan@intel.com>
To: dts@dpdk.org
Cc: Dukai Yuan <dukaix.yuan@intel.com>
Subject: [dts][PATCH V1] tests/loopback multi paths port restart: optimize the script to be consistent with test plan
Date: Fri, 23 Dec 2022 16:10:58 +0800	[thread overview]
Message-ID: <20221223081058.12501-1-dukaix.yuan@intel.com> (raw)

1.remove invalid description.
2.optimize the description of each case so that it can correspond to the testplan.
3.modify case 10 incorrect parameter inorder=1 to inorder=0.  

Signed-off-by: Dukai Yuan <dukaix.yuan@intel.com>
---
 ...Suite_loopback_multi_paths_port_restart.py | 31 +++++++++----------
 1 file changed, 14 insertions(+), 17 deletions(-)

diff --git a/tests/TestSuite_loopback_multi_paths_port_restart.py b/tests/TestSuite_loopback_multi_paths_port_restart.py
index c14070ce..76bf02f3 100644
--- a/tests/TestSuite_loopback_multi_paths_port_restart.py
+++ b/tests/TestSuite_loopback_multi_paths_port_restart.py
@@ -2,12 +2,6 @@
 # Copyright(c) 2010-2019 Intel Corporation
 #
 
-"""
-DPDK Test suite.
-Benchmark Vhost loopback for 7 RX/TX PATHs.
-Includes Mergeable, Normal, Vector_RX,Inorder_mergeable,
-Inorder_no_mergeable, VIRTIO1.1_mergeable, VIRTIO1.1_normal Path.
-"""
 import re
 import time
 
@@ -204,7 +198,7 @@ class TestLoopbackPortRestart(TestCase):
 
     def test_loopback_test_with_packed_ring_mergeable_path(self):
         """
-        performance for [frame_sizes] and restart port on virtio1.1 mergeable path
+        Test Case 1: loopback test with packed ring mergeable path
         """
         pmd_arg = {
             "version": "packed_vq=1,in_order=0,mrg_rxbuf=1 ",
@@ -219,7 +213,7 @@ class TestLoopbackPortRestart(TestCase):
 
     def test_loopback_test_with_packed_ring_nonmergeable_path(self):
         """
-        performance for [frame_sizes] and restart port ob virtio1.1 normal path
+        Test Case 2: loopback test with packed ring non-mergeable path
         """
         pmd_arg = {
             "version": "packed_vq=1,in_order=0,mrg_rxbuf=0 ",
@@ -233,6 +227,9 @@ class TestLoopbackPortRestart(TestCase):
         self.result_table_print()
 
     def test_lookback_test_with_packed_ring_inorder_mergeable_path(self):
+        """
+        Test Case 3: loopback test with packed ring inorder mergeable path
+        """
         pmd_arg = {
             "version": "packed_vq=1,mrg_rxbuf=1,in_order=1",
             "path": "--tx-offloads=0x0 --enable-hw-vlan-strip",
@@ -246,7 +243,7 @@ class TestLoopbackPortRestart(TestCase):
 
     def test_lookback_test_with_packed_ring_inorder_nonmergeable_path(self):
         """
-        performance for [frame_sizes] and restart port on inorder mergeable path
+        Test Case 4: loopback test with packed ring inorder non-mergeable path
         """
         pmd_arg = {
             "version": "packed_vq=1,mrg_rxbuf=0,in_order=1,vectorized=1",
@@ -261,10 +258,10 @@ class TestLoopbackPortRestart(TestCase):
 
     def test_lookback_test_with_packed_ring_vectorized_path(self):
         """
-        performance for [frame_sizes] and restart port on inorder mergeable path
+        Test Case 10: loopback test with packed ring vectorized path
         """
         pmd_arg = {
-            "version": "packed_vq=1,mrg_rxbuf=0,in_order=1,vectorized=1",
+            "version": "packed_vq=1,mrg_rxbuf=0,in_order=0,vectorized=1",
             "path": "--tx-offloads=0x0 --enable-hw-vlan-strip",
         }
         for frame_size in self.frame_sizes:
@@ -276,7 +273,7 @@ class TestLoopbackPortRestart(TestCase):
 
     def test_lookback_test_with_split_ring_inorder_mergeable_path(self):
         """
-        performance for [frame_sizes] and restart port on inorder normal path
+        Test Case 5: loopback test with split ring inorder mergeable path
         """
         pmd_arg = {
             "version": "packed_vq=0,in_order=1,mrg_rxbuf=1",
@@ -291,7 +288,7 @@ class TestLoopbackPortRestart(TestCase):
 
     def test_lookback_test_with_split_ring_inorder_nonmergeable_path(self):
         """
-        performance for [frame_sizes] and restart port on virtio normal path
+        Test Case 6: loopback test with split ring inorder non-mergeable path
         """
         pmd_arg = {
             "version": "packed_vq=0,in_order=1,mrg_rxbuf=0 ",
@@ -306,7 +303,7 @@ class TestLoopbackPortRestart(TestCase):
 
     def test_lookback_test_with_split_ring_mergeable_path(self):
         """
-        performance for [frame_sizes] and restart port on virtio normal path
+        Test Case 7: loopback test with split ring mergeable path
         """
         pmd_arg = {
             "version": "packed_vq=0,in_order=0,mrg_rxbuf=1",
@@ -321,11 +318,11 @@ class TestLoopbackPortRestart(TestCase):
 
     def test_lookback_test_with_split_ring_nonmergeable_path(self):
         """
-        performance for [frame_sizes] and restart port on virtio normal path
+        Test Case 8: loopback test with split ring non-mergeable path
         """
         pmd_arg = {
             "version": "packed_vq=0,in_order=0,mrg_rxbuf=0,vectorized=1",
-            "path": "--tx-offloads=0x0 --enable-hw-vlan-strip ",
+            "path": "--rx-offloads=0x0 --enable-hw-vlan-strip ",
         }
         for frame_size in self.frame_sizes:
             self.start_vhost_testpmd()
@@ -336,7 +333,7 @@ class TestLoopbackPortRestart(TestCase):
 
     def test_loopback_test_with_split_ring_vector_rx_path(self):
         """
-        performance for frame_sizes and restart port on virtio vector rx
+        Test Case 9: loopback test with split ring vector_rx path
         """
         pmd_arg = {
             "version": "packed_vq=0,in_order=0,mrg_rxbuf=0,vectorized=1",
-- 
2.17.1


                 reply	other threads:[~2022-12-23  8:16 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221223081058.12501-1-dukaix.yuan@intel.com \
    --to=dukaix.yuan@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).