test suite reviews and discussions
 help / color / mirror / Atom feed
From: Ke Xu <ke1.xu@intel.com>
To: dts@dpdk.org
Cc: ke1.xu@intel.com, weiyuanx.li@intel.com, qi.fu@intel.com,
	lijuan.tu@intel.com
Subject: [DTS][PATCH V6 1/5] tests/vf_offload: fix 2 typos and a bug.
Date: Fri, 23 Dec 2022 16:55:23 +0800	[thread overview]
Message-ID: <20221223085527.29760-2-ke1.xu@intel.com> (raw)
In-Reply-To: <20221223085527.29760-1-ke1.xu@intel.com>

Checksum is wrongly spelled as checksup.

Finally is wrongly spelled as fially.

String formating is wrongly put out
 side of the function call.

Signed-off-by: Ke Xu <ke1.xu@intel.com>
---
 tests/TestSuite_vf_offload.py | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/tests/TestSuite_vf_offload.py b/tests/TestSuite_vf_offload.py
index 26fad2b8..3fb6f9c8 100644
--- a/tests/TestSuite_vf_offload.py
+++ b/tests/TestSuite_vf_offload.py
@@ -265,7 +265,7 @@ class TestVfOffload(TestCase):
             (
                 ip_checksum,
                 tcp_checksum,
-                udp_checksup,
+                udp_checksum,
                 sctp_checksum,
             ) = packet_received.split(";")
             print(
@@ -273,8 +273,8 @@ class TestVfOffload(TestCase):
                 ip_checksum,
                 "tcp_checksum:, ",
                 tcp_checksum,
-                "udp_checksup: ",
-                udp_checksup,
+                "udp_checksum: ",
+                udp_checksum,
                 "sctp_checksum: ",
                 sctp_checksum,
             )
@@ -284,9 +284,9 @@ class TestVfOffload(TestCase):
             if tcp_checksum != "??":
                 packet_type = "TCP"
                 l4_checksum = tcp_checksum
-            elif udp_checksup != "??":
+            elif udp_checksum != "??":
                 packet_type = "UDP"
-                l4_checksum = udp_checksup
+                l4_checksum = udp_checksum
             elif sctp_checksum != "??":
                 packet_type = "SCTP"
                 l4_checksum = sctp_checksum
@@ -439,7 +439,7 @@ class TestVfOffload(TestCase):
             command = ("tcpdump -w tcpdump_{0}.pcap -i {0} 2>tcpdump_{0}.out &").format(
                 iface
             )
-            self.tester.send_expect("rm -f tcpdump_{0}.pcap", "#").format(iface)
+            self.tester.send_expect("rm -f tcpdump_{0}.pcap".format(iface), "#")
             self.tester.send_expect(command, "#")
 
     def tcpdump_stop_sniff(self):
@@ -478,8 +478,8 @@ class TestVfOffload(TestCase):
         Execute scanner to return results
         """
         scanner_result = self.tester.send_expect(scanner, "#")
-        fially_result = re.findall(r"length( \d+)", scanner_result)
-        return list(fially_result)
+        finally_result = re.findall(r"length( \d+)", scanner_result)
+        return list(finally_result)
 
     def number_of_bytes(self, iface):
         """
-- 
2.25.1


  reply	other threads:[~2022-12-23  8:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-23  8:55 [DTS][PATCH V6 0/5] add vf checksum offload and tso case for tunnel packets Ke Xu
2022-12-23  8:55 ` Ke Xu [this message]
2022-12-23  8:55 ` [DTS][PATCH V6 2/5] tests/vf_offload: add vf checksum hw offload case for tunneling packets Ke Xu
2022-12-23  8:55 ` [DTS][PATCH V6 3/5] tests/vf_offload: add vf tso " Ke Xu
2022-12-23  8:55 ` [DTS][PATCH V6 4/5] tests/vf_offload: add new method to anayse tunnel packets Ke Xu
2022-12-23  8:55 ` [DTS][PATCH V6 5/5] tests/vf_offload: fix and improve unstable implementations Ke Xu
2022-12-23  9:03   ` Li, WeiyuanX
2022-12-26  1:53 ` [DTS][PATCH V6 0/5] add vf checksum offload and tso case for tunnel packets Fu, Qi
2022-12-26  4:41 ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221223085527.29760-2-ke1.xu@intel.com \
    --to=ke1.xu@intel.com \
    --cc=dts@dpdk.org \
    --cc=lijuan.tu@intel.com \
    --cc=qi.fu@intel.com \
    --cc=weiyuanx.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).