test suite reviews and discussions
 help / color / mirror / Atom feed
From: Lingli Chen <linglix.chen@intel.com>
To: dts@dpdk.org
Cc: zhiminx.huang@intel.com, Lingli Chen <linglix.chen@intel.com>
Subject: [dts][PATCH V1] test_plans/*: remove --pkt-filter-mode sync dpdk change
Date: Thu, 29 Dec 2022 02:12:24 -0500	[thread overview]
Message-ID: <20221229071224.70651-1-linglix.chen@intel.com> (raw)

According to dpdk commit 5007ac1318 (ethdev: remove deprecated Flow Director configuration)
remove --pkt-filter-mode.

Signed-off-by: Lingli Chen <linglix.chen@intel.com>
---
 test_plans/ddp_gtp_test_plan.rst        | 7 +++----
 test_plans/flow_filtering_test_plan.rst | 1 -
 tests/TestSuite_ddp_gtp.py              | 2 +-
 3 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/test_plans/ddp_gtp_test_plan.rst b/test_plans/ddp_gtp_test_plan.rst
index ac694de2..2dd44640 100644
--- a/test_plans/ddp_gtp_test_plan.rst
+++ b/test_plans/ddp_gtp_test_plan.rst
@@ -49,12 +49,11 @@ Prerequisites
 5. Login vm0, then bind VF0 device to igb_uio driver.
 
 6. Start testpmd on host and vm0, host supports flow director and cloud
-   filter, VM supports cloud filter. If test PF flow director, need to add 
-   --pkt-filter-mode=perfect on testpmd to enable flow director, set chained 
-   port topology mode, add txq/rxq to enable multi-queues. In general, PF's 
+   filter, VM supports cloud filter.
+   set chained port topology mode, add txq/rxq to enable multi-queues. In general, PF's
    max queue is 64, VF's max queue is 4::
 
-    ./<build>/app/dpdk-testpmd -c f -n 4 -- -i --pkt-filter-mode=perfect --port-topology=chained --txq=64 --rxq=64
+    ./<build>/app/dpdk-testpmd -c f -n 4 -- -i --port-topology=chained --txq=64 --rxq=64
 
 
 Test Case: Load dynamic device personalization 
diff --git a/test_plans/flow_filtering_test_plan.rst b/test_plans/flow_filtering_test_plan.rst
index e4f7fe19..5bd88a48 100644
--- a/test_plans/flow_filtering_test_plan.rst
+++ b/test_plans/flow_filtering_test_plan.rst
@@ -18,7 +18,6 @@ http://doc.dpdk.org/guides/sample_app_ug/flow_filtering.html
 
 The matching item is dst IP address: "192.168.1.1".
 The match action is entering the queue 1.
-The flow example can specify fdir_mode by '--pkt-filter-mode',if not assign fdir_mode, IXGBE will not support flow example.
 IGB not support flow example.
 ICE support flow example.
 
diff --git a/tests/TestSuite_ddp_gtp.py b/tests/TestSuite_ddp_gtp.py
index d0c3b560..22e73318 100644
--- a/tests/TestSuite_ddp_gtp.py
+++ b/tests/TestSuite_ddp_gtp.py
@@ -157,7 +157,7 @@ class TestDdpGtp(TestCase):
         """
         self.dut_testpmd.start_testpmd(
             "Default",
-            "--pkt-filter-mode=perfect --port-topology=chained \
+            "--port-topology=chained \
             --txq=%s --rxq=%s"
             % (self.PF_QUEUE, self.PF_QUEUE),
         )
-- 
2.17.1


                 reply	other threads:[~2022-12-29  8:11 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221229071224.70651-1-linglix.chen@intel.com \
    --to=linglix.chen@intel.com \
    --cc=dts@dpdk.org \
    --cc=zhiminx.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).